)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e591455e4c230cad544ee201fcce52dd2fa6bf87","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.network_api \u003d network.API()"},{"line_number":235,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":236,"context_line":"        self.network_manager \u003d importutils.import_object("},{"line_number":237,"context_line":"            FLAGS.network_manager, host\u003dkwargs.get(\u0027host\u0027, None))"},{"line_number":238,"context_line":"        self._last_host_check \u003d 0"},{"line_number":239,"context_line":"        self._last_bw_usage_poll \u003d 0"},{"line_number":240,"context_line":"        self._last_info_cache_heal \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FY9I%3D","line":237,"updated":"2012-09-14 22:53:00.000000000","message":"This change doesn\u0027t look related to what is described in the commit message.  Can you elaborate or put this in another patch?","commit_id":"423dbafd08ac3bb970bcb842fa6e7812d42ceb4e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a1076fd9796dda81d229da9d76d6419be6afc881","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.network_api \u003d network.API()"},{"line_number":235,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":236,"context_line":"        self.network_manager \u003d importutils.import_object("},{"line_number":237,"context_line":"            FLAGS.network_manager, host\u003dkwargs.get(\u0027host\u0027, None))"},{"line_number":238,"context_line":"        self._last_host_check \u003d 0"},{"line_number":239,"context_line":"        self._last_bw_usage_poll \u003d 0"},{"line_number":240,"context_line":"        self._last_info_cache_heal \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FYeA%3D","line":237,"in_reply_to":"AAAALH%2F%2FY9I%3D","updated":"2012-09-17 13:59:11.000000000","message":"It is related. I makes the network manager that the compute manager instantiates use its own notion of host instead of having the network manager infer from FLAGS. It seems inline with the rest of the fixes that specify the use of self.host in the patch... Do you want something in the commit log or a # NOTE(danms) here perhaps?","commit_id":"423dbafd08ac3bb970bcb842fa6e7812d42ceb4e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f42a250ba8793669be1580a57f9564a01e1ec408","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.network_api \u003d network.API()"},{"line_number":235,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":236,"context_line":"        self.network_manager \u003d importutils.import_object("},{"line_number":237,"context_line":"            FLAGS.network_manager, host\u003dkwargs.get(\u0027host\u0027, None))"},{"line_number":238,"context_line":"        self._last_host_check \u003d 0"},{"line_number":239,"context_line":"        self._last_bw_usage_poll \u003d 0"},{"line_number":240,"context_line":"        self._last_info_cache_heal \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FYb4%3D","line":237,"in_reply_to":"AAAALH%2F%2FYeA%3D","updated":"2012-09-17 15:00:07.000000000","message":"Ah, ok ... makes sense now that I look closer.  I guess I was just expecting to see \u0027self.host\u0027 here, but I see that isn\u0027t set until later, when the parent class constructor runs.","commit_id":"423dbafd08ac3bb970bcb842fa6e7812d42ceb4e"}]}
