)]}'
{"nova/compute/api.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"4020635040de7c46754f01712caa38baaae83ac7","unresolved":false,"context_lines":[{"line_number":2300,"context_line":"            # TODO(eglynn): support a wider set of search options than just"},{"line_number":2301,"context_line":"            # all_tenants, at least include the standard filters defined for"},{"line_number":2302,"context_line":"            # the EC2 DescribeSecurityGroups API for the non-admin case also"},{"line_number":2303,"context_line":"            if (search_opts and \u0027all_tenants\u0027 in search_opts):"},{"line_number":2304,"context_line":"                groups \u003d self.db.security_group_get_all(context)"},{"line_number":2305,"context_line":"            else:"},{"line_number":2306,"context_line":"                groups \u003d self.db.security_group_get_by_project(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FZRU%3D","line":2303,"updated":"2012-09-14 13:58:42.000000000","message":"Should we put some sort of boolean check on this?\n\nAs is if I specify all_tenants\u003d0 this would still evaluate to true right? Could be a bit confusing....","commit_id":"29af2252a8bc97157a52fddca78b31224eb55dac"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"764fef96e1db3656b611e192144ca719586d1f23","unresolved":false,"context_lines":[{"line_number":2300,"context_line":"            # TODO(eglynn): support a wider set of search options than just"},{"line_number":2301,"context_line":"            # all_tenants, at least include the standard filters defined for"},{"line_number":2302,"context_line":"            # the EC2 DescribeSecurityGroups API for the non-admin case also"},{"line_number":2303,"context_line":"            if (search_opts and \u0027all_tenants\u0027 in search_opts):"},{"line_number":2304,"context_line":"                groups \u003d self.db.security_group_get_all(context)"},{"line_number":2305,"context_line":"            else:"},{"line_number":2306,"context_line":"                groups \u003d self.db.security_group_get_by_project(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FZPY%3D","line":2303,"in_reply_to":"AAAALH%2F%2FZP8%3D","updated":"2012-09-14 14:41:23.000000000","message":"Okay. Given there is some precedent for this I suppose this is good for now. Perhaps making all of these options a bit more intuitive is worth tackling in Grizzly.\n\nThanks for the explanation!","commit_id":"29af2252a8bc97157a52fddca78b31224eb55dac"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"1411ea790308ee6114d26c7954f528a359ee122c","unresolved":false,"context_lines":[{"line_number":2300,"context_line":"            # TODO(eglynn): support a wider set of search options than just"},{"line_number":2301,"context_line":"            # all_tenants, at least include the standard filters defined for"},{"line_number":2302,"context_line":"            # the EC2 DescribeSecurityGroups API for the non-admin case also"},{"line_number":2303,"context_line":"            if (search_opts and \u0027all_tenants\u0027 in search_opts):"},{"line_number":2304,"context_line":"                groups \u003d self.db.security_group_get_all(context)"},{"line_number":2305,"context_line":"            else:"},{"line_number":2306,"context_line":"                groups \u003d self.db.security_group_get_by_project(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FZP8%3D","line":2303,"in_reply_to":"AAAALH%2F%2FZRU%3D","updated":"2012-09-14 14:34:26.000000000","message":"Yeah, I thought about this, but the convention for the existing native APIs that use an all_tenants search opt (i.e. servers, volumes, snapshots) is just to check for the presence of the option but ignore its value.\n\nSo I followed this convention for consistency with the rest of the native API.\n\nNote that the nova CLI will strip out a search option that is false, so:\n\n  nova secgroup-list --all-tenants\u003d0\n\nwill not lead to \u0027?all_tenants\u003d0\u0027 being added as a query param on the GET request. So I guess the corresponding API logic makes some kind of sense in that light of that (though I agree, it is counter-intuitive).\n\nFor the EC2 API, I went with the more intuitive approach of the all-tenants filter value being meaningful.","commit_id":"29af2252a8bc97157a52fddca78b31224eb55dac"}]}