)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"9ff91489d284f2cbfddae05709af317b57681b55","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aaron Rosen \u003carosen@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-09-17 15:51:22 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ensure_default_security_group() does not call sgh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1050982"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAALH%2F%2FXu0%3D","line":7,"updated":"2012-09-18 01:47:39.000000000","message":"this should specify what the change does, as in:\n\nmakes ensure_default_security_group trigger sg handler\n\nor something","commit_id":"83c471b10f72c90962a55ad6fd5f8a492ceaec0c"}],"nova/compute/api.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"6af0fe1e1ad1ba7799eb5ba93924afa6fc249f6b","unresolved":false,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        :param context: the security context"},{"line_number":2235,"context_line":"        \"\"\""},{"line_number":2236,"context_line":"        self.db.security_group_ensure_default(context, self.sgh)"},{"line_number":2237,"context_line":""},{"line_number":2238,"context_line":"    def create(self, context, name, description):"},{"line_number":2239,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FZFI%3D","line":2236,"updated":"2012-09-14 19:20:50.000000000","message":"i think:\n  group \u003d self.db.security_group_ensure_default(context)\n  self.sgh.trigger...(group)\n\nshould work, no?","commit_id":"120994dafbcb08137748574312de21d0911d35f1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8acfd7cedfe12cde26f8e60cb2db8e90d51eb607","unresolved":false,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        :param context: the security context"},{"line_number":2235,"context_line":"        \"\"\""},{"line_number":2236,"context_line":"        self.db.security_group_ensure_default(context, self.sgh)"},{"line_number":2237,"context_line":""},{"line_number":2238,"context_line":"    def create(self, context, name, description):"},{"line_number":2239,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FZEs%3D","line":2236,"in_reply_to":"AAAALH%2F%2FZFI%3D","updated":"2012-09-14 19:29:06.000000000","message":"Nope, because group is returned even if it existed or not. If this was done we would be calling self.sgh.trigger..(group) every time even if the default group existed or not.","commit_id":"120994dafbcb08137748574312de21d0911d35f1"}],"nova/db/api.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"0fccf2213e96d7d81a023e48f9d5c8788ef89e7e","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"def security_group_ensure_default(context):"},{"line_number":1291,"context_line":"    \"\"\"Ensure default security group exists for a project_id."},{"line_number":1292,"context_line":"    Returns a tuple with the first element being a bool indicating"},{"line_number":1293,"context_line":"    if the default security group previously existed. Second"},{"line_number":1294,"context_line":"    element is the dict used to create the default security group."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALH%2F%2FXnI%3D","line":1291,"updated":"2012-09-18 06:50:10.000000000","message":"according to hacking there should be a blank line here","commit_id":"ca8f2c15cca15883e69fd8762f3dc41250582b85"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"232d4b02f5be32768d4b65fe4f20a3059a29859d","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"def security_group_ensure_default(context):"},{"line_number":1291,"context_line":"    \"\"\"Ensure default security group exists for a project_id."},{"line_number":1292,"context_line":"    Returns a tuple with the first element being a bool indicating"},{"line_number":1293,"context_line":"    if the default security group previously existed. Second"},{"line_number":1294,"context_line":"    element is the dict used to create the default security group."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALH%2F%2FXmg%3D","line":1291,"in_reply_to":"AAAALH%2F%2FXnI%3D","updated":"2012-09-18 07:03:13.000000000","message":"Done","commit_id":"ca8f2c15cca15883e69fd8762f3dc41250582b85"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"9ff91489d284f2cbfddae05709af317b57681b55","unresolved":false,"context_lines":[{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"    def _get_sec_group_models(session, security_groups):"},{"line_number":1420,"context_line":"        models \u003d []"},{"line_number":1421,"context_line":"        _, default_group \u003d security_group_ensure_default(context,"},{"line_number":1422,"context_line":"                                                         session\u003dsession)"},{"line_number":1423,"context_line":"        if \u0027default\u0027 in security_groups:"},{"line_number":1424,"context_line":"            models.append(default_group)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FXvI%3D","line":1421,"updated":"2012-09-18 01:47:39.000000000","message":"i would use _existed or something just so you don\u0027t accidentally overwrite our gettext handler which is _","commit_id":"83c471b10f72c90962a55ad6fd5f8a492ceaec0c"}]}