)]}'
{"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"839b3c8b9e0832c378a445d6f011c4ae32b524bf","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        prop \u003d prop.val.value"},{"line_number":940,"context_line":"    else:"},{"line_number":941,"context_line":"        # reaching here represents an impossible state"},{"line_number":942,"context_line":"        raise RuntimeError("},{"line_number":943,"context_line":"            \"Virtual Machine %s exists without a runtime.host!\""},{"line_number":944,"context_line":"            % (vm_ref))"},{"line_number":945,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_b424810d","side":"PARENT","line":942,"updated":"2014-10-27 13:26:44.000000000","message":"what about this case?","commit_id":"941bcf9d4ac103c86fa5f01246876f642252d7a5"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"21acb1b6f9c5110dc6aad221504a74a6ff12415b","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        prop \u003d prop.val.value"},{"line_number":940,"context_line":"    else:"},{"line_number":941,"context_line":"        # reaching here represents an impossible state"},{"line_number":942,"context_line":"        raise RuntimeError("},{"line_number":943,"context_line":"            \"Virtual Machine %s exists without a runtime.host!\""},{"line_number":944,"context_line":"            % (vm_ref))"},{"line_number":945,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_3c43fcaf","side":"PARENT","line":942,"in_reply_to":"9aa7fdbe_a2950c34","updated":"2014-10-28 10:13:33.000000000","message":"This whole section of code is re-implementing get_dynamic_property, so it should be handled there.","commit_id":"941bcf9d4ac103c86fa5f01246876f642252d7a5"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"2f1c320ef5626508ac78f8322ddd239d7064ddef","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        prop \u003d prop.val.value"},{"line_number":940,"context_line":"    else:"},{"line_number":941,"context_line":"        # reaching here represents an impossible state"},{"line_number":942,"context_line":"        raise RuntimeError("},{"line_number":943,"context_line":"            \"Virtual Machine %s exists without a runtime.host!\""},{"line_number":944,"context_line":"            % (vm_ref))"},{"line_number":945,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_a2950c34","side":"PARENT","line":942,"in_reply_to":"9aa7fdbe_b424810d","updated":"2014-10-28 08:05:21.000000000","message":"if runtime.host is None the next call to get_dynamic_property will throw which is fine I think","commit_id":"941bcf9d4ac103c86fa5f01246876f642252d7a5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"839b3c8b9e0832c378a445d6f011c4ae32b524bf","unresolved":false,"context_lines":[{"line_number":896,"context_line":"    return vm_ref"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"def get_host_ref_for_vm(session, instance):"},{"line_number":900,"context_line":"    \"\"\"Get a MoRef to the ESXi host currently running an instance.\"\"\""},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    vm_ref \u003d get_vm_ref(session, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_94421dac","line":899,"updated":"2014-10-27 13:26:44.000000000","message":"this method is only used internally - consider setting it to _get_host_ref_for_vm","commit_id":"c7b52123d4be99f1495278f2a0d7458ea7441414"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"2f1c320ef5626508ac78f8322ddd239d7064ddef","unresolved":false,"context_lines":[{"line_number":896,"context_line":"    return vm_ref"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"def get_host_ref_for_vm(session, instance):"},{"line_number":900,"context_line":"    \"\"\"Get a MoRef to the ESXi host currently running an instance.\"\"\""},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    vm_ref \u003d get_vm_ref(session, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_e2b634f8","line":899,"in_reply_to":"9aa7fdbe_94421dac","updated":"2014-10-28 08:05:21.000000000","message":"I\u0027d rather inline this method below","commit_id":"c7b52123d4be99f1495278f2a0d7458ea7441414"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"21acb1b6f9c5110dc6aad221504a74a6ff12415b","unresolved":false,"context_lines":[{"line_number":896,"context_line":"    return vm_ref"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"def get_host_ref_for_vm(session, instance):"},{"line_number":900,"context_line":"    \"\"\"Get a MoRef to the ESXi host currently running an instance.\"\"\""},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    vm_ref \u003d get_vm_ref(session, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_5c2e00fc","line":899,"in_reply_to":"9aa7fdbe_e2b634f8","updated":"2014-10-28 10:13:33.000000000","message":"I was inclined to throw it away too, but it was used in the iscsi patches so I decided to keep it around for a bit. It \u0027feels\u0027 like it should be useful.","commit_id":"c7b52123d4be99f1495278f2a0d7458ea7441414"}]}