)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"318a4268c1fb56cb11e786481d9bb64c62680186","unresolved":false,"context_lines":[{"line_number":3912,"context_line":"            raise exception.RequestedVRamTooHigh(req_vram\u003dvideo_ram,"},{"line_number":3913,"context_line":"                                                 max_vram\u003dmax_vram)"},{"line_number":3914,"context_line":"        if max_vram and video_ram:"},{"line_number":3915,"context_line":"            video.vram \u003d video_ram * units.Ki"},{"line_number":3916,"context_line":"        guest.add_device(video)"},{"line_number":3917,"context_line":""},{"line_number":3918,"context_line":"    def _add_qga_device(self, guest, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_e57e9f69","line":3915,"updated":"2014-12-02 12:53:57.000000000","message":"The usual way to scale would be\n\n  video_ram * units.Mi / units.Ki\n\nMultiplying by units.Ki only works by luck because  units.Mi / units.Ki happens to equal units.Ki.","commit_id":"bab0b6b3d94aa0154cf68bf17b2aa9aa55654133"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"93381cb784507da1aaf6163ed53c3a5c9b4318f6","unresolved":false,"context_lines":[{"line_number":3912,"context_line":"            raise exception.RequestedVRamTooHigh(req_vram\u003dvideo_ram,"},{"line_number":3913,"context_line":"                                                 max_vram\u003dmax_vram)"},{"line_number":3914,"context_line":"        if max_vram and video_ram:"},{"line_number":3915,"context_line":"            video.vram \u003d video_ram * units.Mi / units.Ki"},{"line_number":3916,"context_line":"        guest.add_device(video)"},{"line_number":3917,"context_line":""},{"line_number":3918,"context_line":"    def _add_qga_device(self, guest, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_bef80a4b","line":3915,"updated":"2014-12-03 06:00:12.000000000","message":"The unit of hw_video_ram is MB like\n\n 55         \"hw_video_ram\": {\n 56             \"title\": \"Max Video Ram\",\n 57             \"description\": \"Maximum RAM (unit: MB) for the video image. Used only if a hw_video:ram_max_mb value has been set in the flavor\u0027s extra_specs and that v    alue is higher than the value set in hw_video_ram.\",\n 58             \"type\": \"integer\",\n 59             \"minimum\": 0\n 60         },\n\non glance side as this commit mentioned. and the unit of libvirt is KB like\n\n 361 -\u003evram \u003d \u003cvalue kilobyte\u003e         \u003c\u003d\u003e   svga.vramSize \u003d \"\u003cvalue byte\u003e\"\n\nso LGTM.","commit_id":"f84fe4b067b12ff0b56cc788057f1726df0feace"}]}