)]}'
{"nova/tests/virt/libvirt/test_imagebackend.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c13488cec2f4bde5e6b9e5dbd6357295e3e308d","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        model \u003d image.get_model(FakeConn())"},{"line_number":497,"context_line":"        self.assertEqual(imgmodel.LocalFileImage(self.PATH,"},{"line_number":498,"context_line":"                                                 imgmodel.FORMAT_QCOW2),"},{"line_number":499,"context_line":"                        model)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"class LvmTestCase(_ImageTestCase, test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_a7d096f8","line":499,"updated":"2014-11-08 18:34:45.000000000","message":"indentation here is a bit odd","commit_id":"cbac2fa8253df65916293dc2bbca074a14e947ff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c13488cec2f4bde5e6b9e5dbd6357295e3e308d","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        self.assertEqual(image.path, rbd_path)"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    @mock.patch.object(rbd_utils.RBDDriver, \"get_mon_addrs\")"},{"line_number":1286,"context_line":"    def test_get_model(self, mock_mon_addrs):"},{"line_number":1287,"context_line":"        pool \u003d \"FakePool\""},{"line_number":1288,"context_line":"        user \u003d \"FakeUser\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_4709b294","line":1285,"updated":"2014-11-08 18:34:45.000000000","message":"you can do a return value here.\n@mock.patch.object(rbd_utils.RBDDriver, \"get_mon_addrs\",\n                   return_value\u003d...)\nbut i guess it will not be as readable as below","commit_id":"cbac2fa8253df65916293dc2bbca074a14e947ff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c13488cec2f4bde5e6b9e5dbd6357295e3e308d","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"        pool \u003d \"FakePool\""},{"line_number":1288,"context_line":"        user \u003d \"FakeUser\""},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"        self.flags(images_rbd_pool\u003dpool, group\u003d\u0027libvirt\u0027)"},{"line_number":1291,"context_line":"        self.flags(rbd_user\u003duser, group\u003d\u0027libvirt\u0027)"},{"line_number":1292,"context_line":"        self.flags(rbd_secret_uuid\u003d\"3306a5c4-8378-4b3c-aa1f-7b48d3a26172\","},{"line_number":1293,"context_line":"                   group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_c7cda25f","line":1290,"updated":"2014-11-08 18:34:45.000000000","message":"any reason not to fold the two lines below into this:\nself.flags(images_rbd_pool\u003dpool,\n           rbd_user\u003duser,\n           rbd_secret_uuid\u003d\"3306a5c4-8378-4b3c-aa1f-7b48d3a26172\",\n           group\u003d\u0027libvirt\u0027)","commit_id":"cbac2fa8253df65916293dc2bbca074a14e947ff"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c13488cec2f4bde5e6b9e5dbd6357295e3e308d","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                                          reason\u003dreason)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def get_model(self, connection):"},{"line_number":759,"context_line":"        secret \u003d None"},{"line_number":760,"context_line":"        if CONF.libvirt.rbd_secret_uuid:"},{"line_number":761,"context_line":"            secretobj \u003d connection.secretLookupByUUIDString("},{"line_number":762,"context_line":"                CONF.libvirt.rbd_secret_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_a7f7b68b","line":759,"updated":"2014-11-08 18:34:45.000000000","message":"please see line 763","commit_id":"cbac2fa8253df65916293dc2bbca074a14e947ff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c13488cec2f4bde5e6b9e5dbd6357295e3e308d","unresolved":false,"context_lines":[{"line_number":760,"context_line":"        if CONF.libvirt.rbd_secret_uuid:"},{"line_number":761,"context_line":"            secretobj \u003d connection.secretLookupByUUIDString("},{"line_number":762,"context_line":"                CONF.libvirt.rbd_secret_uuid)"},{"line_number":763,"context_line":"            secret \u003d base64.b64encode(secretobj.value())"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        hosts, ports \u003d self.driver.get_mon_addrs()"},{"line_number":766,"context_line":"        servers \u003d [str(\u0027:\u0027.join(k)) for k in zip(hosts, ports)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_67feae6d","line":763,"updated":"2014-11-08 18:34:45.000000000","message":"else:\n    secret \u003d None","commit_id":"cbac2fa8253df65916293dc2bbca074a14e947ff"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b4950f03ab8a5aed5e8c01805a522f8446bfa12f","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            secret \u003d base64.b64encode(secretobj.value())"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        hosts, ports \u003d self.driver.get_mon_addrs()"},{"line_number":766,"context_line":"        servers \u003d [str(\u0027:\u0027.join(k)) for k in zip(hosts, ports)]"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"        return imgmodel.RBDImage(self.rbd_name,"},{"line_number":769,"context_line":"                                 self.pool,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_b465af1e","line":766,"updated":"2014-12-02 11:39:37.000000000","message":"nit: unnecessary str() ?","commit_id":"5ed39af47265d2ced86e0f4c0c5bd5e629cb3c54"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"a4884877ca043364edae2e5aaae1514f8451af5e","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            secret \u003d base64.b64encode(secretobj.value())"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        hosts, ports \u003d self.driver.get_mon_addrs()"},{"line_number":766,"context_line":"        servers \u003d [str(\u0027:\u0027.join(k)) for k in zip(hosts, ports)]"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"        return imgmodel.RBDImage(self.rbd_name,"},{"line_number":769,"context_line":"                                 self.pool,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_5c50f4d3","line":766,"in_reply_to":"5a890539_b465af1e","updated":"2014-12-12 08:45:13.000000000","message":"+1","commit_id":"5ed39af47265d2ced86e0f4c0c5bd5e629cb3c54"}]}