)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4761f03ccf677c92ff864450af7c2852de5125c0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        message \u003d fault.__class__.__name__"},{"line_number":65,"context_line":"    # NOTE(dripton) The message field in the database is limited to 255 chars."},{"line_number":66,"context_line":"    # MySQL silently truncates overly long messages, but PostgreSQL throws an"},{"line_number":67,"context_line":"    # error if we don\u0027t truncate it."},{"line_number":68,"context_line":"    u_message \u003d encodeutils.safe_decode(encodeutils.safe_encode(message)[:255])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    fault_dict \u003d dict(exception\u003dfault)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_2eab2ad7","line":67,"updated":"2014-11-07 11:18:58.000000000","message":"nit: I think it\u0027s worthy to add some comments about unicode?","commit_id":"a704c8f251b3e004d1bb3dcb55ab14bc56d46b49"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"1b689d0d3bf133a778d516c6b799d41accaca628","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        message \u003d fault.__class__.__name__"},{"line_number":65,"context_line":"    # NOTE(dripton) The message field in the database is limited to 255 chars."},{"line_number":66,"context_line":"    # MySQL silently truncates overly long messages, but PostgreSQL throws an"},{"line_number":67,"context_line":"    # error if we don\u0027t truncate it."},{"line_number":68,"context_line":"    u_message \u003d encodeutils.safe_decode(encodeutils.safe_encode(message)[:255])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    fault_dict \u003d dict(exception\u003dfault)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_90883ac8","line":67,"in_reply_to":"7a8c0949_2eab2ad7","updated":"2014-11-07 19:03:06.000000000","message":"I did not add new comment here, because I feel the existing comment is enough. My new code behavior is still truncating message to 255. I do not think anybody will mis-understand.","commit_id":"a704c8f251b3e004d1bb3dcb55ab14bc56d46b49"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4153067a48a4651c6ee59d77ab1c80ab65f4f68","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        message \u003d fault.__class__.__name__"},{"line_number":65,"context_line":"    # NOTE(dripton) The message field in the database is limited to 255 chars."},{"line_number":66,"context_line":"    # MySQL silently truncates overly long messages, but PostgreSQL throws an"},{"line_number":67,"context_line":"    # error if we don\u0027t truncate it."},{"line_number":68,"context_line":"    u_message \u003d encodeutils.safe_decode(encodeutils.safe_encode(message)[:255])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    fault_dict \u003d dict(exception\u003dfault)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_c98460d6","line":67,"in_reply_to":"7a8c0949_2eab2ad7","updated":"2014-11-07 13:25:58.000000000","message":"We were casting to unicode before this change so I don\u0027t think we need to make a comment about it now, it\u0027s in the commit message for history if someone really wants to dig into this.  I wouldn\u0027t -1 over it but you can add a little note if you want.","commit_id":"a704c8f251b3e004d1bb3dcb55ab14bc56d46b49"}],"nova/tests/compute/test_compute_utils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4153067a48a4651c6ee59d77ab1c80ab65f4f68","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        self.assertEqual(reboot_type, \u0027HARD\u0027)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"class OtherTestCase(test.TestCase):"},{"line_number":832,"context_line":"    def test_exception_to_dict_with_long_message(self):"},{"line_number":833,"context_line":"        # Generate Russian byte message whose length is 300"},{"line_number":834,"context_line":"        msg \u003d encodeutils.safe_decode(\u0027 \\xd0\\xb2\u0027 * 100)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_1e43fd42","line":831,"updated":"2014-11-07 13:25:58.000000000","message":"nit: I\u0027d probably name this ComputeUtilsTestCase, since that\u0027s probably better given the module it\u0027s testing and is still generic.\n\nOtherwise, -1 because this should extend test.NoDbTestCase.  New unit tests shouldn\u0027t require the database, so let\u0027s not enable it.","commit_id":"a704c8f251b3e004d1bb3dcb55ab14bc56d46b49"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"d617a72551907a2330dfcbb20f2852466de409c9","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        self.assertEqual(reboot_type, \u0027HARD\u0027)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"class OtherTestCase(test.TestCase):"},{"line_number":832,"context_line":"    def test_exception_to_dict_with_long_message(self):"},{"line_number":833,"context_line":"        # Generate Russian byte message whose length is 300"},{"line_number":834,"context_line":"        msg \u003d encodeutils.safe_decode(\u0027 \\xd0\\xb2\u0027 * 100)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_70bbce72","line":831,"in_reply_to":"7a8c0949_1e43fd42","updated":"2014-11-07 19:07:28.000000000","message":"Done","commit_id":"a704c8f251b3e004d1bb3dcb55ab14bc56d46b49"}]}