)]}'
{"id":"openstack%2Fnova~1328","triplet_id":"openstack%2Fnova~stable%2Fdiablo~Ie439c6743f066f8504ef88de861dee8a7762940d","project":"openstack/nova","branch":"stable/diablo","topic":"bug/834633","hashtags":[],"change_id":"Ie439c6743f066f8504ef88de861dee8a7762940d","subject":"Fixes bug 834633 - Auto assigning floating IPs","status":"MERGED","created":"2011-11-04 19:44:29.000000000","updated":"2011-11-09 23:20:07.000000000","submitted":"2011-11-09 23:20:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f50950bd061e1c04363c3ead20b3adcde4cd1e59","_number":1328,"virtual_id_number":1328,"owner":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2011-11-09 23:20:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"recommended":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"all":[{"value":1,"date":"2011-11-09 03:20:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":2,"date":"2011-11-09 23:10:31.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2011-11-09 23:20:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2011-11-08 16:01:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"date":"2011-11-08 18:08:58.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2011-11-08 16:08:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-08 15:39:29.000000000","updated_by":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"reviewer":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"state":"REVIEWER"},{"updated":"2011-11-08 16:08:47.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2011-11-08 18:08:58.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2011-11-09 03:20:50.000000000","updated_by":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"reviewer":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"state":"REVIEWER"},{"updated":"2011-11-09 23:10:31.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-11-09 23:20:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cccb9cff25127a276de1948d5848beeb4c6d22d6","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-04 20:01:07.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nTested as working correctly. Both auto and manually assigned floating IPs now work correctly.","accounts_in_message":[],"_revision_number":1},{"id":"ea994e6fc4aa25dc5cd11af6b979d05f9a1d92fb","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-04 20:08:50.000000000","message":"Patch Set 1:\n\nAlso, https://review.openstack.org/628 includes these fixes, among others, for the master branch.","accounts_in_message":[],"_revision_number":1},{"id":"cd3063b1bbd24f50dc98ee5011656e9795db6557","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2011-11-08 15:31:01.000000000","message":"Patch Set 1:\n\nOk, it took me a while to figure out what\u0027s going on here, but here\u0027s the story:\n\n* This is all specific to auto_assign_floating_ip\u003dtrue, which is False by default. This was a new feature in Diablo (https://blueprints.launchpad.net/nova/+spec/floating-ip-auto-assignment) and it looks like it never actually worked since this bug appears to have been there from the beginning.\n* Trey\u0027s change on master (https://review.openstack.org/#change,628) is a substantial re-factoring which moves code from the network API stubs into the network manager\n* As a side-effect, Trey fixed an issue (#834633) where a FloatingIp object was passed to network_api.associate_floating_ip() instead of an address string\n* In #834633, Serguei Koubli had previously (i.e. before Trey\u0027s refactoring) proposed a much more isolated fix for this issue\n* Kiall has taken Serguei\u0027s original fix, but also fixed a separate issue with disassociating auto assigned IPs. This too appears to have been fixed during Trey\u0027s refactoring","accounts_in_message":[],"_revision_number":1},{"id":"1eb154ff592db9d8fd8d47891090d89a830b317d","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2011-11-08 15:39:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nKiall, you need to add yourself to the Authors file in order for the tests to pass\n\nOther than that, lgtm\n\nI\u0027d like to see Trey review this though","accounts_in_message":[],"_revision_number":1},{"id":"1db80934a84052d16f36fb8a9e92d5211f92f852","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-08 15:46:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"526f6c05863357bd1e9abb3dc68cecb03e1ce3ba","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-08 15:46:42.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nUpdated Authors file per Mark\u0027s request.","accounts_in_message":[],"_revision_number":2},{"id":"e2c956b6d12c8fff7c6a770854bd5845ce7b8d77","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-08 16:01:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c8c07c2acb04c37d63f3ae04e2c0349c0edea112","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-08 16:01:52.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d2a1f9b3992ba54a263d1d4f8e87ccbfc0c5a12a","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2011-11-08 16:02:05.000000000","message":"Patch Set 3:\n\nUpdated commit message per Mark\u0027s IRC request.","accounts_in_message":[],"_revision_number":3},{"id":"992d8ab164b4ecdba3b89b79600b8c0c1133793a","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2011-11-08 16:08:47.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nThanks!","accounts_in_message":[],"_revision_number":3},{"id":"3e9027cc72a12f861ad531a0f48459ff848802bf","author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"date":"2011-11-09 03:20:50.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nIs Bueno! Would be nice if the tests were updated as well to catch when auto-assignment is not working ;).","accounts_in_message":[],"_revision_number":3},{"id":"2ecf23e3fcf34e367e03830606eccf14f819b274","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-11-09 23:10:31.000000000","message":"Patch Set 3: Looks good to me, approved\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"9fadddc00c041833f452a6e77dbc471cd644f070","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-09 23:20:06.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/nova/121856/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-merge/342/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-pep8/1715/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"607c77aa97570bc1b79a268d86780277b5ae0035","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-09 23:20:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"80d73a2df2c33212217c59783f62d74673776ebb","revisions":{"054cb741208afe3c98725ce92ad23293bbe29d88":{"kind":"REWORK","_number":1,"created":"2011-11-04 19:44:29.000000000","uploader":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"ref":"refs/changes/28/1328/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/28/1328/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/28/1328/1"}}},"commit":{"parents":[{"commit":"c206f73d03aa487868ba2acaa3581624160d1b67","subject":"Adds ext4 and reiserfs to _mount_filesystem().","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c206f73d03aa487868ba2acaa3581624160d1b67"}]}],"author":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-04 19:43:50.000000000","tz":0},"committer":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-04 19:43:50.000000000","tz":0},"subject":"Fixes bug 834633 - Auto assigning floating IPs","message":"Fixes bug 834633 - Auto assigning floating IPs\n\nChange-Id: Ie439c6743f066f8504ef88de861dee8a7762940d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/054cb741208afe3c98725ce92ad23293bbe29d88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/054cb741208afe3c98725ce92ad23293bbe29d88"}]},"parents_data":[{"branch_name":"refs/heads/stable/diablo","commit_id":"c206f73d03aa487868ba2acaa3581624160d1b67","is_merged_in_target_branch":true,"change_id":"Ie19d5ecf5764eb93346fa773f6437c2370ad7a5b","change_number":1131,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/diablo"},"1e3a40f9acc043fd7956d4be74504d5ea8b29cfb":{"kind":"REWORK","_number":2,"created":"2011-11-08 15:46:04.000000000","uploader":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"ref":"refs/changes/28/1328/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/28/1328/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/28/1328/2"}}},"commit":{"parents":[{"commit":"c11659215a1cd3e551ce56f089b2682842954b04","subject":"Improve access check on images","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c11659215a1cd3e551ce56f089b2682842954b04"}]}],"author":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-04 19:43:50.000000000","tz":0},"committer":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-08 15:45:57.000000000","tz":0},"subject":"Fixes bug 834633 - Auto assigning floating IPs","message":"Fixes bug 834633 - Auto assigning floating IPs\n\nChange-Id: Ie439c6743f066f8504ef88de861dee8a7762940d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e3a40f9acc043fd7956d4be74504d5ea8b29cfb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e3a40f9acc043fd7956d4be74504d5ea8b29cfb"}]},"parents_data":[{"branch_name":"refs/heads/stable/diablo","commit_id":"c11659215a1cd3e551ce56f089b2682842954b04","is_merged_in_target_branch":true,"change_id":"Idc15125371950e0c07b1dac48e8b844887fefc9d","change_number":1132,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/diablo"},"80d73a2df2c33212217c59783f62d74673776ebb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2011-11-08 16:01:37.000000000","uploader":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"ref":"refs/changes/28/1328/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/28/1328/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/1328/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/28/1328/3"}}},"commit":{"parents":[{"commit":"c11659215a1cd3e551ce56f089b2682842954b04","subject":"Improve access check on images","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c11659215a1cd3e551ce56f089b2682842954b04"}]}],"author":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-04 19:43:50.000000000","tz":0},"committer":{"name":"Kiall Mac Innes","email":"kiall@managedit.ie","date":"2011-11-08 15:56:18.000000000","tz":0},"subject":"Fixes bug 834633 - Auto assigning floating IPs","message":"Fixes bug 834633 - Auto assigning floating IPs\n\nDetails:\n\n - This fix is specific to the auto_assign_floating_ip\u003dtrue feature, which was new in diablo[1] and looks like it never actually worked.\n - Trey\u0027s refactoring on master[2] fixed bug #834633 where a FloatingIp object was passed to network_api.associate_floating_ip() instead of an address string.\n - In bug #834633, Serguei Koubli had previously (i.e. before Trey\u0027s refactoring) proposed a much more isolated fix for this issue.\n - This commit includes Serguei Koubli\u0027s fix, and, has also fixed a seperate issue where auto-assigned flating IPs could not be deallocated. (This fix was also included in Trey\u0027s refactoring)\n\n[1] https://blueprints.launchpad.net/nova/+spec/floating-ip-auto-assignment\n[2] https://review.openstack.org/628\n\nChange-Id: Ie439c6743f066f8504ef88de861dee8a7762940d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80d73a2df2c33212217c59783f62d74673776ebb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80d73a2df2c33212217c59783f62d74673776ebb"}]},"parents_data":[{"branch_name":"refs/heads/stable/diablo","commit_id":"c11659215a1cd3e551ce56f089b2682842954b04","is_merged_in_target_branch":true,"change_id":"Idc15125371950e0c07b1dac48e8b844887fefc9d","change_number":1132,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/diablo"}},"requirements":[],"submit_records":[],"submit_requirements":[]}