)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"aa8d821d37ecbbd0ef757490d4ea1b8ddce32277","unresolved":false,"context_lines":[{"line_number":10,"context_line":"do _init_instance."},{"line_number":11,"context_line":"This patch will check this task staus when nova compute service"},{"line_number":12,"context_line":"do _init_instance, revert it to a normal status, besides, will"},{"line_number":13,"context_line":"revert quotas back."},{"line_number":14,"context_line":"Change-Id: I65fc099ef6803fecc15095e208ee280550c45d25"},{"line_number":15,"context_line":"Closes-Bug: 1389127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_c9eb1611","line":13,"updated":"2015-03-15 22:38:19.000000000","message":"How/where exactly are the quotas reverted back? (i don\u0027t see the code responsible)","commit_id":"137528d975cc1cc44674cd3c47f1aeb279da45ba"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"53f00822bff51d356181b2055501cf2315abaae7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"do _init_instance."},{"line_number":11,"context_line":"This patch will check this task staus when nova compute service"},{"line_number":12,"context_line":"do _init_instance, revert it to a normal status, besides, will"},{"line_number":13,"context_line":"revert quotas back."},{"line_number":14,"context_line":"Change-Id: I65fc099ef6803fecc15095e208ee280550c45d25"},{"line_number":15,"context_line":"Closes-Bug: 1389127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_2485b9ce","line":13,"in_reply_to":"9a80dd14_c9eb1611","updated":"2015-03-16 01:40:07.000000000","message":"hi dims, I forget to update it after I update code, I dropped quotas checking.\n\nthanks I will update this commit message.\n\nEli.","commit_id":"137528d975cc1cc44674cd3c47f1aeb279da45ba"}],"nova/compute/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7f2c55ae37a55fa1c4b4cede4a28e88e672fc47e","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                    project_id, user_id \u003d \\"},{"line_number":917,"context_line":"                        quotas_obj.ids_from_instance(context, instance)"},{"line_number":918,"context_line":"                    quotas.reserve(context, project_id\u003dproject_id,"},{"line_number":919,"context_line":"                                   user_id\u003duser_id, **deltas)"},{"line_number":920,"context_line":"                except Exception:"},{"line_number":921,"context_line":"                    msg \u003d _LE(\u0027Can not revert quotas\u0027)"},{"line_number":922,"context_line":"                    LOG.exception(msg, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3e5a352a","line":919,"updated":"2014-11-17 04:16:38.000000000","message":"if we reserve the quota here, where should we commit or rollback it?","commit_id":"591f0d85225a176843c7dcde9ebf125b0a90dd3b"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"756f412ca770125cff4a02cd2662af47103213bd","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                    project_id, user_id \u003d \\"},{"line_number":917,"context_line":"                        quotas_obj.ids_from_instance(context, instance)"},{"line_number":918,"context_line":"                    quotas.reserve(context, project_id\u003dproject_id,"},{"line_number":919,"context_line":"                                   user_id\u003duser_id, **deltas)"},{"line_number":920,"context_line":"                except Exception:"},{"line_number":921,"context_line":"                    msg \u003d _LE(\u0027Can not revert quotas\u0027)"},{"line_number":922,"context_line":"                    LOG.exception(msg, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5e42a1ae","line":919,"in_reply_to":"5a890539_3e5a352a","updated":"2014-11-17 05:20:53.000000000","message":"Done","commit_id":"591f0d85225a176843c7dcde9ebf125b0a90dd3b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e8b804a71cbf4f18dea49126cb6d16c202bf86fb","unresolved":false,"context_lines":[{"line_number":913,"context_line":"            if old_flavor and new_flavor:"},{"line_number":914,"context_line":"                deltas[\u0027cores\u0027] \u003d new_flavor[\u0027vcpus\u0027] - old_flavor[\u0027vcpus\u0027]"},{"line_number":915,"context_line":"                deltas[\u0027ram\u0027] \u003d new_flavor[\u0027memory_mb\u0027] \\"},{"line_number":916,"context_line":"                                    - old_flavor[\u0027memory_mb\u0027]"},{"line_number":917,"context_line":"                quotas \u003d objects.Quotas()"},{"line_number":918,"context_line":"                try:"},{"line_number":919,"context_line":"                    project_id, user_id \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_2883dbcc","line":916,"updated":"2014-12-12 15:03:17.000000000","message":"we can avoid migrate case here \nsince the old and new flavor is same","commit_id":"9c55e37d0861dc96363c8eaac3ee115290e9582e"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"4be0fea92e7435911e2270c63330bafc643dffa1","unresolved":false,"context_lines":[{"line_number":913,"context_line":"            if old_flavor and new_flavor:"},{"line_number":914,"context_line":"                deltas[\u0027cores\u0027] \u003d new_flavor[\u0027vcpus\u0027] - old_flavor[\u0027vcpus\u0027]"},{"line_number":915,"context_line":"                deltas[\u0027ram\u0027] \u003d new_flavor[\u0027memory_mb\u0027] \\"},{"line_number":916,"context_line":"                                    - old_flavor[\u0027memory_mb\u0027]"},{"line_number":917,"context_line":"                quotas \u003d objects.Quotas()"},{"line_number":918,"context_line":"                try:"},{"line_number":919,"context_line":"                    project_id, user_id \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_3f292c9b","line":916,"in_reply_to":"3a961159_2883dbcc","updated":"2014-12-15 02:42:38.000000000","message":"yeah, good idea , I will add testing here.","commit_id":"9c55e37d0861dc96363c8eaac3ee115290e9582e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e8b804a71cbf4f18dea49126cb6d16c202bf86fb","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                deltas[\u0027cores\u0027] \u003d new_flavor[\u0027vcpus\u0027] - old_flavor[\u0027vcpus\u0027]"},{"line_number":915,"context_line":"                deltas[\u0027ram\u0027] \u003d new_flavor[\u0027memory_mb\u0027] \\"},{"line_number":916,"context_line":"                                    - old_flavor[\u0027memory_mb\u0027]"},{"line_number":917,"context_line":"                quotas \u003d objects.Quotas()"},{"line_number":918,"context_line":"                try:"},{"line_number":919,"context_line":"                    project_id, user_id \u003d \\"},{"line_number":920,"context_line":"                        quotas_obj.ids_from_instance(context, instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c8b3374b","line":917,"updated":"2014-12-12 15:03:17.000000000","message":"would be better to add context as param like other usages","commit_id":"9c55e37d0861dc96363c8eaac3ee115290e9582e"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"4be0fea92e7435911e2270c63330bafc643dffa1","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                deltas[\u0027cores\u0027] \u003d new_flavor[\u0027vcpus\u0027] - old_flavor[\u0027vcpus\u0027]"},{"line_number":915,"context_line":"                deltas[\u0027ram\u0027] \u003d new_flavor[\u0027memory_mb\u0027] \\"},{"line_number":916,"context_line":"                                    - old_flavor[\u0027memory_mb\u0027]"},{"line_number":917,"context_line":"                quotas \u003d objects.Quotas()"},{"line_number":918,"context_line":"                try:"},{"line_number":919,"context_line":"                    project_id, user_id \u003d \\"},{"line_number":920,"context_line":"                        quotas_obj.ids_from_instance(context, instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5f1b5880","line":917,"in_reply_to":"3a961159_c8b3374b","updated":"2014-12-15 02:42:38.000000000","message":"Done","commit_id":"9c55e37d0861dc96363c8eaac3ee115290e9582e"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7f2c55ae37a55fa1c4b4cede4a28e88e672fc47e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from nova.tests import fake_instance"},{"line_number":47,"context_line":"from nova.tests.objects import test_flavor"},{"line_number":48,"context_line":"from nova.tests.objects import test_instance_fault"},{"line_number":49,"context_line":"from nova.tests.objects import test_instance_info_cache"},{"line_number":50,"context_line":"from nova import utils"},{"line_number":51,"context_line":"from nova.virt import hardware"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_7e667dee","line":49,"updated":"2014-11-17 04:16:38.000000000","message":"why remove \u0027unit\u0027 here?","commit_id":"591f0d85225a176843c7dcde9ebf125b0a90dd3b"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"756f412ca770125cff4a02cd2662af47103213bd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from nova.tests import fake_instance"},{"line_number":47,"context_line":"from nova.tests.objects import test_flavor"},{"line_number":48,"context_line":"from nova.tests.objects import test_instance_fault"},{"line_number":49,"context_line":"from nova.tests.objects import test_instance_info_cache"},{"line_number":50,"context_line":"from nova import utils"},{"line_number":51,"context_line":"from nova.virt import hardware"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_de0851dc","line":49,"in_reply_to":"5a890539_7e667dee","updated":"2014-11-17 05:20:53.000000000","message":"hmm, I don\u0027t notice it when I do the rebase.\nthanks for point it out.","commit_id":"591f0d85225a176843c7dcde9ebf125b0a90dd3b"}]}