)]}'
{"id":"openstack%2Fnova~13321","triplet_id":"openstack%2Fnova~master~Ibb49f7b9028085d2aedaf05b94e1e1dcdf5e4cb4","project":"openstack/nova","branch":"master","topic":"bug/1050359","hashtags":[],"change_id":"Ibb49f7b9028085d2aedaf05b94e1e1dcdf5e4cb4","subject":"Replace builtin hash with MD5 to solve 32/64-bit issues.","status":"MERGED","created":"2012-09-19 22:03:54.000000000","updated":"2012-09-20 16:22:18.000000000","submitted":"2012-09-20 16:22:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"df1d961454e078ecfb8691d08b3cd9d1f7a08840","_number":13321,"virtual_id_number":13321,"owner":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":2,"date":"2012-09-20 16:22:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":1,"date":"2012-09-20 02:54:25.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-09-20 08:48:17.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-09-20 14:54:12.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-09-20 08:48:17.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-09-20 14:54:17.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-19 23:51:40.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-09-20 02:54:25.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-09-20 08:48:17.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-09-20 14:54:17.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-09-20 16:22:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"02719386d4f2ad305e1bffa1196e2d5ca546e0ce","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-09-19 22:12:34.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nNasty.  Yeah, I doubt we should have ever tried to use the result of hash() outside of the python environment…","accounts_in_message":[],"_revision_number":1},{"id":"1365ed683680d9b2c479f71d10c1bce9ca076314","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-19 22:19:02.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nChange looks good, but please remove the import ctypes.\n\nthanks!","accounts_in_message":[],"_revision_number":1},{"id":"c1ca74758a04994414d4cec3412d3910cc5e9f02","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-19 22:23:04.000000000","message":"Patch Set 1:\n\nAlso it would be good to keep the same Change-Id: I0a4f11b34a1f76cda279ec801cede1440c6e5966 as the cinder change to ease tracking?","accounts_in_message":[],"_revision_number":1},{"id":"212e5b583e5a2159f8789bf6cbabfc8117584015","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-19 22:35:04.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/13321/1/check/gate-nova-merge/9005 : SUCCESS\n- http://logs.openstack.org/13321/1/check/gate-nova-docs/4780 : SUCCESS\n- http://logs.openstack.org/13321/1/check/gate-nova-pep8/10091 : SUCCESS\n- http://logs.openstack.org/13321/1/check/gate-nova-python26/6238 : SUCCESS\n- http://logs.openstack.org/13321/1/check/gate-nova-python27/6301 : FAILURE\n- http://logs.openstack.org/13321/1/check/gate-tempest-devstack-vm/12212 : SUCCESS\n- http://logs.openstack.org/13321/1/check/gate-tempest-devstack-vm-cinder/2192 : FAILURE\n- http://logs.openstack.org/13321/1/check/gate-nova-pylint/1032 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"33db389962253d594553b47b915fc8b87c6b1310","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2012-09-19 23:41:35.000000000","message":"Patch Set 1:\n\nHow to I explicitly set the Change-Id? I had assumed it was set by Gerrit and was not developer-modifiable.","accounts_in_message":[],"_revision_number":1},{"id":"a2cccc2701ca542db0c7d157eab6133e1c50769d","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-19 23:46:55.000000000","message":"Patch Set 1:\n\nIt\u0027s auto set by gerrit, but you can copy and replace them as required. No big deal really.","accounts_in_message":[],"_revision_number":1},{"id":"2671a58ae561c8672b87225891c24fc118c81f61","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-19 23:50:32.000000000","message":"Patch Set 1:\n\nNote changing the ID will essentially create a new change,\nso probably best to not bother changing this one, so just\nuse that info if syncing changes between projects and branches in future. thanks!","accounts_in_message":[],"_revision_number":1},{"id":"412a9f76e925ee7002ee11f0c2577142cdf0b37d","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-09-19 23:51:40.000000000","message":"Patch Set 1:\n\nit is added on your end by a commit hook. It won\u0027t be added if one is in place so you can just do:\n\ngit commit --amend\n\nand modify the Change-Id: line that you see at the bottom.","accounts_in_message":[],"_revision_number":1},{"id":"41942ec90742b5bf4c03115deeacc9ab10caa002","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2012-09-19 23:54:14.000000000","message":"Patch Set 1:\n\nDoes anyone know why Jenkins has a beef with this change? I can\u0027t see a relationship between my changes and the test failure in Jenkins...","accounts_in_message":[],"_revision_number":1},{"id":"af3a507fc4da1b53783a2ec58a44040f97e84258","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-20 01:20:21.000000000","message":"Patch Set 1:\n\nThe jenkins failure is unrelated. I refrained from triggering a recheck which is done by leaving a message with just \"recheck\" (without quotes), as I had a pending question about the now unused ctypes module. thanks.","accounts_in_message":[],"_revision_number":1},{"id":"13fe9a9932a8ec5cff5cd061b5e8dcf916526978","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-09-20 01:44:24.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/35785\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/35783\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/35748\n","accounts_in_message":[],"_revision_number":1},{"id":"3c89f98d7a1b3ce1ba804990d9ec1785d2168e5a","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2012-09-20 02:34:12.000000000","message":"Patch Set 1:\n\nOkay I was waiting to remove the ctypes import in case some other change was needed to fix the Jenkins issue.","accounts_in_message":[],"_revision_number":1},{"id":"15fbf2056a1d4980ea78d7daa321398b982a1e6e","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2012-09-20 02:35:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"997956851e0857b78e5341f00cd02e420373b14a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-09-20 02:54:25.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/35800\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/35798\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/35799\n","accounts_in_message":[],"_revision_number":2},{"id":"d53184dadd45be40844318018dac5e6a12b57051","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-20 03:04:44.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/13321/2/check/gate-nova-merge/9071 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-nova-docs/4835 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-nova-pep8/10145 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-nova-python26/6292 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-nova-python27/6355 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-tempest-devstack-vm/12287 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-tempest-devstack-vm-cinder/2266 : SUCCESS\n- http://logs.openstack.org/13321/2/check/gate-nova-pylint/1043 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c711f42abf301f6a6035fec5af86856255220570","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-20 08:48:17.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nthanks!\nYou probably also want to remove the ctypes import in cinder","accounts_in_message":[],"_revision_number":2},{"id":"8a787781cb2eb9b4fd2d6313daab0902df10d6a1","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-09-20 09:05:15.000000000","message":"Patch Set 2:\n\nBTW are there upgrade scenarios to worry about here with the mount points changing?","accounts_in_message":[],"_revision_number":2},{"id":"9df1c0e539af4e9d74277b87362a7972406e9597","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-09-20 14:54:12.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7d2d837e64d3a600d0d918de6bc8fc8ad9ac0277","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-09-20 14:54:17.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"929748adcbd367c5aea1cd7f8b1a6aa8043fd219","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-20 14:55:04.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"807200fe28025f0b8bab676652e8edcdb4c99969","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-20 16:22:17.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/13321/2/gate/gate-nova-merge/9129 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-nova-docs/4891 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-nova-pep8/10201 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-nova-python26/6346 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-nova-python27/6411 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-tempest-devstack-vm/12379 : SUCCESS\n- http://logs.openstack.org/13321/2/gate/gate-tempest-devstack-vm-cinder/2358 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"4dfdbea774d773f37d94480e30bd050a5430d51a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-20 16:22:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ba8cca2b59bb2904635520ad12f6d9a73f10242c","revisions":{"c02304c455e0b58427ad2700f22c8845bf337a87":{"kind":"REWORK","_number":1,"created":"2012-09-19 22:03:54.000000000","uploader":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"ref":"refs/changes/21/13321/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/13321/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/13321/1"}}},"commit":{"parents":[{"commit":"2934799fda4ca62337833a3ed736da5dce1210ae","subject":"Merge \"Added script to find unused config options.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2934799fda4ca62337833a3ed736da5dce1210ae"}]}],"author":{"name":"Ben Swartzlander","email":"bswartz@netapp.com","date":"2012-09-19 21:30:22.000000000","tz":-240},"committer":{"name":"Ben Swartzlander","email":"bswartz@netapp.com","date":"2012-09-19 21:30:22.000000000","tz":-240},"subject":"Replace builtin hash with MD5 to solve 32/64-bit issues.","message":"Replace builtin hash with MD5 to solve 32/64-bit issues.\n\nIt seems that Python\u0027s builtin hash returns different\nvalues on 32-bit and 64-bit architectures, so it\u0027s\nsafer to use a well-defined hash like MD5.\n\nbug 1050359\n\nChange-Id: Ibb49f7b9028085d2aedaf05b94e1e1dcdf5e4cb4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c02304c455e0b58427ad2700f22c8845bf337a87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c02304c455e0b58427ad2700f22c8845bf337a87"}]},"branch":"refs/heads/master"},"ba8cca2b59bb2904635520ad12f6d9a73f10242c":{"kind":"REWORK","_number":2,"created":"2012-09-20 02:35:40.000000000","uploader":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"ref":"refs/changes/21/13321/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/13321/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/13321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/13321/2"}}},"commit":{"parents":[{"commit":"2934799fda4ca62337833a3ed736da5dce1210ae","subject":"Merge \"Added script to find unused config options.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2934799fda4ca62337833a3ed736da5dce1210ae"}]}],"author":{"name":"Ben Swartzlander","email":"bswartz@netapp.com","date":"2012-09-19 21:30:22.000000000","tz":-240},"committer":{"name":"Ben Swartzlander","email":"bswartz@netapp.com","date":"2012-09-20 02:35:17.000000000","tz":-240},"subject":"Replace builtin hash with MD5 to solve 32/64-bit issues.","message":"Replace builtin hash with MD5 to solve 32/64-bit issues.\n\nIt seems that Python\u0027s builtin hash returns different\nvalues on 32-bit and 64-bit architectures, so it\u0027s\nsafer to use a well-defined hash like MD5.\n\nbug 1050359\n\nChange-Id: Ibb49f7b9028085d2aedaf05b94e1e1dcdf5e4cb4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba8cca2b59bb2904635520ad12f6d9a73f10242c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba8cca2b59bb2904635520ad12f6d9a73f10242c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}