)]}'
{"nova/conductor/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9cb4a57ad9e3c4b735a0470316288af2cce6da1","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return self._manager.service_get_all_by(context, topic, host,"},{"line_number":150,"context_line":"                binary\u003dNone)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def service_get_by_compute_host(self, context, host):"},{"line_number":153,"context_line":"        result \u003d self._manager.service_get_all_by(context, \u0027compute\u0027, host,"},{"line_number":154,"context_line":"                binary\u003dNone)"},{"line_number":155,"context_line":"        # FIXME(comstud): A major revision bump to 2.0 should return a"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_b78b8d1d","side":"PARENT","line":152,"updated":"2014-12-13 19:42:40.000000000","message":"Why are you not removing service_get_by_compute_host along with the others? (I\u0027m unfamiliar, but I see that Service has a get_by_compute_host function)","commit_id":"17aded08bbe911060f79aedbfc3a1b66e94bc9ae"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"4e0f08f694f92d3a99e0592f5259ad4d671b8194","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return self._manager.service_get_all_by(context, topic, host,"},{"line_number":150,"context_line":"                binary\u003dNone)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def service_get_by_compute_host(self, context, host):"},{"line_number":153,"context_line":"        result \u003d self._manager.service_get_all_by(context, \u0027compute\u0027, host,"},{"line_number":154,"context_line":"                binary\u003dNone)"},{"line_number":155,"context_line":"        # FIXME(comstud): A major revision bump to 2.0 should return a"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_e3cc1a64","side":"PARENT","line":152,"in_reply_to":"3a961159_b78b8d1d","updated":"2015-01-22 11:45:56.000000000","message":"This is still used in resource tracker, until recently in a way that made it hard to convert to objects as the service object only stores a single compute node while the conductor call returns the full list as returned by the db call.\n\nNow that https://review.openstack.org/126573 has merged things become easier so I will add a change to convert that final call as well.","commit_id":"17aded08bbe911060f79aedbfc3a1b66e94bc9ae"}],"nova/conductor/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9cb4a57ad9e3c4b735a0470316288af2cce6da1","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @messaging.expected_exceptions(exception.ComputeHostNotFound,"},{"line_number":273,"context_line":"                                   exception.HostBinaryNotFound)"},{"line_number":274,"context_line":"    def service_get_all_by(self, context, topic, host, binary):"},{"line_number":275,"context_line":"        if not any((topic, host, binary)):"},{"line_number":276,"context_line":"            result \u003d self.db.service_get_all(context)"},{"line_number":277,"context_line":"        elif all((topic, host)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_f7fd156f","line":274,"updated":"2014-12-13 19:42:40.000000000","message":"Will this not also be removed in version 3.0?","commit_id":"b4c930c2686d2b31828af187ae586a36df1475dd"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9cb4a57ad9e3c4b735a0470316288af2cce6da1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                          instance\u003dinstance_p, last_refreshed\u003dlast_refreshed,"},{"line_number":247,"context_line":"                          update_totals\u003dupdate_totals)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def service_get_all_by(self, context, topic\u003dNone, host\u003dNone, binary\u003dNone):"},{"line_number":250,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":251,"context_line":"        return cctxt.call(context, \u0027service_get_all_by\u0027,"},{"line_number":252,"context_line":"                          topic\u003dtopic, host\u003dhost, binary\u003dbinary)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_37fb1d7a","side":"PARENT","line":249,"updated":"2014-12-13 19:42:40.000000000","message":"Same, why keep this one?","commit_id":"17aded08bbe911060f79aedbfc3a1b66e94bc9ae"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9cb4a57ad9e3c4b735a0470316288af2cce6da1","unresolved":false,"context_lines":[{"line_number":835,"context_line":"                           (\u0027host\u0027,),"},{"line_number":836,"context_line":"                           dict(host\u003d\u0027host\u0027, topic\u003dNone, binary\u003dNone))"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"    def test_service_get_by_compute_host(self):"},{"line_number":839,"context_line":"        self._test_stubbed(\u0027service_get_by_compute_host\u0027,"},{"line_number":840,"context_line":"                           (\u0027host\u0027,),"},{"line_number":841,"context_line":"                           dict(topic\u003d\u0027compute\u0027, host\u003d\u0027host\u0027, binary\u003dNone),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_77f12594","side":"PARENT","line":838,"updated":"2014-12-13 19:42:40.000000000","message":"Why does this one stay?","commit_id":"17aded08bbe911060f79aedbfc3a1b66e94bc9ae"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9cb4a57ad9e3c4b735a0470316288af2cce6da1","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    def test_service_get_all_by_host(self):"},{"line_number":986,"context_line":"        self._test_stubbed(\u0027service_get_all_by_host\u0027, \u0027host\u0027)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    def test_service_get_by_compute_host(self):"},{"line_number":989,"context_line":"        self._test_stubbed(\u0027service_get_by_compute_host\u0027, \u0027host\u0027)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"    def test_service_get_by_args(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_77acc58c","side":"PARENT","line":988,"updated":"2014-12-13 19:42:40.000000000","message":"Why is this test_service_get_by_compute_host removed and the other two aren\u0027t?","commit_id":"17aded08bbe911060f79aedbfc3a1b66e94bc9ae"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"78fb172362ea98fc0a860ed13ea48325fc180a97","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            else:"},{"line_number":401,"context_line":"                self.assertEqual(condargs, result)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_service_get_all(self):"},{"line_number":404,"context_line":"        self._test_stubbed(\u0027service_get_all\u0027, (),"},{"line_number":405,"context_line":"                dict(host\u003dNone, topic\u003dNone, binary\u003dNone))"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7aaa499b_7aaf9d94","line":403,"updated":"2015-04-14 16:19:48.000000000","message":"Note for other reviewers, these tests were replicated in multiple places. This is the start of where we still verify them for the compat manager code we\u0027re leaving in place. The big removals on the left are for the api and rpcapi versions, which are now gone.","commit_id":"6285d6a5114b739697f8d0041e31b0b945facf7c"}]}