)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e164178cfbffcf58e806d56c129754971a560b3a","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            self._cleanup_volumes(context, instance_uuid)"},{"line_number":900,"context_line":"        except Exception as exc:"},{"line_number":901,"context_line":"            LOG.warn(_(\"Ignoring volume cleanup failure due to %s\") % exc,"},{"line_number":902,"context_line":"                     instance_uuid\u003dinstance_uuid)"},{"line_number":903,"context_line":"        # if a delete task succeed, always update vm state and task state"},{"line_number":904,"context_line":"        # without expecting task state to be DELETING"},{"line_number":905,"context_line":"        instance \u003d self._instance_update(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTzA%3D","line":902,"updated":"2012-09-23 20:48:52.000000000","message":"Might it be marginally more useful diagnostic information to include the problematic volume ID instead of the instance ID in the log message?\n\nThis would probably require that the exception be caught within the _cleanup_volumes method. A useful side-effect of moving the try...except to that method would be that for instances with multiple volumes in it\u0027s block device mappings, one failure to delete wouldn\u0027t mean that we give up on trying to delete the remaining volumes.","commit_id":"4a97a743c41e53d7278590e75913ff761ea319db"}]}