)]}'
{"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cf9f43cbfa6460f4217ae8ee5cd3a40d54ae05ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"from oslo.serialization import jsonutils"},{"line_number":23,"context_line":"from oslo.utils import timeutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from nova.compute import flavors"},{"line_number":26,"context_line":"from nova.compute import resource_tracker"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_de65acaf","side":"PARENT","line":23,"updated":"2014-11-25 10:09:46.000000000","message":"Why did you removed this line?","commit_id":"b01087d61e7e6bd10ada35ede5fc848a70a38fcf"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cf9f43cbfa6460f4217ae8ee5cd3a40d54ae05ed","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from nova import rpc"},{"line_number":35,"context_line":"from nova import test"},{"line_number":36,"context_line":"from nova.tests.unit.compute.monitors import test_monitors"},{"line_number":37,"context_line":"from nova.tests.unit.objects import test_migration"},{"line_number":38,"context_line":"from nova.tests.unit.pci import fakes as pci_fakes"},{"line_number":39,"context_line":"from nova.virt import driver"},{"line_number":40,"context_line":"from nova.virt import hardware"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_fe07c8c7","side":"PARENT","line":37,"updated":"2014-11-25 10:09:46.000000000","message":"ditto","commit_id":"b01087d61e7e6bd10ada35ede5fc848a70a38fcf"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cf9f43cbfa6460f4217ae8ee5cd3a40d54ae05ed","unresolved":false,"context_lines":[{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"    def _fake_migration_create(self, context, values\u003dNone):"},{"line_number":1007,"context_line":"        instance_uuid \u003d str(uuid.uuid1())"},{"line_number":1008,"context_line":"        mig_dict \u003d test_migration.fake_db_migration()"},{"line_number":1009,"context_line":"        mig_dict.update({"},{"line_number":1010,"context_line":"            \u0027id\u0027: 1,"},{"line_number":1011,"context_line":"            \u0027source_compute\u0027: \u0027host1\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_bee54039","line":1008,"updated":"2014-11-25 10:09:46.000000000","message":"F821 undefined name \u0027test_migration\u0027","commit_id":"900d4614650992543f582237026cf84acea2be1e"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cf9f43cbfa6460f4217ae8ee5cd3a40d54ae05ed","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            \u0027new_instance_type_id\u0027: 2,"},{"line_number":1018,"context_line":"            \u0027instance_uuid\u0027: instance_uuid,"},{"line_number":1019,"context_line":"            \u0027status\u0027: \u0027pre-migrating\u0027,"},{"line_number":1020,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow()"},{"line_number":1021,"context_line":"            })"},{"line_number":1022,"context_line":"        if values:"},{"line_number":1023,"context_line":"            mig_dict.update(values)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_1eef341f","line":1020,"range":{"start_line":1020,"start_character":26,"end_line":1020,"end_character":35},"updated":"2014-11-25 10:09:46.000000000","message":"F821 undefined name \u0027timeutils\u0027","commit_id":"900d4614650992543f582237026cf84acea2be1e"}],"nova/tests/unit/compute/test_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e0dfb7054ba8eb7054dcd777fa57dedac6fc0b51","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        self.assertFalse(self.rt.disabled)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        pci_mock.return_value \u003d objects.InstancePCIRequests()"},{"line_number":726,"context_line":"        pci_mock.return_value.requests \u003d []"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        disk_used \u003d self.instance.root_gb + self.instance.ephemeral_gb"},{"line_number":729,"context_line":"        expected \u003d copy.deepcopy(_COMPUTE_NODE_FIXTURE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5050370a","line":726,"updated":"2014-11-20 18:51:52.000000000","message":"This is fine, but might be a bit clearer to write:\n\n pci_mock.return_value \u003d objects.InstabncePCIRequests(requests\u003d[])","commit_id":"c610db3e80b5ff1b0d6393b38396e2dfd5c17dcb"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e0dfb7054ba8eb7054dcd777fa57dedac6fc0b51","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        self.assertFalse(self.rt.disabled)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"        pci_mock.return_value \u003d objects.InstancePCIRequests()"},{"line_number":769,"context_line":"        pci_mock.return_value.requests \u003d []"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        self.instance.numa_topology \u003d _INSTANCE_NUMA_TOPOLOGIES[\u00272mb\u0027]"},{"line_number":772,"context_line":"        host_topology \u003d _NUMA_HOST_TOPOLOGIES[\u00272mb\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_7057f302","line":769,"updated":"2014-11-20 18:51:52.000000000","message":"ditto from above","commit_id":"c610db3e80b5ff1b0d6393b38396e2dfd5c17dcb"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"a0d5780e3c82d28d05da8ff962f78b09eebb6f5c","unresolved":false,"context_lines":[{"line_number":949,"context_line":"            \u0027memory_mb_used\u0027: self.instance.memory_mb,"},{"line_number":950,"context_line":"            \u0027free_disk_gb\u0027: _COMPUTE_NODE_FIXTURES[0][\u0027local_gb\u0027] - disk_used,"},{"line_number":951,"context_line":"            \"free_ram_mb\":"},{"line_number":952,"context_line":"                _COMPUTE_NODE_FIXTURES[0][\u0027memory_mb\u0027] - self.instance.memory_mb,"},{"line_number":953,"context_line":"            \u0027running_vms\u0027: 1,"},{"line_number":954,"context_line":"            # \u0027vcpus_used\u0027: 0,  # vcpus are not claimed"},{"line_number":955,"context_line":"            \u0027pci_stats\u0027: \u0027[]\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_77f437cf","line":952,"updated":"2014-11-21 13:02:28.000000000","message":"E501 line too long (81 \u003e 79 characters)","commit_id":"74b544eabc63aa3f377fae508e7c25887dddf5c3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cb0ca7e20abe06be315119045e8293fe3806471e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"_MIGRATION_SYS_META \u003d flavors.save_flavor_info("},{"line_number":135,"context_line":"        _MIGRATION_SYS_META, _INSTANCE_TYPE_FIXTURES[2], \u0027new_\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"MB2 \u003d 2 * 1024"},{"line_number":138,"context_line":"_INSTANCE_NUMA_TOPOLOGIES \u003d {"},{"line_number":139,"context_line":"    \u00272mb\u0027: objects.InstanceNUMATopology(cells\u003d["},{"line_number":140,"context_line":"        objects.InstanceNUMACell("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_38009b33","line":137,"updated":"2014-11-24 18:20:09.000000000","message":"Memory is measure in kilobytes here, or you meant to use (1024 ** 2)?  I would suggest using oslo.utils.units for this.  So \u00272 * units.Mi\u0027.","commit_id":"900d4614650992543f582237026cf84acea2be1e"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"c420117742722970856af7788191663763012fec","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        self.instance.numa_topology \u003d _INSTANCE_NUMA_TOPOLOGIES[\u00272mb\u0027]"},{"line_number":988,"context_line":"        host_topology \u003d _NUMA_HOST_TOPOLOGIES[\u00272mb\u0027]"},{"line_number":989,"context_line":"        self.rt.compute_node[\u0027numa_topology\u0027] \u003d host_topology._to_json()"},{"line_number":990,"context_line":"        limits \u003d {\u0027numa_topology\u0027: objects.base.obj_to_primitive("},{"line_number":991,"context_line":"            _NUMA_LIMIT_TOPOLOGIES[\u00272mb\u0027])}"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        expected_numa \u003d copy.deepcopy(host_topology)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_0ca3a843","line":990,"range":{"start_line":990,"start_character":35,"end_line":990,"end_character":64},"updated":"2015-01-06 23:54:10.000000000","message":"AttributeError: \u0027NUMATopologyLimits\u0027 object has no attribute \u0027iteritems\u0027","commit_id":"7dac575ad8e747263d979c6b3f416f1c509a7db9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"406d23ebd800569cc4334353975cd92f62c0a97e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"_2MB \u003d 2 * units.Mi / units.Ki"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"_INSTANCE_NUMA_TOPOLOGIES \u003d {"},{"line_number":141,"context_line":"    \u00272mb\u0027: objects.InstanceNUMATopology(cells\u003d["},{"line_number":142,"context_line":"        objects.InstanceNUMACell("},{"line_number":143,"context_line":"            id\u003d0, cpuset\u003dset([1]), memory\u003d_2MB, pagesize\u003d0),"},{"line_number":144,"context_line":"        objects.InstanceNUMACell("}],"source_content_type":"text/x-python","patch_set":13,"id":"fa81d914_d9757f33","line":141,"updated":"2015-01-27 20:39:45.000000000","message":"nit: \u00272MB\" as the key, no ?","commit_id":"06bfaa30cee55f19d322df8ebe225ab4c175e611"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"406d23ebd800569cc4334353975cd92f62c0a97e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"_INSTANCE_FIXTURES \u003d ["},{"line_number":170,"context_line":"    objects.Instance("},{"line_number":171,"context_line":"        id\u003d1,"},{"line_number":172,"context_line":"        host\u003dNone,  # prevent RT trying to lazy-load this"},{"line_number":173,"context_line":"        node\u003dNone,"},{"line_number":174,"context_line":"        uuid\u003d\u0027c17741a5-6f3d-44a8-ade8-773dc8c29124\u0027,"},{"line_number":175,"context_line":"        memory_mb\u003d128,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa81d914_99cdc789","line":172,"updated":"2015-01-27 20:39:45.000000000","message":"nit: I\u0027m not sure this comment is really useful, but that\u0027s OK","commit_id":"06bfaa30cee55f19d322df8ebe225ab4c175e611"}]}