)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"86b61db9ceeb640e8f3ccd00d11c74d54d151eb8","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"def _exec_ebtables(*cmd, **kwargs):"},{"line_number":1653,"context_line":"    check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, True)"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"    attempts \u003d CONF.ebtables_retry_attempts"},{"line_number":1656,"context_line":"    while attempts \u003e 0:"},{"line_number":1657,"context_line":"        attempts -\u003d 1"},{"line_number":1658,"context_line":"        # NOTE(cfb): ebtables reports all errors with a return code of 255."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_8ce0ad97","line":1655,"updated":"2014-11-21 12:28:20.000000000","message":"If someone stupidly configures retry_attempts to be 0, then this won\u0027t execute at all. Logging an error is probably warranted. We might also consider treating invalid values as being \"1\"... just because somebody is bound to misconfigure and go scratching their heads when things go sideways.","commit_id":"f1f184f0ab5a772fc91c11c2dbec92811cf27db0"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"a22dd7a251541ab49921eb55d9d57095feebc317","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"def _exec_ebtables(*cmd, **kwargs):"},{"line_number":1653,"context_line":"    check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, True)"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"    attempts \u003d CONF.ebtables_retry_attempts"},{"line_number":1656,"context_line":"    while attempts \u003e 0:"},{"line_number":1657,"context_line":"        attempts -\u003d 1"},{"line_number":1658,"context_line":"        # NOTE(cfb): ebtables reports all errors with a return code of 255."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a62c9c03","line":1655,"in_reply_to":"5a890539_8ce0ad97","updated":"2014-11-21 17:42:55.000000000","message":"No this is a bug. I will fix it.","commit_id":"f1f184f0ab5a772fc91c11c2dbec92811cf27db0"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"4accaa346e7313b2cb8a7fccc32aeb5f13f79c73","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, True)"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"    # We always try at least once"},{"line_number":1656,"context_line":"    attempts \u003d CONF.ebtables_retry_attempts + 1"},{"line_number":1657,"context_line":"    if attempts \u003c\u003d 0:"},{"line_number":1658,"context_line":"        attempts \u003d 1"},{"line_number":1659,"context_line":"    while attempts \u003e 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_ba1ae8c3","line":1656,"updated":"2014-11-22 00:36:23.000000000","message":"wait what? If i set ebtables_retry_attempts to 1, this will try twice. Did you leave this +1 in from a previous version?","commit_id":"8ceb57eb29ce75a0ca5f402d65ffd29b3ec203ed"}]}