)]}'
{"nova/volume/iscsi.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"6cc91c190556b56a1672cedc5f901532ef4f3cfa","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                       name,"},{"line_number":134,"context_line":"                                       run_as_root\u003dTrue)"},{"line_number":135,"context_line":"        except exception.ProcessExecutionError, e:"},{"line_number":136,"context_line":"            LOG.error(_(\"Failed to create iscsi target for volume \""},{"line_number":137,"context_line":"                        \"id:%(vol_id)s.\") % locals())"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            #Don\u0027t forget to remove the persistent file we created"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FSog%3D","side":"PARENT","line":136,"updated":"2012-09-25 15:45:46.000000000","message":"What if we added to the error message here to state explicitly that Nova/Cinder now require the external tgtd config settings to work correctly. Something like:\n\nPlease make sure your tgtd config file includes files from the configured Nova volume conf directory...","commit_id":"13a08f6ec7969c4ec6bd4b3bd816bb2a40f9896a"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"bb788a68775bb6709a7cc34d8720f4759105df10","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                       name,"},{"line_number":134,"context_line":"                                       run_as_root\u003dTrue)"},{"line_number":135,"context_line":"        except exception.ProcessExecutionError, e:"},{"line_number":136,"context_line":"            LOG.error(_(\"Failed to create iscsi target for volume \""},{"line_number":137,"context_line":"                        \"id:%(vol_id)s.\") % locals())"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            #Don\u0027t forget to remove the persistent file we created"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FSoI%3D","side":"PARENT","line":136,"in_reply_to":"AAAALH%2F%2FSog%3D","updated":"2012-09-25 15:50:55.000000000","message":"Are you sure you actually get an error here? AFAIR, when we were missing the include in targets.conf, we were only seeing timeouts connecting to the target","commit_id":"13a08f6ec7969c4ec6bd4b3bd816bb2a40f9896a"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e56b095eb4bdbbee04add91fdcabce1af38544d1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                       name,"},{"line_number":134,"context_line":"                                       run_as_root\u003dTrue)"},{"line_number":135,"context_line":"        except exception.ProcessExecutionError, e:"},{"line_number":136,"context_line":"            LOG.error(_(\"Failed to create iscsi target for volume \""},{"line_number":137,"context_line":"                        \"id:%(vol_id)s.\") % locals())"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            #Don\u0027t forget to remove the persistent file we created"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FSnM%3D","side":"PARENT","line":136,"in_reply_to":"AAAALH%2F%2FSog%3D","updated":"2012-09-25 15:55:07.000000000","message":"Good shout, done in the latest patch set.","commit_id":"13a08f6ec7969c4ec6bd4b3bd816bb2a40f9896a"}]}