)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"5d3af2002a17f4db8e4f036077a1d7d14048fe94","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"    # NOTE(cfb): dnsmasq on linux only supports 64 characters in the hostname"},{"line_number":1191,"context_line":"    #            field (LP #1238910). Since the . counts as a character we need"},{"line_number":1192,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1193,"context_line":"    hostname \u003d fixedip.instance.hostname[-63:]"},{"line_number":1194,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1195,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"},{"line_number":1196,"context_line":"        return \u0027%s,%s.%s,%s,net:%s\u0027 % (fixedip.virtual_interface.address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_eb7f40de","line":1193,"updated":"2014-11-22 13:35:36.000000000","message":"If the truncated string starts with an hyphen, I presume that dnsmasq will complain. The workaround for this bug in Heat has been to keep the first 2 characters of the original hostname, append an hyphen and then the last characters.","commit_id":"8bd0905405e36022ae8c5bcbb903257afd615a14"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"64aaa938782d1fd098fdd2e21934a4eb5f979f8b","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"    # NOTE(cfb): dnsmasq on linux only supports 64 characters in the hostname"},{"line_number":1191,"context_line":"    #            field (LP #1238910). Since the . counts as a character we need"},{"line_number":1192,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1193,"context_line":"    hostname \u003d fixedip.instance.hostname[-63:]"},{"line_number":1194,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1195,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"},{"line_number":1196,"context_line":"        return \u0027%s,%s.%s,%s,net:%s\u0027 % (fixedip.virtual_interface.address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_eea2edac","line":1193,"in_reply_to":"5a890539_eb7f40de","updated":"2014-11-23 02:59:17.000000000","message":"You make a valid point. I\u0027ll post a fix for this shortly.","commit_id":"8bd0905405e36022ae8c5bcbb903257afd615a14"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"f059e9f85ad35c688c1ef6d26d767cb3846b6179","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1193,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1194,"context_line":"    if len(hostname) \u003e 63:"},{"line_number":1195,"context_line":"        hostname \u003d fixedip.instance.hostname[:2] + \u0027-\u0027 +\\"},{"line_number":1196,"context_line":"                   fixedip.instance.hostname[-60:]"},{"line_number":1197,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1198,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_66c79d98","line":1195,"updated":"2014-12-04 22:59:22.000000000","message":"Do we need a LOG.warning() here?","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"05f8d72a2498ffea651ee23392b6128e7993bf60","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1193,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1194,"context_line":"    if len(hostname) \u003e 63:"},{"line_number":1195,"context_line":"        hostname \u003d fixedip.instance.hostname[:2] + \u0027-\u0027 +\\"},{"line_number":1196,"context_line":"                   fixedip.instance.hostname[-60:]"},{"line_number":1197,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1198,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e9c43e61","line":1195,"in_reply_to":"5a890539_66c79d98","updated":"2014-12-04 23:34:26.000000000","message":"Reasonable","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"f059e9f85ad35c688c1ef6d26d767cb3846b6179","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"def _host_dns(fixedip):"},{"line_number":1212,"context_line":"    return \u0027%s\\t%s.%s\u0027 % (fixedip.address,"},{"line_number":1213,"context_line":"                          fixedip.instance.hostname,"},{"line_number":1214,"context_line":"                          CONF.dhcp_domain)"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e6e38d31","line":1213,"updated":"2014-12-04 22:59:22.000000000","message":"Why don\u0027t we also want to truncate this?","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"05f8d72a2498ffea651ee23392b6128e7993bf60","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"def _host_dns(fixedip):"},{"line_number":1212,"context_line":"    return \u0027%s\\t%s.%s\u0027 % (fixedip.address,"},{"line_number":1213,"context_line":"                          fixedip.instance.hostname,"},{"line_number":1214,"context_line":"                          CONF.dhcp_domain)"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c9c9427a","line":1213,"in_reply_to":"5a890539_e6e38d31","updated":"2014-12-04 23:34:26.000000000","message":"DNS isn\u0027t actually limited to 63 characters. Only the DHCP file used by dnsmasq (which also does DNS for dnsmasq) is limited. _host_dns isn\u0027t used by dnsmasq so there is no need to limit its output. At least none we are aware of.","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"},{"author":{"_account_id":11531,"name":"warewang","email":"libra1588@126.com","username":"warewang"},"change_message_id":"2f7ebe1d3490e6e9517d674f89efbbe82300d336","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"def _host_dhcp(fixedip):"},{"line_number":1192,"context_line":"    \"\"\"Return a host string for an address in dhcp-host format.\"\"\""},{"line_number":1193,"context_line":"    # NOTE(cfb): dnsmasq on linux only supports 64 characters in the hostname"},{"line_number":1194,"context_line":"    #            field (LP #1238910). Since the . counts as a character we need"},{"line_number":1195,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1196,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1197,"context_line":"    if len(hostname) \u003e 63:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_350939dd","line":1194,"updated":"2014-12-05 02:37:50.000000000","message":"There is a  \u0027.\u0027 between \"Since the\" and \"counts\", why?","commit_id":"f58e1fd6c701132297c01af4eb239284ef4c2e7d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0adbf121ed87159fe0f401cc4b44ad0d1c265cf4","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"def _host_dhcp(fixedip):"},{"line_number":1192,"context_line":"    \"\"\"Return a host string for an address in dhcp-host format.\"\"\""},{"line_number":1193,"context_line":"    # NOTE(cfb): dnsmasq on linux only supports 64 characters in the hostname"},{"line_number":1194,"context_line":"    #            field (LP #1238910). Since the . counts as a character we need"},{"line_number":1195,"context_line":"    #            to truncate the hostname to only 63 characters."},{"line_number":1196,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1197,"context_line":"    if len(hostname) \u003e 63:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_f5d251fb","line":1194,"in_reply_to":"5a890539_350939dd","updated":"2014-12-05 02:52:06.000000000","message":"in DNS names you\u0027ll see hostname.domainname.  Chet is saying that the \u0027.\u0027 between the hostname and the domainname counts towards the number of characters (64) of the hostname portion.","commit_id":"f58e1fd6c701132297c01af4eb239284ef4c2e7d"},{"author":{"_account_id":11531,"name":"warewang","email":"libra1588@126.com","username":"warewang"},"change_message_id":"2f7ebe1d3490e6e9517d674f89efbbe82300d336","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1197,"context_line":"    if len(hostname) \u003e 63:"},{"line_number":1198,"context_line":"        LOG.warning(_LW(\u0027hostname %s too long, truncating.\u0027) % (hostname))"},{"line_number":1199,"context_line":"        hostname \u003d fixedip.instance.hostname[:2] + \u0027-\u0027 +\\"},{"line_number":1200,"context_line":"                   fixedip.instance.hostname[-60:]"},{"line_number":1201,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1202,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_f51171f8","line":1199,"updated":"2014-12-05 02:37:50.000000000","message":"You\u0027d better not use the \u0027\\\u0027to a newline.","commit_id":"f58e1fd6c701132297c01af4eb239284ef4c2e7d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"f8158d04e575f58c9a926c7737122d5de2c75dfd","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1197,"context_line":"    if len(hostname) \u003e 63:"},{"line_number":1198,"context_line":"        LOG.warning(_LW(\u0027hostname %s too long, truncating.\u0027) % (hostname))"},{"line_number":1199,"context_line":"        hostname \u003d fixedip.instance.hostname[:2] + \u0027-\u0027 +\\"},{"line_number":1200,"context_line":"                   fixedip.instance.hostname[-60:]"},{"line_number":1201,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1202,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_64477e7b","line":1199,"in_reply_to":"5a890539_b53a8931","updated":"2014-12-05 14:39:06.000000000","message":"if this gets respun we should change it. otherwise meh.","commit_id":"f58e1fd6c701132297c01af4eb239284ef4c2e7d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0adbf121ed87159fe0f401cc4b44ad0d1c265cf4","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    hostname \u003d fixedip.instance.hostname"},{"line_number":1197,"context_line":"    if len(hostname) \u003e 63:"},{"line_number":1198,"context_line":"        LOG.warning(_LW(\u0027hostname %s too long, truncating.\u0027) % (hostname))"},{"line_number":1199,"context_line":"        hostname \u003d fixedip.instance.hostname[:2] + \u0027-\u0027 +\\"},{"line_number":1200,"context_line":"                   fixedip.instance.hostname[-60:]"},{"line_number":1201,"context_line":"    if CONF.use_single_default_gateway:"},{"line_number":1202,"context_line":"        net \u003d _host_dhcp_network(fixedip.virtual_interface_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_b53a8931","line":1199,"in_reply_to":"5a890539_f51171f8","updated":"2014-12-05 02:52:06.000000000","message":"Yeah I menat to mention that before.  It\u0027s totally a style NIT but\n\n\nhostname \u003d (fixedip.instance.hostname[:2] + \u0027-\u0027 +\n                     fixedip.instance.hostname[-60:])\n\nMight be nicer.","commit_id":"f58e1fd6c701132297c01af4eb239284ef4c2e7d"}],"nova/tests/unit/network/test_linux_net.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"f059e9f85ad35c688c1ef6d26d767cb3846b6179","unresolved":false,"context_lines":[{"line_number":308,"context_line":"         \u0027address\u0027: \u0027DE:AD:BE:EF:00:07\u0027,"},{"line_number":309,"context_line":"         \u0027uuid\u0027: \u002700000000-0000-0000-0000-0000000000000007\u0027,"},{"line_number":310,"context_line":"         \u0027network_id\u0027: 2,"},{"line_number":311,"context_line":"         \u0027instance_uuid\u0027: \u002700000000-0000-0000-0000-0000000000000007\u0027}]"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"def get_associated(context, network_id, host\u003dNone, address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e651cdd9","line":311,"updated":"2014-12-04 22:59:22.000000000","message":"It\u0027s quite possible I have the instance_uuids mixed up but shouldn\u0027t that be: 00000000-0000-0000-0000-0000000000000002 ?","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"05f8d72a2498ffea651ee23392b6128e7993bf60","unresolved":false,"context_lines":[{"line_number":308,"context_line":"         \u0027address\u0027: \u0027DE:AD:BE:EF:00:07\u0027,"},{"line_number":309,"context_line":"         \u0027uuid\u0027: \u002700000000-0000-0000-0000-0000000000000007\u0027,"},{"line_number":310,"context_line":"         \u0027network_id\u0027: 2,"},{"line_number":311,"context_line":"         \u0027instance_uuid\u0027: \u002700000000-0000-0000-0000-0000000000000007\u0027}]"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"def get_associated(context, network_id, host\u003dNone, address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_09c0aa48","line":311,"in_reply_to":"5a890539_e651cdd9","updated":"2014-12-04 23:34:26.000000000","message":"Yup. Type-o","commit_id":"87cc22dcdeaeb6415dfc120c0329724eef81dd2c"}]}