)]}'
{"nova/api/openstack/compute/contrib/flavormanage.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"7512a8d13d9761da3248642ddf7cfac7b787daf6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            req.cache_db_flavor(flavor)"},{"line_number":76,"context_line":"        except exception.InstanceTypeExists as err:"},{"line_number":77,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dstr(err))"},{"line_number":78,"context_line":"        except exception.InstanceTypeIdExists as err:"},{"line_number":79,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dstr(err))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return self._view_builder.show(req, flavor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FRO8%3D","line":78,"updated":"2012-09-27 12:29:14.000000000","message":"I think you can merge those two with :\n\nexcept (exception.InstanceTypeExists, exception.InstanceTypeIdExists) as err:","commit_id":"26a8cc9efee32bd09800774182440cd180512fac"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"12e31ca7a76b767407117bb6a85de476e688aaae","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                           swap, rxtx_factor, is_public)"},{"line_number":75,"context_line":"            req.cache_db_flavor(flavor)"},{"line_number":76,"context_line":"        except (exception.InstanceTypeExists,"},{"line_number":77,"context_line":"                exception.InstanceTypeIdExists) as err:"},{"line_number":78,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dstr(err))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self._view_builder.show(req, flavor)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FRF4%3D","line":77,"updated":"2012-09-27 15:09:01.000000000","message":"If you need to push up a new version for whatever reason, it might just be simpler to catch exception.Duplicate instead","commit_id":"3db7a943bebbda5fea07fc80813cabc436fb892b"}],"nova/tests/test_instance_types.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"7512a8d13d9761da3248642ddf7cfac7b787daf6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        \"\"\"Ensures that flavorid duplicates raise InstanceTypeCreateFailed\"\"\""},{"line_number":160,"context_line":"        flavorid \u003d \u0027flavor1\u0027"},{"line_number":161,"context_line":"        instance_types.create(\u0027name one\u0027, 256, 1, 120, 200, flavorid)"},{"line_number":162,"context_line":"        self.assertRaises(exception.InstanceTypeIdExists,"},{"line_number":163,"context_line":"                          instance_types.create,"},{"line_number":164,"context_line":"                          \u0027name two\u0027, 256, 1, 120, 200, flavorid)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FROw%3D","line":162,"updated":"2012-09-27 12:29:14.000000000","message":"I don\u0027t have the full context of the code but I guess the InstanceTypeExists exception is not tested anymore.","commit_id":"26a8cc9efee32bd09800774182440cd180512fac"}]}