)]}'
{"nova/api/openstack/compute/plugins/v3/volumes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ea4a7bf07e0d1089bf48c1386bb76243e1a0781","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    @wsgi.response(202)"},{"line_number":312,"context_line":"    @extensions.expected_errors((400, 404, 409))"},{"line_number":313,"context_line":"    @validation.schema(volumes_schema.volume_attachment)"},{"line_number":314,"context_line":"    def update(self, req, server_id, id, body):"},{"line_number":315,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":316,"context_line":"        authorize(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_04631ade","line":313,"updated":"2014-11-27 05:43:36.000000000","message":"this schema allows \"device\" attribute, but this API method should not do it because the API doesn\u0027t use the attribute.\nSo we need to separate API schema from create() method.","commit_id":"fa95889cd235be40a89a693fa38796609c6000c0"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a7c03197a4b847af76d4440085a1b12a7af74484","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    @wsgi.response(202)"},{"line_number":312,"context_line":"    @extensions.expected_errors((400, 404, 409))"},{"line_number":313,"context_line":"    @validation.schema(volumes_schema.volume_attachment)"},{"line_number":314,"context_line":"    def update(self, req, server_id, id, body):"},{"line_number":315,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":316,"context_line":"        authorize(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_e451ae64","line":313,"in_reply_to":"5a890539_04631ade","updated":"2014-11-27 06:17:14.000000000","message":"agreed.","commit_id":"fa95889cd235be40a89a693fa38796609c6000c0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ae4ef3f5684f79a363ecf26c40422f489619684","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    @wsgi.response(202)"},{"line_number":312,"context_line":"    @extensions.expected_errors((400, 404, 409))"},{"line_number":313,"context_line":"    @validation.schema(volumes_schema.volume_attachment)"},{"line_number":314,"context_line":"    def update(self, req, server_id, id, body):"},{"line_number":315,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":316,"context_line":"        authorize(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_aa15ad4a","line":313,"in_reply_to":"5a890539_e451ae64","updated":"2014-11-27 08:18:05.000000000","message":"Yes, Nice catch. Done. I have added/modified tests also.","commit_id":"fa95889cd235be40a89a693fa38796609c6000c0"}],"nova/tests/unit/api/openstack/compute/contrib/test_volumes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fc884bd3928480d75d843b279eab96399a6999cb","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        # so volume is swapped successfully even with extra arg in"},{"line_number":668,"context_line":"        # request body."},{"line_number":669,"context_line":"        result \u003d self._test_swap(self.attachments)"},{"line_number":670,"context_line":"        self.assertEqual(202, result.status_int)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"class VolumeSerializerTest(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_a5aa24d0","line":670,"updated":"2014-11-28 09:58:04.000000000","message":"How about\n\n pass\n\ninstead of line 669-670 ?\n\nI concern current code would mislead that 202 is right, maybe the additional NOTE will avoid that. but pass is better I feel.","commit_id":"a404b985365cea605d80ec9cb991a1ebd09d9928"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6cfd5e7cf796f3946756a6ef6b0ecc70acd9935b","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        # so volume is swapped successfully even with extra arg in"},{"line_number":668,"context_line":"        # request body."},{"line_number":669,"context_line":"        result \u003d self._test_swap(self.attachments)"},{"line_number":670,"context_line":"        self.assertEqual(202, result.status_int)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"class VolumeSerializerTest(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_8706f583","line":670,"in_reply_to":"5a890539_a5aa24d0","updated":"2014-12-01 01:22:41.000000000","message":"Nice idea. Done","commit_id":"a404b985365cea605d80ec9cb991a1ebd09d9928"}]}