)]}'
{"nova/tests/test_libvirt.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f5162954da5086db71fb7b13a896e7e0cfb1bc42","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        image_service \u003d nova.tests.image.fake.FakeImageService()"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"        libvirt_types \u003d [\u0027lxc\u0027, \u0027kvm\u0027]"},{"line_number":1114,"context_line":"        for test_libvirt_type in libvirt_types:"},{"line_number":1115,"context_line":"            self.flags(libvirt_type\u003dtest_libvirt_type)"},{"line_number":1116,"context_line":"            # Assign different image_ref from nova/images/fakes for testing ami"},{"line_number":1117,"context_line":"            test_instance \u003d copy.deepcopy(self.test_instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FKqM%3D","line":1114,"updated":"2012-10-09 21:21:02.000000000","message":"Nitpicking: I\u0027d prefer that these tests be split out for each libvirt type; if one of the tests begins failing, that would help us figure out exactly which variant it is.","commit_id":"91a410f183a3a4a0411cef95473c0dc2ba389eaf"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"f240a4fbe2fb257aec55e5883d8f9b1461b1001f","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        (state, _max_mem, _mem, _cpus, _t) \u003d virt_dom.info()"},{"line_number":831,"context_line":"        state \u003d LIBVIRT_POWER_STATE[state]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        if FLAGS.libvirt_type !\u003d \u0027lxc\u0027:"},{"line_number":834,"context_line":"            if state \u003d\u003d power_state.RUNNING:"},{"line_number":835,"context_line":"                virt_dom.managedSave(0)"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Ff0%3D","line":833,"updated":"2012-10-22 21:19:44.000000000","message":"This might be worth a NOTE() explaining why we need to guard against LXC here. I can see this being a bit of a head-scratcher down the road for someone new to the code-base.","commit_id":"ab23bc925e0314193ce41e0d8a873dd5583d647b"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"f240a4fbe2fb257aec55e5883d8f9b1461b1001f","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    May be file or device\"\"\""},{"line_number":418,"context_line":"    xml_desc \u003d virt_dom.XMLDesc(0)"},{"line_number":419,"context_line":"    domain \u003d etree.fromstring(xml_desc)"},{"line_number":420,"context_line":"    if FLAGS.libvirt_type !\u003d \u0027lxc\u0027:"},{"line_number":421,"context_line":"        source \u003d domain.find(\u0027devices/disk/source\u0027)"},{"line_number":422,"context_line":"        disk_path \u003d source.get(\u0027file\u0027) or source.get(\u0027dev\u0027)"},{"line_number":423,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Ff8%3D","line":420,"updated":"2012-10-22 21:19:44.000000000","message":"This if/else forms a double-negative, might be easier to read as:\n\nif FLAGS.libvirt_type \u003d\u003d \u0027lxc\u0027:\n  something\nelse\n  something else","commit_id":"ab23bc925e0314193ce41e0d8a873dd5583d647b"}]}