)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"537d6278e86380ae4ae1edd04a974a74d152618d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    except (TypeError, AttributeError, ValueError):"},{"line_number":82,"context_line":"        raise exception.InvalidDevicePath(path\u003dmappings[\u0027root\u0027])"},{"line_number":83,"context_line":"    # NOTE(vish): remove this when xenapi is setting default_root_device"},{"line_number":84,"context_line":"    if (FLAGS.compute_driver.endswith(\u0027xenapi.XenAPIDriver\u0027)):"},{"line_number":85,"context_line":"        prefix \u003d \u0027/dev/xvd\u0027"},{"line_number":86,"context_line":"    if req_prefix !\u003d prefix:"},{"line_number":87,"context_line":"        LOG.debug(_(\"Using %(prefix)s instead of %(req_prefix)s\") % locals())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPJY%3D","line":84,"updated":"2012-10-01 18:12:40.000000000","message":"femtonit: The surrounding parentheses can now be dropped…","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"537d6278e86380ae4ae1edd04a974a74d152618d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # NOTE(vish): remove this when xenapi is properly setting"},{"line_number":98,"context_line":"    #             default_ephemeral_device and default_swap_device"},{"line_number":99,"context_line":"    if (FLAGS.compute_driver.endswith(\u0027xenapi.XenAPIDriver\u0027)):"},{"line_number":100,"context_line":"        instance_type_id \u003d instance[\u0027instance_type_id\u0027]"},{"line_number":101,"context_line":"        instance_type \u003d instance_types.get_instance_type(instance_type_id)"},{"line_number":102,"context_line":"        if instance_type[\u0027ephemeral_gb\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPJU%3D","line":99,"updated":"2012-10-01 18:12:40.000000000","message":"Same femtonit","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"}],"nova/db/sqlalchemy/migrate_repo/versions/082_essex.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"bdda4e6087e0b74455303b96ab14b5212a701936","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# of integral type, so is no longer set explicitly in such cases."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _populate_instance_types(instance_types_table):"},{"line_number":33,"context_line":"    if FLAGS.compute_driver.endswith(\"LibvirtDriver\"):"},{"line_number":34,"context_line":"        default_inst_types \u003d {"},{"line_number":35,"context_line":"        \u0027m1.tiny\u0027: dict(mem\u003d512, vcpus\u003d1, root_gb\u003d0, eph_gb\u003d0, flavid\u003d1),"},{"line_number":36,"context_line":"        \u0027m1.small\u0027: dict(mem\u003d2048, vcpus\u003d1, root_gb\u003d10, eph_gb\u003d20, flavid\u003d2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPHk%3D","line":33,"updated":"2012-10-01 18:25:30.000000000","message":"I don\u0027t think i like this. Only because we shipped folsom with different behavior. I think I would prefer using the xen types by default all the time from now on.","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"9436dc78f819fc7ff83978f9382f460874e67d49","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# of integral type, so is no longer set explicitly in such cases."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _populate_instance_types(instance_types_table):"},{"line_number":33,"context_line":"    if FLAGS.compute_driver.endswith(\"LibvirtDriver\"):"},{"line_number":34,"context_line":"        default_inst_types \u003d {"},{"line_number":35,"context_line":"        \u0027m1.tiny\u0027: dict(mem\u003d512, vcpus\u003d1, root_gb\u003d0, eph_gb\u003d0, flavid\u003d1),"},{"line_number":36,"context_line":"        \u0027m1.small\u0027: dict(mem\u003d2048, vcpus\u003d1, root_gb\u003d10, eph_gb\u003d20, flavid\u003d2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPHI%3D","line":33,"in_reply_to":"AAAALH%2F%2FPHQ%3D","updated":"2012-10-01 18:32:20.000000000","message":"yes, if you do not use connection_type in folsom (which is the recommended configuration according to release notes and devstack), you end up with the second set of types. I think this is preferrable as this block was only in so that it didn\u0027t break existing installs. But existing installs should have migrated past this a long time ago, so it doesn\u0027t really affect them any more. New installs should default to the second set and and we should forget the first set ever existed.\n\nNote the second-to-last point in upgrade notes here:\n\nhttp://wiki.openstack.org/ReleaseNotes/Folsom#OpenStack_Compute_.28Nova.29\n\nTherefore I suggest that we just remove the flag and the first block altogether and just set it to the second set.","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"48280c6ca29e967f983d4fd18b8fb59e841fc485","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# of integral type, so is no longer set explicitly in such cases."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _populate_instance_types(instance_types_table):"},{"line_number":33,"context_line":"    if FLAGS.compute_driver.endswith(\"LibvirtDriver\"):"},{"line_number":34,"context_line":"        default_inst_types \u003d {"},{"line_number":35,"context_line":"        \u0027m1.tiny\u0027: dict(mem\u003d512, vcpus\u003d1, root_gb\u003d0, eph_gb\u003d0, flavid\u003d1),"},{"line_number":36,"context_line":"        \u0027m1.small\u0027: dict(mem\u003d2048, vcpus\u003d1, root_gb\u003d10, eph_gb\u003d20, flavid\u003d2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPHQ%3D","line":33,"in_reply_to":"AAAALH%2F%2FPHk%3D","updated":"2012-10-01 18:27:05.000000000","message":"By \u0027different behavior\u0027, do you mean that this if statement wasn\u0027t reliable because there were two different ways to configure the driver?","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"}],"nova/volume/xensm.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"537d6278e86380ae4ae1edd04a974a74d152618d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # hypervisor to be Xen"},{"line_number":101,"context_line":"        if not FLAGS.compute_driver.endswith(\u0027XenAPIDriver\u0027):"},{"line_number":102,"context_line":"            msg \u003d _(\u0027XenSMDriver requires xenapi connection, using %s\u0027) % \\"},{"line_number":103,"context_line":"                    FLAGS.compute_driver"},{"line_number":104,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        url \u003d FLAGS.xenapi_connection_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FPJM%3D","line":103,"updated":"2012-10-01 18:12:40.000000000","message":"femtonit: Could use parentheses here to avoid using the \\ continuation…","commit_id":"ceb847686064d3761b4f0816eec2cade1d69a7dd"}]}