)]}'
{"nova/virt/libvirt/firewall.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e4de5d5d3bfcf3e1b7945104da998542b53ab37d","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if self.static_filters_configured:"},{"line_number":136,"context_line":"            return"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        filter_set_base \u003d [\u0027no-mac-spoofing\u0027,"},{"line_number":139,"context_line":"                           \u0027no-ip-spoofing\u0027,"},{"line_number":140,"context_line":"                           \u0027no-arp-spoofing\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNUc%3D","line":137,"updated":"2012-10-04 20:19:08.000000000","message":"As long as you are refactoring this why not combine the list definitions so you build nodhcp, add the ipv6 if it is needed, then create the base list by just adding in the one additional rule.","commit_id":"9465ac994ccabed56fe1b599be789e53f9c6c60d"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"f534cc8bc0734073b2f0b306cf5eacbd75f88f89","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        Detection(DAD)."},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        return \u0027\u0027\u0027\u003cfilter name\u003d\u0027nova-no-nd-reflection\u0027 chain\u003d\u0027ipv6\u0027\u003e"},{"line_number":67,"context_line":"                  \u003crule action\u003d\u0027drop\u0027 direction\u003d\u0027in\u0027\u003e"},{"line_number":68,"context_line":"                      \u003cmac dstmacaddr\u003d\u002733:33:00:00:00:00\u0027"},{"line_number":69,"context_line":"                           dstmacmask\u003d\u0027ff:ff:00:00:00:00\u0027 srcmacaddr\u003d\u0027$MAC\u0027/\u003e"},{"line_number":70,"context_line":"                  \u003c/rule\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FMjg%3D","line":67,"updated":"2012-10-05 21:34:21.000000000","message":"I\u0027d prefer to have the comment \"drop if destination mac is v6 mcast mac addr and we sent it.\" in either the xml comment or in the code somewhere to make it clearer..","commit_id":"a8c511b753a8b5ac7b9254716ecee650c9abcd7d"}]}