)]}'
{"nova/tests/unit/virt/vmwareapi/test_vmops.py":[{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"6defed8d0fbc8e2189c68fccd38de017b72cbbc9","unresolved":false,"context_lines":[{"line_number":1668,"context_line":"        extra_specs \u003d self._vmops._get_extra_specs(flavor)"},{"line_number":1669,"context_line":"        self.assertEqual(\u0027flavor-policy\u0027, extra_specs.storage_policy)"},{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"    def test_get_iinstance_metadata(self):"},{"line_number":1672,"context_line":"        flavor \u003d objects.Flavor(id\u003d7,"},{"line_number":1673,"context_line":"                                name\u003d\u0027m1.small\u0027,"},{"line_number":1674,"context_line":"                                memory_mb\u003d6,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_257bdcbe","line":1671,"updated":"2015-02-06 13:15:58.000000000","message":"Typo here, extra i in instance :)","commit_id":"2e829a234040e654088429107bffc6601d23cf4c"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e9d10391bd2e1f2ad0281fd252ee30c0c4c69712","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                              flavor.id,"},{"line_number":266,"context_line":"                              flavor.name,"},{"line_number":267,"context_line":"                              instance.image_ref,"},{"line_number":268,"context_line":"                              instance.availability_zone)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def build_virtual_machine(self, instance, instance_name, image_info,"},{"line_number":271,"context_line":"                              dc_info, datastore, network_info, extra_specs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_0b76993f","line":268,"updated":"2015-02-16 12:06:01.000000000","message":"I think it would be desirable to have the same set of data items reported for each virt driver.  This is reporting flavourid and az fields that libvirt does not include. If we think those are useful, we probably want to add them to the libvirt data too. On the other hand it is missing flavour memory mb, vcpus, ephemeral gb, root gb \u0026 swap, and the nova version string and the instance creation time.\n\nIME so far the nova version string in particular has been very useful in diagnosing problems, because it lets us see if a VM was booted with an older version of nova than is currently runing the cloud","commit_id":"c423d7f5ae3635e2d4bd8f9413f881c0259739be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"60b60fb82d466de22671f9f387c949dc1f2e8302","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                              flavor.id,"},{"line_number":266,"context_line":"                              flavor.name,"},{"line_number":267,"context_line":"                              instance.image_ref,"},{"line_number":268,"context_line":"                              instance.availability_zone)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def build_virtual_machine(self, instance, instance_name, image_info,"},{"line_number":271,"context_line":"                              dc_info, datastore, network_info, extra_specs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_f7c0e74b","line":268,"in_reply_to":"da86d52c_0b76993f","updated":"2015-02-18 16:15:08.000000000","message":"I have added them all. The VC already has the created time so I am going to skip that one.\nIf an when this ever lands then I will update the libvirt driver and this one to have the flavorid and az","commit_id":"c423d7f5ae3635e2d4bd8f9413f881c0259739be"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"973e8fc714ca097e1246ada4c9a408c522c768e3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                              flavor.id,"},{"line_number":266,"context_line":"                              flavor.name,"},{"line_number":267,"context_line":"                              instance.image_ref,"},{"line_number":268,"context_line":"                              instance.availability_zone)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def build_virtual_machine(self, instance, instance_name, image_info,"},{"line_number":271,"context_line":"                              dc_info, datastore, network_info, extra_specs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_f2c39555","line":268,"in_reply_to":"da86d52c_f7c0e74b","updated":"2015-02-18 16:18:50.000000000","message":"Ok, makes sense.","commit_id":"c423d7f5ae3635e2d4bd8f9413f881c0259739be"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"57ccb0bfeaf699c3a8c3172ff98a48655bc63ead","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                                   flavor.root_gb,"},{"line_number":270,"context_line":"                                   flavor.swap,"},{"line_number":271,"context_line":"                                   instance.image_ref,"},{"line_number":272,"context_line":"                                   version.version_string_with_package())"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def build_virtual_machine(self, instance, image_info,"},{"line_number":275,"context_line":"                              dc_info, datastore, network_info, extra_specs,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a016987_51323ca8","line":272,"updated":"2015-05-29 18:39:24.000000000","message":"Hmm. Interesting, and I could see how this would be quite useful to administrators as they push out rolling upgrades. Very nice.","commit_id":"2c45a4f59bb26a0f1fada62306deafbca242565a"}]}