)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d61e6c03f41174c718722441b5592bd25e8c3d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     li zheming \u003clizheming.li@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-15 14:42:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for instance Mem consumption control"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt has supportted memtune, by setting hard_limit,"},{"line_number":10,"context_line":"soft_limit, swap_hard_limit through nova flavor-set with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_4488b2c6","line":7,"updated":"2014-12-16 16:06:24.000000000","message":"please prefix this with libvirt","commit_id":"f22053927030fabd195646df543bed264d8eb8ca"},{"author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"change_message_id":"41d58bccf09a490de3779fcaea8f427c3f8e7f3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     li zheming \u003clizheming.li@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-15 14:42:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for instance Mem consumption control"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt has supportted memtune, by setting hard_limit,"},{"line_number":10,"context_line":"soft_limit, swap_hard_limit through nova flavor-set with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_09a6b0c1","line":7,"in_reply_to":"3a961159_4488b2c6","updated":"2014-12-17 09:13:53.000000000","message":"ok. thanks","commit_id":"f22053927030fabd195646df543bed264d8eb8ca"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d61e6c03f41174c718722441b5592bd25e8c3d5","unresolved":false,"context_lines":[{"line_number":3780,"context_line":"                setattr(guest.cputune, name,"},{"line_number":3781,"context_line":"                        int(flavor.extra_specs[key]))"},{"line_number":3782,"context_line":""},{"line_number":3783,"context_line":"        memtuning \u003d [\u0027hard_limit\u0027, \u0027soft_limit\u0027, \u0027swap_hard_limit\u0027]"},{"line_number":3784,"context_line":"        for name in memtuning:"},{"line_number":3785,"context_line":"            key \u003d \"quota:mem_\" + name"},{"line_number":3786,"context_line":"            if key in flavor.extra_specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e41c3e7a","line":3783,"updated":"2014-12-16 16:06:24.000000000","message":"what about min_guarantee?","commit_id":"f22053927030fabd195646df543bed264d8eb8ca"},{"author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"change_message_id":"41d58bccf09a490de3779fcaea8f427c3f8e7f3e","unresolved":false,"context_lines":[{"line_number":3780,"context_line":"                setattr(guest.cputune, name,"},{"line_number":3781,"context_line":"                        int(flavor.extra_specs[key]))"},{"line_number":3782,"context_line":""},{"line_number":3783,"context_line":"        memtuning \u003d [\u0027hard_limit\u0027, \u0027soft_limit\u0027, \u0027swap_hard_limit\u0027]"},{"line_number":3784,"context_line":"        for name in memtuning:"},{"line_number":3785,"context_line":"            key \u003d \"quota:mem_\" + name"},{"line_number":3786,"context_line":"            if key in flavor.extra_specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_07777003","line":3783,"in_reply_to":"3a961159_e41c3e7a","updated":"2014-12-17 09:13:53.000000000","message":"kvm not support  min_guarantee, so I don\u0027t add it.","commit_id":"f22053927030fabd195646df543bed264d8eb8ca"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d5faf8b161ba1890624277e39c9947a3bae73395","unresolved":false,"context_lines":[{"line_number":3787,"context_line":"                if guest.memtune is None:"},{"line_number":3788,"context_line":"                    guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":3789,"context_line":"                setattr(guest.memtune, name,"},{"line_number":3790,"context_line":"                        int(flavor.extra_specs[key]))"},{"line_number":3791,"context_line":""},{"line_number":3792,"context_line":"        guest.cpu \u003d self._get_guest_cpu_config("},{"line_number":3793,"context_line":"                flavor, image_meta, guest_cpu_numa)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_164787a4","line":3790,"updated":"2015-01-13 15:42:24.000000000","message":"A long while back libvirt would automatically set a hard limit for all guests, but we got a never ending stream of bug reports about guests being killed for OOM. It turns out that it is pretty much impossible to determine what the acceptable upper limit on memory usage of KVM is, which makes it damn hard to figure out suitable limits. \n\nThat\u0027s not to say we shouldn\u0027t support this, but I\u0027m wary of enabling it because I just know anyone who sets these limits is going to hit the same problems, resulting in a never ending bug report stream :-(","commit_id":"f22053927030fabd195646df543bed264d8eb8ca"}]}
