)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3ad0644d10ae9fb9b0eb0d3faaf319201ec6ad08","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                  failed."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        if self.disabled:"},{"line_number":156,"context_line":"            instance_ref \u003d self._set_instance_host(context,"},{"line_number":157,"context_line":"                                                   instance_ref[\u0027uuid\u0027])"},{"line_number":158,"context_line":"            return"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLrk%3D","line":156,"updated":"2012-10-08 18:52:18.000000000","message":"What does self.disabled mean?  A comment here explaining why we want to _set_instance_host() would be good.","commit_id":"030de46e39d8978d95a1f5290ddc5e5e4c240fa6"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"e0cd94e085c603f2a226271b3b6fe9995fd11c1e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                  failed."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        if self.disabled:"},{"line_number":156,"context_line":"            instance_ref \u003d self._set_instance_host(context,"},{"line_number":157,"context_line":"                                                   instance_ref[\u0027uuid\u0027])"},{"line_number":158,"context_line":"            return"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLrc%3D","line":156,"in_reply_to":"AAAALH%2F%2FLrk%3D","updated":"2012-10-08 18:55:18.000000000","message":"The disabled flag gets set when the compute_driver doesn\u0027t support the type of resource polling needed to run the resource tracker.  In that case, it\u0027s just support to no-op and let the build go through without any checking.  \n\nI\u0027ll add a comment.","commit_id":"030de46e39d8978d95a1f5290ddc5e5e4c240fa6"}],"nova/tests/compute/test_resource_tracker.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"7d3b3b980592532c24f14675247b1a5ae9e51313","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            values):"},{"line_number":141,"context_line":"        instance \u003d self._instances[instance_uuid]"},{"line_number":142,"context_line":"        instance.update(values)"},{"line_number":143,"context_line":"        return (instance, instance)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _tracker(self, unsupported\u003dFalse):"},{"line_number":146,"context_line":"        host \u003d \"fakehost\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLn4%3D","line":143,"updated":"2012-10-08 19:57:27.000000000","message":"This doesn\u0027t really return the original. Maybe copy the dict before updating it?\n\nOr if you\u0027re sure it\u0027s fine, can you add a comment explaining why?","commit_id":"7076c71be791a32515e7a3de302f7cdf38108bc8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"1d55122163cc862b8b1bbbef2a11739583e08e9f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            values):"},{"line_number":141,"context_line":"        instance \u003d self._instances[instance_uuid]"},{"line_number":142,"context_line":"        instance.update(values)"},{"line_number":143,"context_line":"        return (instance, instance)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _tracker(self, unsupported\u003dFalse):"},{"line_number":146,"context_line":"        host \u003d \"fakehost\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLnY%3D","line":143,"in_reply_to":"AAAALH%2F%2FLn4%3D","updated":"2012-10-08 20:14:02.000000000","message":"I\u0027ll comment it, essentially the test case doesn\u0027t care what the \"old\" value is.  The \"old\" value is only consumed by the notifications code...","commit_id":"7076c71be791a32515e7a3de302f7cdf38108bc8"}]}