)]}'
{"id":"openstack%2Fnova~14179","triplet_id":"openstack%2Fnova~master~I5cb0dd8903d358272ec223cf73f6eb4c06371a96","project":"openstack/nova","branch":"master","topic":"resource_tracker_drop_claims","hashtags":[],"change_id":"I5cb0dd8903d358272ec223cf73f6eb4c06371a96","subject":"Drop claim timeouts from resource tracker","status":"MERGED","created":"2012-10-08 19:43:04.000000000","updated":"2012-10-09 20:23:17.000000000","submitted":"2012-10-09 20:23:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9391f30224b4a1ab784a475c521b6742df9cde8f","_number":14179,"virtual_id_number":14179,"owner":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":1,"date":"2012-10-08 20:10:12.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":2,"date":"2012-10-09 20:23:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"recommended":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"all":[{"value":1,"date":"2012-10-08 19:50:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":2,"date":"2012-10-09 20:01:20.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-10-09 16:04:13.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-10-08 21:23:42.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"date":"2012-10-08 20:06:50.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":1,"date":"2012-10-09 20:01:20.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-10-09 16:04:13.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-10-08 21:23:42.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-08 19:50:17.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2012-10-08 20:10:12.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-10-08 21:23:42.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2012-10-09 16:04:13.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-10-09 20:01:20.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-10-09 20:23:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dad11dabe815c435ed33c732b7c697c2576275c1","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2012-10-08 19:50:17.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"8018b7718a1369411b3667f8d42730418dbe1598","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-10-08 19:59:19.000000000","message":"Patch Set 1:\n\nShouldn\u0027t there still be a minimum time then?\n\nIf for instance, a claim is acquired and then the periodic task runs immediately after that, wouldn\u0027t it clear out that claim?","accounts_in_message":[],"_revision_number":1},{"id":"96c67086e080a163605d75eaf8a1ce0fb0a990c9","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2012-10-08 20:06:50.000000000","message":"Patch Set 1:\n\nGreat question...The \u0027host\u0027 field must be set on the instance before begin_resource_claim() finishes so that the audit process can freely run immediately after and not clobber the usage values.  Once that \u0027host\u0027 field is set, the audit process will properly include the instance in its calculations when it grabs all the instances via instance_get_all_by_host().  Claims just need to be held until the audit runs.\n\nOnce this one goes in: https://review.openstack.org/#/c/14174/ it will perform correctly.  (This review is kinda dependent on that one, although they can merge separately because 14174 fixes a bug where the \u0027host\u0027 field was getting set inside scheduler anyway.)","accounts_in_message":[],"_revision_number":1},{"id":"5844694e4c34c48e13b91aa908eafcc7787343e1","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-08 20:10:12.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/38766\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/38764\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/38765\n","accounts_in_message":[],"_revision_number":1},{"id":"23017471bdf996db2258eb94c8b56053defa5f1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-08 20:17:19.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/14179/1/check/gate-nova-merge/9812 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-docs/5567 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-pep8/10877 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-python26/7022 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-python27/7087 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-tempest-devstack-vm/13953 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-tempest-devstack-vm-cinder/3932 : FAILURE\n- http://logs.openstack.org/14179/1/check/gate-nova-pylint/1489 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"6dab1d12c3bcbc7478e4dad3d82bdb85ef412e86","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2012-10-08 21:23:42.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nLooks reasonable to me. Need to see what\u0027s up with Jenkins, though","accounts_in_message":[],"_revision_number":1},{"id":"414a1d0493ff7043ef8e9590139254f57af4e7f5","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2012-10-09 12:36:19.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0e61cd22559a6a06007acdb8087310f54ab90152","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-09 12:58:21.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14179/1/check/gate-nova-merge/9837 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-docs/5592 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-pep8/10902 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-python26/7047 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-python27/7112 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-tempest-devstack-vm/14024 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-tempest-devstack-vm-cinder/4003 : SUCCESS\n- http://logs.openstack.org/14179/1/check/gate-nova-pylint/1510 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"9eccc58eee5daa3184c89521825663db42605855","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-10-09 16:04:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a8b358308e0c8985c3b9b87c097e958b7e93bbf2","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-10-09 20:01:20.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ff94081e3ecd167f67a1022ed5da449c9766a5e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-09 20:01:28.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"e020bc4f6ca3e9fb0a960f3bb46b7be3eca7ed2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-09 20:23:16.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14179/1/gate/gate-nova-merge/9846 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-nova-docs/5601 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-nova-pep8/10911 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-nova-python26/7056 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-nova-python27/7121 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-tempest-devstack-vm/14053 : SUCCESS\n- http://logs.openstack.org/14179/1/gate/gate-tempest-devstack-vm-cinder/4032 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"e98c32152c80b85cf9290f2c1e0fc8c2bf065cd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-09 20:23:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4ddf638767ffc34fe521eb0692267d235dbf32ea","revisions":{"4ddf638767ffc34fe521eb0692267d235dbf32ea":{"kind":"REWORK","_number":1,"created":"2012-10-08 19:43:04.000000000","uploader":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"ref":"refs/changes/79/14179/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/14179/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/14179/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/14179/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/14179/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/14179/1"}}},"commit":{"parents":[{"commit":"9d4ecc2c553b85f2fccf444498df15b09b6fe54b","subject":"Merge \"Num instances scheduler filter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9d4ecc2c553b85f2fccf444498df15b09b6fe54b"}]}],"author":{"name":"Brian Elliott","email":"brian.elliott@rackspace.com","date":"2012-10-08 19:22:02.000000000","tz":0},"committer":{"name":"Brian Elliott","email":"brian.elliott@rackspace.com","date":"2012-10-08 19:42:35.000000000","tz":0},"subject":"Drop claim timeouts from resource tracker","message":"Drop claim timeouts from resource tracker\n\nRemoved the claim timeouts.  The timeouts are basically irrelevant\nsince the re-work done here: https://review.openstack.org/#/c/13182/\n\nEach claim is a marker of an operation consuming resources, valid\nuntil the next invocation of the audit process\nupdate_available_resource(), which does a full reconciliation of all\nresource usage values from the DB.\n\nChange-Id: I5cb0dd8903d358272ec223cf73f6eb4c06371a96\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4ddf638767ffc34fe521eb0692267d235dbf32ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4ddf638767ffc34fe521eb0692267d235dbf32ea"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9d4ecc2c553b85f2fccf444498df15b09b6fe54b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}