)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5be62a95b12d363968df53e569723fdb3054193c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remote console controllers (both V2 \u0026 V2.1), does not catch"},{"line_number":10,"context_line":"all the expected exceptions which results to raise HTTPInternalServerError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch catch all the expected exceptions in those controllers."},{"line_number":13,"context_line":"Also share serial_console tests among V2 \u0026 V2.1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iea706eb45b0f2f6cdfd7e8d6061cad03ab43c6ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_b8f6eed6","line":12,"updated":"2014-12-26 05:19:37.000000000","message":"s/catch/catches/","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"}],"nova/api/openstack/compute/contrib/consoles.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eb8f03040a1f75ddb65dff718d875085d64e6dbd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":49,"context_line":"            raise webob.exc.HTTPConflict("},{"line_number":50,"context_line":"                    explanation\u003d_(\u0027Instance not yet ready\u0027))"},{"line_number":51,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":52,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":53,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":54,"context_line":"                exception.ConsoleTypeInvalid) as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a472360f","line":51,"updated":"2014-12-29 08:55:51.000000000","message":"would this not be raised on line 41?","commit_id":"dec4ad9b4bd7fab656d65e9481b51b6e6d4967d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ac35f62805ded272f5743b96e57988a42ead50b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":49,"context_line":"            raise webob.exc.HTTPConflict("},{"line_number":50,"context_line":"                    explanation\u003d_(\u0027Instance not yet ready\u0027))"},{"line_number":51,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":52,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":53,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":54,"context_line":"                exception.ConsoleTypeInvalid) as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_1eab0e8a","line":51,"in_reply_to":"3a961159_a472360f","updated":"2015-01-05 00:40:28.000000000","message":"that is handled in common.get_instance itself but compute_api.get_vnc_console can also raise InstanceNotFound\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4407","commit_id":"dec4ad9b4bd7fab656d65e9481b51b6e6d4967d5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eb8f03040a1f75ddb65dff718d875085d64e6dbd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":78,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":79,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":80,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":81,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":82,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":83,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c45e6279","line":80,"updated":"2014-12-29 08:55:51.000000000","message":"same issue here","commit_id":"dec4ad9b4bd7fab656d65e9481b51b6e6d4967d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ac35f62805ded272f5743b96e57988a42ead50b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":78,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":79,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":80,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":81,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":82,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":83,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3eae0a99","line":80,"in_reply_to":"3a961159_c45e6279","updated":"2015-01-05 00:40:28.000000000","message":"ditto","commit_id":"dec4ad9b4bd7fab656d65e9481b51b6e6d4967d5"}],"nova/api/openstack/compute/plugins/v3/remote_consoles.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5be62a95b12d363968df53e569723fdb3054193c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                                      instance,"},{"line_number":52,"context_line":"                                                      console_type)"},{"line_number":53,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":54,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":55,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":56,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":57,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1ebc4b06","line":54,"updated":"2014-12-26 05:19:37.000000000","message":"get_vnc_console in compute node raises ConsoleTypeInvalid if passing console_type except \u0027novnc\u0027 and \u0027xvpvnc\u0027.\nHowever, the schema validation can cover these cases at REST API layer on v2.1 API.\nso the above change does not seems necessary.","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09a2ca1021500eb9317bd20e432c3a2f0b38bf26","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                                      instance,"},{"line_number":52,"context_line":"                                                      console_type)"},{"line_number":53,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":54,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":55,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":56,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":57,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_de6ac31a","line":54,"in_reply_to":"3a961159_1ebc4b06","updated":"2014-12-26 06:47:38.000000000","message":"Yes, my bad. You are right. Thanks for this catch.","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5be62a95b12d363968df53e569723fdb3054193c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                        instance,"},{"line_number":82,"context_line":"                                                        console_type)"},{"line_number":83,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":84,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":85,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":86,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":87,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5e35f3a6","line":84,"updated":"2014-12-26 05:19:37.000000000","message":"ditto","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5be62a95b12d363968df53e569723fdb3054193c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                                      instance,"},{"line_number":115,"context_line":"                                                      console_type)"},{"line_number":116,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":117,"context_line":"                exception.ConsoleTypeInvalid) as e:"},{"line_number":118,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":119,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":120,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7e3aaf99","line":117,"updated":"2014-12-26 05:19:37.000000000","message":"ditto","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5be62a95b12d363968df53e569723fdb3054193c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":147,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":148,"context_line":"        except (exception.ConsoleTypeUnavailable,"},{"line_number":149,"context_line":"                exception.ConsoleTypeInvalid,"},{"line_number":150,"context_line":"                exception.ImageSerialPortNumberInvalid,"},{"line_number":151,"context_line":"                exception.ImageSerialPortNumberExceedFlavorValue,"},{"line_number":152,"context_line":"                exception.SocketPortRangeExhaustedException) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1e536be3","line":149,"updated":"2014-12-26 05:19:37.000000000","message":"I cannot find ConsoleTypeInvalid case in this API.\nand maybe even if the exception raises at compute node, this catch would be unnecessary because of the above same reason.","commit_id":"ec97861c7249e8fed6ca8f700c3906339c055b27"}]}