)]}'
{"id":"openstack%2Fnova~14313","triplet_id":"openstack%2Fnova~master~Ie07454f0d2075f5c3f2dd53b4e5ff9983ea3241f","project":"openstack/nova","branch":"master","topic":"bug/1065250","hashtags":[],"change_id":"Ie07454f0d2075f5c3f2dd53b4e5ff9983ea3241f","subject":"Pass correct task_state on snapshot","status":"MERGED","created":"2012-10-10 21:42:25.000000000","updated":"2012-10-12 23:02:53.000000000","submitted":"2012-10-12 23:02:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"14e21f0824f1fff0f087bcb0149470be2cd41847","_number":14313,"virtual_id_number":14313,"owner":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":1,"date":"2012-10-11 22:28:57.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-10-12 23:02:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":2,"date":"2012-10-12 20:12:36.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2012-10-12 15:26:38.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2012-10-12 21:53:23.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"date":"2012-10-12 22:21:29.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":1,"date":"2012-10-12 20:12:36.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2012-10-12 21:53:23.000000000","_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"date":"2012-10-12 22:21:29.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-10 21:50:39.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2012-10-11 22:28:57.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-10-12 15:26:38.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2012-10-12 20:12:36.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2012-10-12 22:21:29.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-10-12 23:02:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"53ab185779a8e3f0003cabf6af492a5df452f3e2","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-10-10 21:50:39.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"518fc1ee91d9d152e70baa94d70ddd56efce4257","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-10 22:02:16.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/39286\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/39284\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/39285\n","accounts_in_message":[],"_revision_number":1},{"id":"cfc7c6f097a82fc1f50efe79045ffb1583539bd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-10 22:03:23.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14313/1/check/gate-nova-merge/9914 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-nova-docs/5669 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-nova-pep8/10979 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-nova-python26/7124 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-nova-python27/7189 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-tempest-devstack-vm/14236 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-tempest-devstack-vm-cinder/4215 : SUCCESS\n- http://logs.openstack.org/14313/1/check/gate-nova-pylint/1542 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"0a51fcab976051773513fe817db670dd00153973","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-10-10 22:05:01.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\ns1rp will point out that test_and_set doesn\u0027t join things that were joined in the instance, so my suggestion would not work without adding joins there..  I guess this is probably better for now.. although I\u0027d prefer at some point this were somehow taken care of in the DB layer.","accounts_in_message":[],"_revision_number":1},{"id":"638ae06e249a77b5e1202987ca29bc24e013fea6","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2012-10-10 22:05:47.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1cd9f107315120e5b70cd5b39cf4d0e4a49645a6","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2012-10-11 22:04:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3aed4facc448ec2164e42dd67e8f2760bceffb5a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-11 22:28:57.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/39457\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/39455\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/39456\n","accounts_in_message":[],"_revision_number":2},{"id":"c57afda967115192898d7a0bd718b6e4487ad83c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-11 22:30:19.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14313/2/check/gate-nova-merge/9972 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-nova-docs/5727 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-nova-pep8/11037 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-nova-python26/7182 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-nova-python27/7247 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-tempest-devstack-vm/14352 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-tempest-devstack-vm-cinder/4331 : SUCCESS\n- http://logs.openstack.org/14313/2/check/gate-nova-pylint/1573 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"e712bf2ae3b4f62c603bb4161ae805174995b6d2","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-10-12 15:26:38.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"9bee5a41b821d00187f98316e711b76d0e631c08","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-10-12 20:12:36.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5d3cfc901d380c28c272666e769486b8ef6bb9c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 20:12:45.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"19a1963e2e788f8b21a74ab262db7ff8c0b3369d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 21:24:11.000000000","message":"Patch Set 2: Fails\n\nBuild failed\n\n- http://logs.openstack.org/14313/2/gate/gate-nova-merge/10019 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-docs/5774 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-pep8/11084 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-python26/7229 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-python27/7294 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-tempest-devstack-vm/14447 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-tempest-devstack-vm-cinder/4426 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"a72e6b13bcdda186a4506b48f5ddf038312820c7","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2012-10-12 21:53:23.000000000","message":"Patch Set 2:\n\nreapprove","accounts_in_message":[],"_revision_number":2},{"id":"bd81b01a7adfa147fb509d73c212d5b8d0c225a1","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-10-12 22:21:29.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"0d0ccf3769252370ea40fa03253bb54a954b8786","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 22:21:38.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"33106713c86435f419db1beb2d3c609d2c816fc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 23:02:52.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14313/2/gate/gate-nova-merge/10024 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-docs/5779 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-pep8/11089 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-python26/7234 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-nova-python27/7299 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-tempest-devstack-vm/14462 : SUCCESS\n- http://logs.openstack.org/14313/2/gate/gate-tempest-devstack-vm-cinder/4441 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"eae46f80ea30f7e76e8b4d341624c196818690aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 23:02:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3e6829a2012dd557a9e7c64281d4e6c73d1e3632","revisions":{"2a8c1f605c5b83b281f5b7c151b14f346fe467a0":{"kind":"REWORK","_number":1,"created":"2012-10-10 21:42:25.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/13/14313/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/13/14313/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/13/14313/1"}}},"commit":{"parents":[{"commit":"93d2a2cdbc86e541ee50e295a602639e7e572817","subject":"Merge \"Add Multiple Create extension to API sample tests.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93d2a2cdbc86e541ee50e295a602639e7e572817"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2012-10-10 21:36:24.000000000","tz":0},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2012-10-10 21:44:37.000000000","tz":0},"subject":"Pass correct task_state on snapshot.","message":"Pass correct task_state on snapshot.\n\nThis fixes an issue where we were not passing the correct task_state to\nthe compute manager thereby triggering an \u0027unexpected task-state error\u0027\nwhen the snapshot finished.\n\nThis error only manifested itself in multi-cell setups where the\ncompute-manager and compute-api are using separate DB\u0027s and therefore\nmust rely on the RPC-layer to enforce consistency.\n\nFixes bug 1065250\n\nChange-Id: Ie07454f0d2075f5c3f2dd53b4e5ff9983ea3241f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a8c1f605c5b83b281f5b7c151b14f346fe467a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a8c1f605c5b83b281f5b7c151b14f346fe467a0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"93d2a2cdbc86e541ee50e295a602639e7e572817","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"3e6829a2012dd557a9e7c64281d4e6c73d1e3632":{"kind":"REWORK","_number":2,"created":"2012-10-11 22:04:03.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/13/14313/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/13/14313/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/13/14313/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/13/14313/2"}}},"commit":{"parents":[{"commit":"93d2a2cdbc86e541ee50e295a602639e7e572817","subject":"Merge \"Add Multiple Create extension to API sample tests.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93d2a2cdbc86e541ee50e295a602639e7e572817"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2012-10-10 21:36:24.000000000","tz":0},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2012-10-11 22:04:02.000000000","tz":-300},"subject":"Pass correct task_state on snapshot","message":"Pass correct task_state on snapshot\n\nThis fixes an issue where we were not passing the correct task_state to\nthe compute manager thereby triggering an \u0027unexpected task-state error\u0027\nwhen the snapshot finished.\n\nThis error only manifested itself in multi-cell setups where the\ncompute-manager and compute-api are using separate DB\u0027s and therefore\nmust rely on the RPC-layer to enforce consistency.\n\nFixes bug 1065250\n\nChange-Id: Ie07454f0d2075f5c3f2dd53b4e5ff9983ea3241f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e6829a2012dd557a9e7c64281d4e6c73d1e3632"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e6829a2012dd557a9e7c64281d4e6c73d1e3632"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"93d2a2cdbc86e541ee50e295a602639e7e572817","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}