)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"38af7852e952f7e8fab5b7f9edc04bcc6cb45270","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            self._log_original_error(exc_info, instance_uuid)"},{"line_number":558,"context_line":"        else:"},{"line_number":559,"context_line":"            # not re-scheduling"},{"line_number":560,"context_line":"            raise exc_info"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def _reschedule(self, context, request_spec, filter_properties,"},{"line_number":563,"context_line":"            instance_uuid, scheduler_method, method_args, task_state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJIY%3D","line":560,"updated":"2012-10-11 18:59:56.000000000","message":"This won\u0027t do the right thing:\n\n  \u003e\u003e\u003e try:\n  ...     raise Exception(\u0027blah\u0027)\n  ... except Exception:\n  ...     exc_info \u003d sys.exc_info()\n  ...     raise exc_info\n  ... \n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 5, in \u003cmodule\u003e\n  Exception\n\nYou have to do something more like:\n\n  \u003e\u003e\u003e try:\n  ...     raise Exception(\u0027blah\u0027)\n  ... except Exception:\n  ...     exc_info \u003d sys.exc_info()\n  ...     raise exc_info[0], exc_info[1], exc_info[2]\n  ... \n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 2, in \u003cmodule\u003e\n  Exception: blah\n\n(Unfortunately, \"raise *exc_info\" won\u0027t work either.)","commit_id":"3f1dbdaa11f04d007e3a365d4e8a51c4f5835d3d"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b478847ad7cb5ad85cf6ba074c95ef89eea458a1","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            self._log_original_error(exc_info, instance_uuid)"},{"line_number":558,"context_line":"        else:"},{"line_number":559,"context_line":"            # not re-scheduling"},{"line_number":560,"context_line":"            raise exc_info"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def _reschedule(self, context, request_spec, filter_properties,"},{"line_number":563,"context_line":"            instance_uuid, scheduler_method, method_args, task_state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJAc%3D","line":560,"in_reply_to":"AAAALH%2F%2FJIY%3D","updated":"2012-10-11 21:58:29.000000000","message":"Educational, thanks.","commit_id":"3f1dbdaa11f04d007e3a365d4e8a51c4f5835d3d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"38af7852e952f7e8fab5b7f9edc04bcc6cb45270","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"                    raise exception.MigrationError(msg)"},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"                # TODO(russellb): no-db-compute: Send the old instance type"},{"line_number":1554,"context_line":"                # info # that is needed via rpc so db access isn\u0027t required"},{"line_number":1555,"context_line":"                # here."},{"line_number":1556,"context_line":"                old_instance_type_id \u003d instance[\u0027instance_type_id\u0027]"},{"line_number":1557,"context_line":"                old_instance_type \u003d instance_types.get_instance_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJIU%3D","line":1554,"updated":"2012-10-11 18:59:56.000000000","message":"Double-# when you re-word-wrapped…","commit_id":"3f1dbdaa11f04d007e3a365d4e8a51c4f5835d3d"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b478847ad7cb5ad85cf6ba074c95ef89eea458a1","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"                    raise exception.MigrationError(msg)"},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"                # TODO(russellb): no-db-compute: Send the old instance type"},{"line_number":1554,"context_line":"                # info # that is needed via rpc so db access isn\u0027t required"},{"line_number":1555,"context_line":"                # here."},{"line_number":1556,"context_line":"                old_instance_type_id \u003d instance[\u0027instance_type_id\u0027]"},{"line_number":1557,"context_line":"                old_instance_type \u003d instance_types.get_instance_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJAg%3D","line":1554,"in_reply_to":"AAAALH%2F%2FJIU%3D","updated":"2012-10-11 21:58:29.000000000","message":"Done","commit_id":"3f1dbdaa11f04d007e3a365d4e8a51c4f5835d3d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"252024db2b2c3e938938753aea9f81a945c7f2b2","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        type_, value, tb \u003d exc_info"},{"line_number":520,"context_line":"        LOG.error(_(\u0027Error: %s\u0027) %"},{"line_number":521,"context_line":"                traceback.format_exception(type_, value, tb),"},{"line_number":522,"context_line":"                instance_uuid\u003dinstance_uuid)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def _reschedule_or_reraise(self, context, instance, requested_networks,"},{"line_number":525,"context_line":"                               admin_password, injected_files, is_first_time,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2F0%3D","line":522,"updated":"2012-10-11 22:11:15.000000000","message":"femtonit: Indent these last two lines two more spaces, so they line up after the first \u0027(\u0027 in the LOG.error call…technically, pep8 requires it, but we disable that particular pep8 error for nova, at least for now.\n\n(I shudder to imagine the size of the patch that will result from reenabling some of those pep8 errors…)","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"43ad6c13c05b8435e1f71db20bd4ab6b5db15fb6","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        type_, value, tb \u003d exc_info"},{"line_number":520,"context_line":"        LOG.error(_(\u0027Error: %s\u0027) %"},{"line_number":521,"context_line":"                traceback.format_exception(type_, value, tb),"},{"line_number":522,"context_line":"                instance_uuid\u003dinstance_uuid)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def _reschedule_or_reraise(self, context, instance, requested_networks,"},{"line_number":525,"context_line":"                               admin_password, injected_files, is_first_time,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2BI%3D","line":522,"in_reply_to":"AAAALH%2F%2FI%2F0%3D","updated":"2012-10-11 22:36:43.000000000","message":"Done","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"252024db2b2c3e938938753aea9f81a945c7f2b2","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"            self._log_original_error(exc_info, instance_uuid)"},{"line_number":1620,"context_line":"        else:"},{"line_number":1621,"context_line":"            # not re-scheduling"},{"line_number":1622,"context_line":"            raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1625,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2Fw%3D","line":1622,"updated":"2012-10-11 22:11:15.000000000","message":"Makes me wonder if these two _reschedule_*_or_reraise() methods can be further refactored to reduce code duplication…something to think about for the future, at least.","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"43ad6c13c05b8435e1f71db20bd4ab6b5db15fb6","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"            self._log_original_error(exc_info, instance_uuid)"},{"line_number":1620,"context_line":"        else:"},{"line_number":1621,"context_line":"            # not re-scheduling"},{"line_number":1622,"context_line":"            raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1625,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2BA%3D","line":1622,"in_reply_to":"AAAALH%2F%2FI%2Fw%3D","updated":"2012-10-11 22:36:43.000000000","message":"I almost did that, they are very.  The original one actually deallocates network stuff to avoid folding more ugly exception handling into _run_instance, but yeah they could may be folded together somehow.","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"38af7852e952f7e8fab5b7f9edc04bcc6cb45270","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        2.2 - Adds slave_info parameter to add_aggregate_host() and"},{"line_number":132,"context_line":"              remove_aggregate_host()"},{"line_number":133,"context_line":"        2.3 - Adds volume_id to reserve_block_device_name()"},{"line_number":134,"context_line":"        2.4 - Adds filter_properties and request_spec to prep_resize()"},{"line_number":135,"context_line":"    \u0027\u0027\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    #"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJII%3D","line":134,"updated":"2012-10-11 18:59:56.000000000","message":"FYI, there\u0027s a pending patch which ups the RPC version…","commit_id":"3f1dbdaa11f04d007e3a365d4e8a51c4f5835d3d"}],"nova/tests/compute/test_rpcapi.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"252024db2b2c3e938938753aea9f81a945c7f2b2","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                reservations\u003dlist(\u0027fake_res\u0027),"},{"line_number":217,"context_line":"                request_spec\u003d\u0027fake_spec\u0027,"},{"line_number":218,"context_line":"                filter_properties\u003d{\u0027fakeprop\u0027: \u0027fakeval\u0027},"},{"line_number":219,"context_line":"                version\u003d\u00272.3\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_reboot_instance(self):"},{"line_number":222,"context_line":"        self._test_compute_api(\u0027reboot_instance\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2Fo%3D","line":219,"updated":"2012-10-11 22:11:15.000000000","message":"version 2.3 or version 2.4?","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"43ad6c13c05b8435e1f71db20bd4ab6b5db15fb6","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                reservations\u003dlist(\u0027fake_res\u0027),"},{"line_number":217,"context_line":"                request_spec\u003d\u0027fake_spec\u0027,"},{"line_number":218,"context_line":"                filter_properties\u003d{\u0027fakeprop\u0027: \u0027fakeval\u0027},"},{"line_number":219,"context_line":"                version\u003d\u00272.3\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_reboot_instance(self):"},{"line_number":222,"context_line":"        self._test_compute_api(\u0027reboot_instance\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FI%2BQ%3D","line":219,"in_reply_to":"AAAALH%2F%2FI%2Fo%3D","updated":"2012-10-11 22:36:43.000000000","message":"Done","commit_id":"149221a973355fc3405725ac6cbb0014ea99be34"}]}