)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ae68a13ed3203e0279c4ffeb7bdce4e853cb9e6f","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        block_device_mapping \u003d None"},{"line_number":794,"context_line":"        if self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":795,"context_line":"            block_device_mapping \u003d server_dict.get(\u0027block_device_mapping\u0027, [])"},{"line_number":796,"context_line":"            for bdm_idx in range(len(block_device_mapping)):"},{"line_number":797,"context_line":"                bdm \u003d block_device_mapping[bdm_idx]"},{"line_number":798,"context_line":"                if \u0027delete_on_termination\u0027 in bdm:"},{"line_number":799,"context_line":"                    bdm[\u0027delete_on_termination\u0027] \u003d utils.bool_from_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FIwU%3D","line":796,"updated":"2012-10-12 09:14:54.000000000","message":"Just a python style nitpick - this loop can be more concisely written like:\n\nfor bdm in block_device_mapping:\n    if \u0027delete_on_termination\u0027 in bdm:\n         bdm[\u0027delete_on_termination\u0027] \u003d utils.bool_from_str(bdm[\u0027delete_on_termination\u0027])\n\nUsing indexes seems a bit confusing.","commit_id":"14250ec3768584a3d7cef3ddb41c202e8dd8f707"},{"author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"change_message_id":"b84e53122b2e2540ce083051a35029bd0cbe2d9f","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        block_device_mapping \u003d None"},{"line_number":794,"context_line":"        if self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":795,"context_line":"            block_device_mapping \u003d server_dict.get(\u0027block_device_mapping\u0027, [])"},{"line_number":796,"context_line":"            for bdm_idx in range(len(block_device_mapping)):"},{"line_number":797,"context_line":"                bdm \u003d block_device_mapping[bdm_idx]"},{"line_number":798,"context_line":"                if \u0027delete_on_termination\u0027 in bdm:"},{"line_number":799,"context_line":"                    bdm[\u0027delete_on_termination\u0027] \u003d utils.bool_from_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F%2F1M%3D","line":796,"in_reply_to":"AAAALH%2F%2FGN0%3D","updated":"2012-10-22 12:35:12.000000000","message":"Done","commit_id":"14250ec3768584a3d7cef3ddb41c202e8dd8f707"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"738692c2b93aead4a80714351ff74ff7ac282a46","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        block_device_mapping \u003d None"},{"line_number":794,"context_line":"        if self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":795,"context_line":"            block_device_mapping \u003d server_dict.get(\u0027block_device_mapping\u0027, [])"},{"line_number":796,"context_line":"            for bdm_idx in range(len(block_device_mapping)):"},{"line_number":797,"context_line":"                bdm \u003d block_device_mapping[bdm_idx]"},{"line_number":798,"context_line":"                if \u0027delete_on_termination\u0027 in bdm:"},{"line_number":799,"context_line":"                    bdm[\u0027delete_on_termination\u0027] \u003d utils.bool_from_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FGN0%3D","line":796,"in_reply_to":"AAAALH%2F%2FIwU%3D","updated":"2012-10-20 04:33:59.000000000","message":"agreed","commit_id":"14250ec3768584a3d7cef3ddb41c202e8dd8f707"}]}