)]}'
{"id":"openstack%2Fnova~14377","triplet_id":"openstack%2Fnova~master~Ib35040f17a3712dac45ec1e3c2f32fee17db7c03","project":"openstack/nova","branch":"master","topic":"openstack-qa-nova-1060955","hashtags":[],"change_id":"Ib35040f17a3712dac45ec1e3c2f32fee17db7c03","subject":"Fix error on invalid delete_on_termination value","status":"MERGED","created":"2012-10-12 06:38:53.000000000","updated":"2012-10-24 19:10:07.000000000","submitted":"2012-10-24 19:10:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f28a921170405600c6340f4e4e7734ab08e3c5aa","_number":14377,"virtual_id_number":14377,"owner":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":1,"date":"2012-10-22 13:04:14.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-10-24 19:10:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-10-22 12:37:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":2,"date":"2012-10-24 18:30:54.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-10-22 13:34:22.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},{"value":2,"date":"2012-10-22 20:10:16.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":1,"date":"2012-10-24 18:30:54.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},{"value":0,"date":"2012-10-22 20:10:16.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-20 04:33:59.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2012-10-22 12:37:10.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2012-10-22 13:04:14.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-10-22 20:10:16.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-10-24 18:30:54.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-10-24 19:10:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"efc788606cca7efb0c0f42ab0a9de842dad46606","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 06:39:13.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"2e619a6f64155ff1e75ace8d27b06ffce7d0aa3d","author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"date":"2012-10-12 06:50:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"10ee54d0f5e80f3d3cb0f0f7dbf2b86dc7f7000d","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-10-12 06:50:59.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"342f8af47d13241d27efe8865ea6bff8ffb21a1b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-12 07:15:03.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/39551\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/39549\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/39550\n","accounts_in_message":[],"_revision_number":2},{"id":"127958b1f5e3103cb7ffd9872cd7af19746fe86f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-12 07:27:02.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14377/2/check/gate-nova-merge/9995 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-nova-docs/5750 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-nova-pep8/11060 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-nova-python26/7205 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-nova-python27/7270 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-tempest-devstack-vm/14391 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-tempest-devstack-vm-cinder/4370 : SUCCESS\n- http://logs.openstack.org/14377/2/check/gate-nova-pylint/1589 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ae68a13ed3203e0279c4ffeb7bdce4e853cb9e6f","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2012-10-12 09:14:54.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"738692c2b93aead4a80714351ff74ff7ac282a46","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-10-20 04:33:59.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nnice fix. But please restructure the loop as suggested to be more pythonic.\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"b84e53122b2e2540ce083051a35029bd0cbe2d9f","author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"date":"2012-10-22 12:35:12.000000000","message":"Patch Set 2: (1 inline comment)\n\nSubmitting another patch addressing the issue.","accounts_in_message":[],"_revision_number":2},{"id":"9e1a6a9074f71be30d5aa2ca5fb4cf38601ad12f","author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"date":"2012-10-22 12:35:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cfe16279fe8506e7a1424ab2adeeec0a01388a76","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2012-10-22 12:37:10.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"3d0fe9e518f9ab6a84ac6329dc58c9f6f8e8fd86","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-22 13:04:14.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/40756\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/40754\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/40755\n","accounts_in_message":[],"_revision_number":3},{"id":"755d22a495adf52f0bd52fc9a7344cd4b2ad09a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-22 13:10:52.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/14377/3/check/gate-nova-merge/10209 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-docs/5963 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-pep8/11273 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-python26/7419 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-python27/7483 : SUCCESS\n- gate-tempest-devstack-vm : LOST\n- http://logs.openstack.org/14377/3/check/gate-tempest-devstack-vm-cinder/4864 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-pylint/1726 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"581cb347ec72d08e15faa77c14683b165b44cbaa","author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"date":"2012-10-22 13:34:22.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"d1b4ebd9acd4370ba8e2c8c043856ff9fb68540a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-22 14:05:20.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14377/3/check/gate-nova-merge/10214 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-docs/5968 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-pep8/11278 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-python26/7424 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-python27/7488 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-tempest-devstack-vm/14878 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-tempest-devstack-vm-cinder/4872 : SUCCESS\n- http://logs.openstack.org/14377/3/check/gate-nova-pylint/1731 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"ca3640e9eb9e7e41cd556f5ce8e3cb211e95816c","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-10-22 20:10:16.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"c8185668d431a7c2d1177781cd13287cc9bb8e52","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-10-24 18:30:54.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8622bd6db9e80992f2bb9c98bd89819580c5eb3d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 18:31:04.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":3},{"id":"1663d892e16724f55ebeda9af5cc84086257390d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 19:10:04.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14377/3/gate/gate-nova-merge/10387 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-nova-docs/6140 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-nova-pep8/11450 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-nova-python26/7596 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-nova-python27/7660 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-tempest-devstack-vm/15358 : SUCCESS\n- http://logs.openstack.org/14377/3/gate/gate-tempest-devstack-vm-cinder/5352 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"07baa0e51186817e0bd61a5bb5c0bf4126d648c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 19:10:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7c9761b3bb52788021b5bf0eb9726af833db4074","revisions":{"f92953fc607a04a5cdffbecac464cc51712bbd5c":{"kind":"REWORK","_number":1,"created":"2012-10-12 06:38:53.000000000","uploader":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"ref":"refs/changes/77/14377/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/14377/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/14377/1"}}},"commit":{"parents":[{"commit":"b77629df01396adc55aa7024b4d3b1380849cae0","subject":"Merge \"Clean up imports in test_servers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b77629df01396adc55aa7024b4d3b1380849cae0"}]}],"author":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-12 06:36:59.000000000","tz":-420},"committer":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-12 06:36:59.000000000","tz":-420},"subject":"Fixes err on invalid delete_on_termination value","message":"Fixes err on invalid delete_on_termination value\n\n1. Fixed 500 error when an invalid value is passed to \u0027delete_on_termination\u0027\nparameter in \u0027block_device_mapping\u0027 of create server API (json request).\nConverted the value to \u0027bool\u0027 (similar to XML request workflow) to fix issue.\n2. Also added unit test coverage.\n\nFixes LP: #1060955\n\nChange-Id: Ib35040f17a3712dac45ec1e3c2f32fee17db7c03\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f92953fc607a04a5cdffbecac464cc51712bbd5c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f92953fc607a04a5cdffbecac464cc51712bbd5c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b77629df01396adc55aa7024b4d3b1380849cae0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"14250ec3768584a3d7cef3ddb41c202e8dd8f707":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-10-12 06:50:52.000000000","uploader":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"ref":"refs/changes/77/14377/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/14377/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/14377/2"}}},"commit":{"parents":[{"commit":"b77629df01396adc55aa7024b4d3b1380849cae0","subject":"Merge \"Clean up imports in test_servers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b77629df01396adc55aa7024b4d3b1380849cae0"}]}],"author":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-12 06:48:08.000000000","tz":-420},"committer":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-12 06:49:21.000000000","tz":-420},"subject":"Fix error on invalid delete_on_termination value","message":"Fix error on invalid delete_on_termination value\n\n1. Fixed 500 error when an invalid value is passed to \u0027delete_on_termination\u0027\nparameter in \u0027block_device_mapping\u0027 of create server API (json request).\nConverted the value to \u0027bool\u0027 (similar to XML request workflow) to fix issue.\n2. Also added unit test coverage.\n\nFixes LP: #1060955\n\nChange-Id: Ib35040f17a3712dac45ec1e3c2f32fee17db7c03\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14250ec3768584a3d7cef3ddb41c202e8dd8f707"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14250ec3768584a3d7cef3ddb41c202e8dd8f707"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b77629df01396adc55aa7024b4d3b1380849cae0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"7c9761b3bb52788021b5bf0eb9726af833db4074":{"kind":"REWORK","_number":3,"created":"2012-10-22 12:35:45.000000000","uploader":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"ref":"refs/changes/77/14377/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/14377/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/14377/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/14377/3"}}},"commit":{"parents":[{"commit":"8cb329b2a03f1d04f13c38244477e53ca4a321f0","subject":"Merge \"Allow local rbd user and secret_uuid configuration\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8cb329b2a03f1d04f13c38244477e53ca4a321f0"}]}],"author":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-12 06:48:08.000000000","tz":-420},"committer":{"name":"Unmesh Gurjar","email":"unmesh.gurjar@nttdata.com","date":"2012-10-22 12:33:49.000000000","tz":-420},"subject":"Fix error on invalid delete_on_termination value","message":"Fix error on invalid delete_on_termination value\n\n1. Fixed 500 error when an invalid value is passed to \u0027delete_on_termination\u0027\nparameter in \u0027block_device_mapping\u0027 of create server API (json request).\nConverted the value to \u0027bool\u0027 (similar to XML request workflow) to fix issue.\n2. Also added unit test coverage.\n\nFixes LP: #1060955\n\nChange-Id: Ib35040f17a3712dac45ec1e3c2f32fee17db7c03\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c9761b3bb52788021b5bf0eb9726af833db4074"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c9761b3bb52788021b5bf0eb9726af833db4074"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8cb329b2a03f1d04f13c38244477e53ca4a321f0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}