)]}'
{"nova/virt/libvirt/volume.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"16561e8a73ca74045664380c68e0187f2d93d78c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                    entry_ip_iqn \u003d entry_ip_iqn[3:]"},{"line_number":435,"context_line":"                if (ip_iqn !\u003d entry_ip_iqn):"},{"line_number":436,"context_line":"                    continue"},{"line_number":437,"context_line":"                entry_real_path \u003d os.path.realpath(\"/dev/disk/by-path/%s\" %"},{"line_number":438,"context_line":"                                                   entry)"},{"line_number":439,"context_line":"                entry_mpdev \u003d self._get_multipath_device_name(entry_real_path)"},{"line_number":440,"context_line":"                if entry_mpdev \u003d\u003d multipath_device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c94fb98a","line":437,"updated":"2015-01-16 02:16:42.000000000","message":"Disks can also have the path in the format \"by-path/pci-0000:00:00.0-%s-iscsi-%s-lun-N\" but this will be addressed by https://review.openstack.org/#/c/146233 if you don\u0027t","commit_id":"7307dbaf6b9734ddd456c7b0c1d2c85e053ce61f"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"3f73a518bcc2c356be2fa41a945455acf2a6bbf3","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                    entry_ip_iqn \u003d entry_ip_iqn[3:]"},{"line_number":435,"context_line":"                if (ip_iqn !\u003d entry_ip_iqn):"},{"line_number":436,"context_line":"                    continue"},{"line_number":437,"context_line":"                entry_real_path \u003d os.path.realpath(\"/dev/disk/by-path/%s\" %"},{"line_number":438,"context_line":"                                                   entry)"},{"line_number":439,"context_line":"                entry_mpdev \u003d self._get_multipath_device_name(entry_real_path)"},{"line_number":440,"context_line":"                if entry_mpdev \u003d\u003d multipath_device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_aaf3389d","line":437,"in_reply_to":"3a961159_4ae494df","updated":"2015-01-16 07:37:38.000000000","message":"This won\u0027t be an issue unless the patch I pointed out is backported, since the only other way to get such a path is via iser which handles them separately. Hence the +1","commit_id":"7307dbaf6b9734ddd456c7b0c1d2c85e053ce61f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c0c5fe27f9dffad5b1c3167db4b34b82dc827a1a","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                    entry_ip_iqn \u003d entry_ip_iqn[3:]"},{"line_number":435,"context_line":"                if (ip_iqn !\u003d entry_ip_iqn):"},{"line_number":436,"context_line":"                    continue"},{"line_number":437,"context_line":"                entry_real_path \u003d os.path.realpath(\"/dev/disk/by-path/%s\" %"},{"line_number":438,"context_line":"                                                   entry)"},{"line_number":439,"context_line":"                entry_mpdev \u003d self._get_multipath_device_name(entry_real_path)"},{"line_number":440,"context_line":"                if entry_mpdev \u003d\u003d multipath_device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4ae494df","line":437,"in_reply_to":"3a961159_c94fb98a","updated":"2015-01-16 07:33:18.000000000","message":"@Anish: Thanks for pointing that out. Since this is a stable review, I think the patch you linked, if necessary, should be backported as well, as we don\u0027t modify stable backports.","commit_id":"7307dbaf6b9734ddd456c7b0c1d2c85e053ce61f"}]}