)]}'
{"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f0e04018b33e25f6776d76b505616c2ec023436e","unresolved":false,"context_lines":[{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        common.check_img_metadata_properties_quota(context, metadata)"},{"line_number":990,"context_line":"        props \u003d {}"},{"line_number":991,"context_line":"        props.update(metadata)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        instance \u003d self._get_server(context, req, id)"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_fec77444","line":991,"updated":"2014-12-27 10:24:45.000000000","message":"This code related to props is the existing code, but I\u0027d like to suggest passing metadata to line 1015/1020 directly without props for simple code.","commit_id":"97e4d4358d184122df5684c3e7a09c1052e7e767"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"14f96845a7f1b452da78baac3b387a6384ea32b2","unresolved":false,"context_lines":[{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        common.check_img_metadata_properties_quota(context, metadata)"},{"line_number":990,"context_line":"        props \u003d {}"},{"line_number":991,"context_line":"        props.update(metadata)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        instance \u003d self._get_server(context, req, id)"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2fcdfeb7","line":991,"in_reply_to":"3a961159_3d829700","updated":"2015-01-04 03:13:08.000000000","message":"Done","commit_id":"97e4d4358d184122df5684c3e7a09c1052e7e767"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9b32eacb7a924a6bd7e9fdc8def4d03cad11b8ea","unresolved":false,"context_lines":[{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        common.check_img_metadata_properties_quota(context, metadata)"},{"line_number":990,"context_line":"        props \u003d {}"},{"line_number":991,"context_line":"        props.update(metadata)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        instance \u003d self._get_server(context, req, id)"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3d829700","line":991,"in_reply_to":"3a961159_c20292b3","updated":"2015-01-03 22:30:40.000000000","message":"No, that seems meaningless.\n\nremove line990-991 and change line1015/1020 to\n\n  extra_properties\u003dmetadata)","commit_id":"97e4d4358d184122df5684c3e7a09c1052e7e767"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"31fd5a325796a5d15c632b3de8dafe657dd011c3","unresolved":false,"context_lines":[{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        common.check_img_metadata_properties_quota(context, metadata)"},{"line_number":990,"context_line":"        props \u003d {}"},{"line_number":991,"context_line":"        props.update(metadata)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        instance \u003d self._get_server(context, req, id)"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c20292b3","line":991,"in_reply_to":"3a961159_fec77444","updated":"2015-01-03 13:44:04.000000000","message":"Do you mean deleting line 991?","commit_id":"97e4d4358d184122df5684c3e7a09c1052e7e767"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"fb8170ed002d082c04bca40f761734219e705551","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        return self._add_location(robj)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    @wsgi.response(202)"},{"line_number":990,"context_line":"    @extensions.expected_errors((400, 403, 404, 409))"},{"line_number":991,"context_line":"    @wsgi.action(\u0027createImage\u0027)"},{"line_number":992,"context_line":"    @common.check_snapshots_enabled"},{"line_number":993,"context_line":"    @validation.schema(schema_servers.create_image)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_be522adb","line":990,"updated":"2015-01-22 09:36:52.000000000","message":"nit/query: I don\u0027t see anything returning HTTP/403 in here. Can we tidy this up as well (or did I miss something)?","commit_id":"2f10b7a90e84fb6a0bb6b85c91268f17366f904d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3d34e5c91a3dd8409fe5b667b7bd9b920ec3af5d","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        return self._add_location(robj)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    @wsgi.response(202)"},{"line_number":990,"context_line":"    @extensions.expected_errors((400, 403, 404, 409))"},{"line_number":991,"context_line":"    @wsgi.action(\u0027createImage\u0027)"},{"line_number":992,"context_line":"    @common.check_snapshots_enabled"},{"line_number":993,"context_line":"    @validation.schema(schema_servers.create_image)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_2d99296e","line":990,"in_reply_to":"1a930d6b_be522adb","updated":"2015-01-27 00:44:33.000000000","message":"That seems out of the scope from this patch, because this patch doesn\u0027t change HTTP/403 case.","commit_id":"2f10b7a90e84fb6a0bb6b85c91268f17366f904d"}]}