)]}'
{"doc/api_samples/all_extensions/extensions-get-resp.json":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"18510b72a1d70485b1da781b54b0be72566bca60","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            \"name\": \"FixedIPs\","},{"line_number":152,"context_line":"            \"namespace\": \"http://docs.openstack.org/compute/ext/fixed_ips/api/v2\","},{"line_number":153,"context_line":"            \"updated\": \"2012-10-18T13:25:27-06:00\""},{"line_number":154,"context_line":"        },"},{"line_number":155,"context_line":"        {"},{"line_number":156,"context_line":"            \"alias\": \"os-flavor-access\","},{"line_number":157,"context_line":"            \"description\": \"Flavor access supprt\","}],"source_content_type":"application/json","patch_set":13,"id":"AAAAMH%2F%2FsXY%3D","line":154,"updated":"2012-11-30 01:16:20.000000000","message":"dan already handled this in his patch ( https://review.openstack.org/#/c/16991/3/doc/api_samples/all_extensions/extensions-get-resp.json), so I think you\u0027ll need to rebase.\n\n same to os-floating-ips-bulk and fping and for xml","commit_id":"2943f272238222c04053949c61901dc7d782e634"}],"etc/nova/policy.json":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3412faea70e6756bc8ad266e0a36121d7807e8fb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"compute_extension:cloudpipe\": \"rule:admin_api\","},{"line_number":33,"context_line":"    \"compute_extension:console_output\": \"\","},{"line_number":34,"context_line":"    \"compute_extension:consoles\": \"\","},{"line_number":35,"context_line":"    \"compute_extension:coverage_ext\": \"rule:admin_api\","},{"line_number":36,"context_line":"    \"compute_extension:createserverext\": \"\","},{"line_number":37,"context_line":"    \"compute_extension:deferred_delete\": \"\","},{"line_number":38,"context_line":"    \"compute_extension:disk_config\": \"\","}],"source_content_type":"application/json","patch_set":11,"id":"AAAAMH%2F%2FvZE%3D","line":35,"updated":"2012-11-27 21:03:36.000000000","message":"nit, seems like adding _ext to the extension name is redundant","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"compute_extension:cloudpipe\": \"rule:admin_api\","},{"line_number":33,"context_line":"    \"compute_extension:console_output\": \"\","},{"line_number":34,"context_line":"    \"compute_extension:consoles\": \"\","},{"line_number":35,"context_line":"    \"compute_extension:coverage_ext\": \"rule:admin_api\","},{"line_number":36,"context_line":"    \"compute_extension:createserverext\": \"\","},{"line_number":37,"context_line":"    \"compute_extension:deferred_delete\": \"\","},{"line_number":38,"context_line":"    \"compute_extension:disk_config\": \"\","}],"source_content_type":"application/json","patch_set":11,"id":"AAAAMH%2F%2FvWs%3D","line":35,"in_reply_to":"AAAAMH%2F%2FvZE%3D","updated":"2012-11-28 19:42:07.000000000","message":"The _ext is there to avoid import issues with the coverage module. I guess it could be something else but it just can\u0027t be \u0027coverage\u0027.","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"}],"nova/api/openstack/compute/contrib/coverage_ext.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class CoverageController(object):"},{"line_number":39,"context_line":"    \u0027\u0027\u0027The Coverage report API controller for the OpenStack API\u0027\u0027\u0027"},{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        self.coverInst \u003d coverage(data_file\u003d\u0027/tmp/.nova-coverage\u0027)"},{"line_number":42,"context_line":"        self.compute_api \u003d compute_api.API()"},{"line_number":43,"context_line":"        self.network_api \u003d network_api.API()"},{"line_number":44,"context_line":"        self.services \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvZg%3D","line":41,"updated":"2012-11-27 21:13:06.000000000","message":"Hmm, should this be a tmpfile call, or at least get the temp directory from it? This will fail on Windows.\n\nWhy is the default filename hidden?","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3412faea70e6756bc8ad266e0a36121d7807e8fb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class CoverageController(object):"},{"line_number":39,"context_line":"    \u0027\u0027\u0027The Coverage report API controller for the OpenStack API\u0027\u0027\u0027"},{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        self.coverInst \u003d coverage(data_file\u003d\u0027/tmp/.nova-coverage\u0027)"},{"line_number":42,"context_line":"        self.compute_api \u003d compute_api.API()"},{"line_number":43,"context_line":"        self.network_api \u003d network_api.API()"},{"line_number":44,"context_line":"        self.services \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvYs%3D","line":41,"updated":"2012-11-27 21:03:36.000000000","message":"should probably be using a proper tempfile generation - http://docs.python.org/2/library/tempfile.html. As long as the filename is stored in the instance it should be fine.","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class CoverageController(object):"},{"line_number":39,"context_line":"    \u0027\u0027\u0027The Coverage report API controller for the OpenStack API\u0027\u0027\u0027"},{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        self.coverInst \u003d coverage(data_file\u003d\u0027/tmp/.nova-coverage\u0027)"},{"line_number":42,"context_line":"        self.compute_api \u003d compute_api.API()"},{"line_number":43,"context_line":"        self.network_api \u003d network_api.API()"},{"line_number":44,"context_line":"        self.services \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvSg%3D","line":41,"in_reply_to":"AAAAMH%2F%2FvZg%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        ports \u003d []"},{"line_number":66,"context_line":"        temp \u003d {}"},{"line_number":67,"context_line":"        for sev in hosts:"},{"line_number":68,"context_line":"            if sev[\u0027service\u0027] in apicommands:"},{"line_number":69,"context_line":"                if sev[\u0027service\u0027] \u003d\u003d \u0027compute\u0027:"},{"line_number":70,"context_line":"                    temp \u003d sev"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvZQ%3D","line":67,"updated":"2012-11-27 21:13:06.000000000","message":"This is a nit, but I don\u0027t know what \"sev\" is short for. Can you make this \"host in hosts\"?","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        ports \u003d []"},{"line_number":66,"context_line":"        temp \u003d {}"},{"line_number":67,"context_line":"        for sev in hosts:"},{"line_number":68,"context_line":"            if sev[\u0027service\u0027] in apicommands:"},{"line_number":69,"context_line":"                if sev[\u0027service\u0027] \u003d\u003d \u0027compute\u0027:"},{"line_number":70,"context_line":"                    temp \u003d sev"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvVE%3D","line":67,"in_reply_to":"AAAAMH%2F%2FvZQ%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    temp \u003d sev"},{"line_number":71,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context,"},{"line_number":72,"context_line":"                                                             sev[\u0027host\u0027])"},{"line_number":73,"context_line":"                    ports.append(temp)"},{"line_number":74,"context_line":"                else:"},{"line_number":75,"context_line":"                    temp \u003d sev"},{"line_number":76,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvZA%3D","line":73,"updated":"2012-11-27 21:13:06.000000000","message":"I think that there\u0027s probably a better name than temp for this. Assuming s/sev/host/, then maybe _host \u003d host or something","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    temp \u003d sev"},{"line_number":71,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context,"},{"line_number":72,"context_line":"                                                             sev[\u0027host\u0027])"},{"line_number":73,"context_line":"                    ports.append(temp)"},{"line_number":74,"context_line":"                else:"},{"line_number":75,"context_line":"                    temp \u003d sev"},{"line_number":76,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvU8%3D","line":73,"in_reply_to":"AAAAMH%2F%2FvZA%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    ports.append(temp)"},{"line_number":74,"context_line":"                else:"},{"line_number":75,"context_line":"                    temp \u003d sev"},{"line_number":76,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context)"},{"line_number":77,"context_line":"                    ports.append(temp)"},{"line_number":78,"context_line":"            else:"},{"line_number":79,"context_line":"                LOG.debug(_(\"No backdoor API command for service: %s\\n\"), sev)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvY4%3D","line":76,"updated":"2012-11-27 21:13:06.000000000","message":"This (and the other instance above) looks a bit confusing. Could you put, as the first line in the parent if block, something like:\n\nget_port_fn \u003d apicommands[sev[\u0027service\u0027]]\n\nand then make this line a call to:\n\ntemp[\u0027port\u0027] \u003d get_port_fn(context, sev[\u0027host\u0027])\n\n?","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    ports.append(temp)"},{"line_number":74,"context_line":"                else:"},{"line_number":75,"context_line":"                    temp \u003d sev"},{"line_number":76,"context_line":"                    temp[\u0027port\u0027] \u003d apicommands[sev[\u0027service\u0027]](context)"},{"line_number":77,"context_line":"                    ports.append(temp)"},{"line_number":78,"context_line":"            else:"},{"line_number":79,"context_line":"                LOG.debug(_(\"No backdoor API command for service: %s\\n\"), sev)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvUs%3D","line":76,"in_reply_to":"AAAAMH%2F%2FvY4%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        tn.write(\u0027from coverage import coverage\\n\u0027)"},{"line_number":85,"context_line":"        if self.combine:"},{"line_number":86,"context_line":"            tn.write(\"coverInst \u003d coverage\""},{"line_number":87,"context_line":"                     \"(data_file\u003d\u0027/tmp/.nova-coverage.%s\u0027)\\n\" % str(service))"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            tn.write(\u0027coverInst \u003d coverage()\\n\u0027)"},{"line_number":90,"context_line":"        tn.write(\u0027coverInst.skipModules \u003d sys.modules.keys()[:]\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvY0%3D","line":87,"updated":"2012-11-27 21:13:06.000000000","message":"Same pathing concern here","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        tn.write(\u0027from coverage import coverage\\n\u0027)"},{"line_number":85,"context_line":"        if self.combine:"},{"line_number":86,"context_line":"            tn.write(\"coverInst \u003d coverage\""},{"line_number":87,"context_line":"                     \"(data_file\u003d\u0027/tmp/.nova-coverage.%s\u0027)\\n\" % str(service))"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            tn.write(\u0027coverInst \u003d coverage()\\n\u0027)"},{"line_number":90,"context_line":"        tn.write(\u0027coverInst.skipModules \u003d sys.modules.keys()[:]\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvSk%3D","line":87,"in_reply_to":"AAAAMH%2F%2FvY0%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        body \u003d body[\u0027start\u0027]"},{"line_number":97,"context_line":"        self.combine \u003d False"},{"line_number":98,"context_line":"        if \u0027combine\u0027 in body.keys():"},{"line_number":99,"context_line":"            self.combine \u003d body[\u0027combine\u0027]"},{"line_number":100,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()[:]"},{"line_number":101,"context_line":"        self.coverInst.start()"},{"line_number":102,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvYY%3D","line":99,"updated":"2012-11-27 21:13:06.000000000","message":"Should this be cast to a boolean for safety?","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        body \u003d body[\u0027start\u0027]"},{"line_number":97,"context_line":"        self.combine \u003d False"},{"line_number":98,"context_line":"        if \u0027combine\u0027 in body.keys():"},{"line_number":99,"context_line":"            self.combine \u003d body[\u0027combine\u0027]"},{"line_number":100,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()[:]"},{"line_number":101,"context_line":"        self.coverInst.start()"},{"line_number":102,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvUQ%3D","line":99,"in_reply_to":"AAAAMH%2F%2FvYY%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.combine \u003d False"},{"line_number":98,"context_line":"        if \u0027combine\u0027 in body.keys():"},{"line_number":99,"context_line":"            self.combine \u003d body[\u0027combine\u0027]"},{"line_number":100,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()[:]"},{"line_number":101,"context_line":"        self.coverInst.start()"},{"line_number":102,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"},{"line_number":103,"context_line":"        hosts \u003d self._find_services(req)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvYw%3D","line":100,"updated":"2012-11-27 21:13:06.000000000","message":"This is a nit, but I think that list(sys.modules.keys()) might be a bit more conventional.","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.combine \u003d False"},{"line_number":98,"context_line":"        if \u0027combine\u0027 in body.keys():"},{"line_number":99,"context_line":"            self.combine \u003d body[\u0027combine\u0027]"},{"line_number":100,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()[:]"},{"line_number":101,"context_line":"        self.coverInst.start()"},{"line_number":102,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"},{"line_number":103,"context_line":"        hosts \u003d self._find_services(req)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvUM%3D","line":100,"in_reply_to":"AAAAMH%2F%2FvYw%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tn.write(\"output.close()\\n\")"},{"line_number":143,"context_line":"        iocomp \u003d False"},{"line_number":144,"context_line":"        while not os.path.isfile(str(path)):"},{"line_number":145,"context_line":"            time.sleep(1)"},{"line_number":146,"context_line":"        while not iocomp:"},{"line_number":147,"context_line":"            report \u003d open(str(path), \u0027r\u0027)"},{"line_number":148,"context_line":"            lines \u003d report.readlines()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvXw%3D","line":145,"updated":"2012-11-27 21:13:06.000000000","message":"IMHO, this needs to have an escape clause. It\u0027s also rather nasty in that it blocks the entire nova-api service while waiting. I know that this is unlikely to be done on production machines, but it would be good to use something in eventlet if possible, to make this less selfish.","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tn.write(\"output.close()\\n\")"},{"line_number":143,"context_line":"        iocomp \u003d False"},{"line_number":144,"context_line":"        while not os.path.isfile(str(path)):"},{"line_number":145,"context_line":"            time.sleep(1)"},{"line_number":146,"context_line":"        while not iocomp:"},{"line_number":147,"context_line":"            report \u003d open(str(path), \u0027r\u0027)"},{"line_number":148,"context_line":"            lines \u003d report.readlines()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvNc%3D","line":145,"in_reply_to":"AAAAMH%2F%2FvXw%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                if re.match(end, lastline):"},{"line_number":153,"context_line":"                    iocomp \u003d True"},{"line_number":154,"context_line":"            else:"},{"line_number":155,"context_line":"                time.sleep(1)"},{"line_number":156,"context_line":"        tn.close()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _reportCoverage(self, req, body):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvXE%3D","line":155,"updated":"2012-11-27 21:13:06.000000000","message":"Same argument here","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                if re.match(end, lastline):"},{"line_number":153,"context_line":"                    iocomp \u003d True"},{"line_number":154,"context_line":"            else:"},{"line_number":155,"context_line":"                time.sleep(1)"},{"line_number":156,"context_line":"        tn.close()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _reportCoverage(self, req, body):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvQ8%3D","line":155,"in_reply_to":"AAAAMH%2F%2FvXE%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2fcebb94ef3b0c2d0651e9bcec75aaefeaa6f22","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        body \u003d body[\u0027report\u0027]"},{"line_number":164,"context_line":"        if \u0027file\u0027 in body.keys():"},{"line_number":165,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\"No path given for report file\")"},{"line_number":168,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvW4%3D","line":165,"updated":"2012-11-27 21:13:06.000000000","message":"So the web user gets to write to any file on the destination system at the permission level of nova-api? :)","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        body \u003d body[\u0027report\u0027]"},{"line_number":164,"context_line":"        if \u0027file\u0027 in body.keys():"},{"line_number":165,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\"No path given for report file\")"},{"line_number":168,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvUE%3D","line":165,"in_reply_to":"AAAAMH%2F%2FvW4%3D","updated":"2012-11-28 19:42:07.000000000","message":"Yep. Do you have any other ideas? \n\nMy other thought was to make a tmp dir and return the path on the report. But I thought specifying the path in the call was better. \n\nTo be fair I do enforce admin beforehand but there probably is a better way.","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3412faea70e6756bc8ad266e0a36121d7807e8fb","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    name \u003d \"Coverage\""},{"line_number":224,"context_line":"    alias \u003d \"os-coverage\""},{"line_number":225,"context_line":"    namespace \u003d (\"http://docs.openstack.org/compute/ext/\""},{"line_number":226,"context_line":"                  \"coverage/api/v1.1\")"},{"line_number":227,"context_line":"    updated \u003d \"2012-10-15T00:00:00+00:00\""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvX4%3D","line":226,"updated":"2012-11-27 21:03:36.000000000","message":"as this is hanging off the v2 api, it should be a v2 namespace, no?","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9f0fb5f515fc613d25874434d96c4a408059cbe2","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    name \u003d \"Coverage\""},{"line_number":224,"context_line":"    alias \u003d \"os-coverage\""},{"line_number":225,"context_line":"    namespace \u003d (\"http://docs.openstack.org/compute/ext/\""},{"line_number":226,"context_line":"                  \"coverage/api/v1.1\")"},{"line_number":227,"context_line":"    updated \u003d \"2012-10-15T00:00:00+00:00\""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMH%2F%2FvUA%3D","line":226,"in_reply_to":"AAAAMH%2F%2FvX4%3D","updated":"2012-11-28 19:42:07.000000000","message":"Done","commit_id":"4463b1a838ade70b0541d65bb25a3ad285a7041f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"60597e5fcd3144bef36becaba126ceed88ccce30","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        body \u003d body[\u0027report\u0027]"},{"line_number":165,"context_line":"        if \u0027file\u0027 in body.keys():"},{"line_number":166,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            msg \u003d (\"No path given for report file\")"},{"line_number":169,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAMH%2F%2FuEI%3D","line":166,"updated":"2012-11-28 20:05:19.000000000","message":"I\u0027d say: ban any / characters in the path, and join it with your temp directory.","commit_id":"8b8a22c196c08d1b8f6670dbc119059ca4e031eb"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"88753a3c5b2978aeae6799f73c1c816b8dacc817","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        body \u003d body[\u0027report\u0027]"},{"line_number":165,"context_line":"        if \u0027file\u0027 in body.keys():"},{"line_number":166,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            msg \u003d (\"No path given for report file\")"},{"line_number":169,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAMH%2F%2Ft9k%3D","line":166,"in_reply_to":"AAAAMH%2F%2FuEI%3D","updated":"2012-11-28 22:10:59.000000000","message":"Done","commit_id":"8b8a22c196c08d1b8f6670dbc119059ca4e031eb"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"4d6c9acb57b092d6685b6fc353ec0bd886f2cdce","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        path \u003d None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        body \u003d body[\u0027report\u0027]"},{"line_number":166,"context_line":"        if \u0027file\u0027 in body.keys():"},{"line_number":167,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":168,"context_line":"            if \u0027/\u0027 in path:"},{"line_number":169,"context_line":"                msg \u003d (\"Invalid path, contains a /\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAMH%2F%2FsKs%3D","line":166,"updated":"2012-11-30 09:35:38.000000000","message":"minor nit: Is there are reason you can\u0027t just do instead:\n    if \u0027file\u0027 in body:\n(and similar for \u0027xml\u0027 test below)","commit_id":"2943f272238222c04053949c61901dc7d782e634"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e41dffbe037baf3f38b1dcb5f7e7ba8c6bd352fa","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027compute\u0027, \u0027hosts\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CoverageController(object):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAMX%2F%2F%2FGc%3D","line":39,"updated":"2012-12-03 19:11:30.000000000","message":"wrong authorizer.\n\nYou will need to add the correct one to nova/tests/policy.json as well","commit_id":"b02c66eb74f5323771852bce6c13f49e6c77ae38"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"83d8b5125a8d57d5156458f457ed0b3f55f3051b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027compute\u0027, \u0027hosts\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CoverageController(object):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAMX%2F%2F%2FAc%3D","line":39,"in_reply_to":"AAAAMX%2F%2F%2FGc%3D","updated":"2012-12-03 20:41:07.000000000","message":"Done","commit_id":"b02c66eb74f5323771852bce6c13f49e6c77ae38"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from coverage import coverage"},{"line_number":25,"context_line":"import telnetlib"},{"line_number":26,"context_line":"from webob import exc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import common"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B8M%3D","line":25,"updated":"2012-12-03 21:31:31.000000000","message":"it looks like this is part of the stdlib in python so it should be in the first block.","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from coverage import coverage"},{"line_number":25,"context_line":"import telnetlib"},{"line_number":26,"context_line":"from webob import exc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import common"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5s%3D","line":25,"in_reply_to":"AAAAMX%2F%2F%2B8M%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CoverageController(object):"},{"line_number":43,"context_line":"    \u0027\u0027\u0027The Coverage report API controller for the OpenStack API\u0027\u0027\u0027"},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        self.data_path \u003d tempfile.mkdtemp(prefix\u003d\u0027nova-coverage_\u0027)"},{"line_number":46,"context_line":"        data_out \u003d os.path.join(self.data_path, \u0027.nova-coverage\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B8I%3D","line":43,"updated":"2012-12-03 21:31:31.000000000","message":"could you switch the docstrings to \"\"\" from \u0027\u0027\u0027 to be consistent with the rest of the codebase?","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CoverageController(object):"},{"line_number":43,"context_line":"    \u0027\u0027\u0027The Coverage report API controller for the OpenStack API\u0027\u0027\u0027"},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        self.data_path \u003d tempfile.mkdtemp(prefix\u003d\u0027nova-coverage_\u0027)"},{"line_number":46,"context_line":"        data_out \u003d os.path.join(self.data_path, \u0027.nova-coverage\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5o%3D","line":43,"in_reply_to":"AAAAMX%2F%2F%2B8I%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f23cd6e21fbcf178781a38393da6805a17337089","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        super(CoverageController, self).__init__()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __del__(self):"},{"line_number":55,"context_line":"        shutil.rmtree(self.data_path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _find_services(self, req):"},{"line_number":58,"context_line":"        \u0027\u0027\u0027Returns a list of services\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B68%3D","line":55,"updated":"2012-12-03 21:35:00.000000000","message":"This will cause the report output to vanish if nova is stopped, which is highly surprising and unexpected to the user. I vote for filling up /tmp (or some other smart behavior) instead of this.","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        super(CoverageController, self).__init__()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __del__(self):"},{"line_number":55,"context_line":"        shutil.rmtree(self.data_path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _find_services(self, req):"},{"line_number":58,"context_line":"        \u0027\u0027\u0027Returns a list of services\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5k%3D","line":55,"in_reply_to":"AAAAMX%2F%2F%2B68%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        shutil.rmtree(self.data_path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _find_services(self, req):"},{"line_number":58,"context_line":"        \u0027\u0027\u0027Returns a list of services\u0027\u0027\u0027"},{"line_number":59,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":60,"context_line":"        services \u003d db.service_get_all(context, False)"},{"line_number":61,"context_line":"        hosts \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B70%3D","line":58,"updated":"2012-12-03 21:31:31.000000000","message":"ditto","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        shutil.rmtree(self.data_path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _find_services(self, req):"},{"line_number":58,"context_line":"        \u0027\u0027\u0027Returns a list of services\u0027\u0027\u0027"},{"line_number":59,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":60,"context_line":"        services \u003d db.service_get_all(context, False)"},{"line_number":61,"context_line":"        hosts \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5g%3D","line":58,"in_reply_to":"AAAAMX%2F%2F%2B70%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return hosts"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _find_ports(self, req, hosts):"},{"line_number":67,"context_line":"        \u0027\u0027\u0027Return a list of backdoor ports for all services in the list\u0027\u0027\u0027"},{"line_number":68,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        apicommands \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B7w%3D","line":67,"updated":"2012-12-03 21:31:31.000000000","message":"ditto","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return hosts"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _find_ports(self, req, hosts):"},{"line_number":67,"context_line":"        \u0027\u0027\u0027Return a list of backdoor ports for all services in the list\u0027\u0027\u0027"},{"line_number":68,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        apicommands \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5c%3D","line":67,"in_reply_to":"AAAAMX%2F%2F%2B7w%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.combine \u003d bool(body[\u0027combine\u0027])"},{"line_number":112,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()"},{"line_number":113,"context_line":"        self.coverInst.start()"},{"line_number":114,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"},{"line_number":115,"context_line":"        hosts \u003d self._find_services(req)"},{"line_number":116,"context_line":"        ports \u003d self._find_ports(req, hosts)"},{"line_number":117,"context_line":"        self.services \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B7k%3D","line":114,"updated":"2012-12-03 21:31:31.000000000","message":"why authorize here? Seems like it should be done in action","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.combine \u003d bool(body[\u0027combine\u0027])"},{"line_number":112,"context_line":"        self.coverInst.skipModules \u003d sys.modules.keys()"},{"line_number":113,"context_line":"        self.coverInst.start()"},{"line_number":114,"context_line":"        authorize(req.environ[\u0027nova.context\u0027])"},{"line_number":115,"context_line":"        hosts \u003d self._find_services(req)"},{"line_number":116,"context_line":"        ports \u003d self._find_ports(req, hosts)"},{"line_number":117,"context_line":"        self.services \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5Y%3D","line":114,"in_reply_to":"AAAAMX%2F%2F%2B7k%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"28ff6baece573eb22db155740fbd4265d98ca546","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":168,"context_line":"            if \u0027/\u0027 in path:"},{"line_number":169,"context_line":"                msg \u003d (\"Invalid path, contains a /\")"},{"line_number":170,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":171,"context_line":"            path \u003d os.path.join(self.data_path, path)"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            msg \u003d (\"No path given for report file\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B7E%3D","line":170,"updated":"2012-12-03 21:34:43.000000000","message":"this is not a safe way to sanitize the path. maybe something like if path !\u003d os.path.basename(path):","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            path \u003d body[\u0027file\u0027]"},{"line_number":168,"context_line":"            if \u0027/\u0027 in path:"},{"line_number":169,"context_line":"                msg \u003d (\"Invalid path, contains a /\")"},{"line_number":170,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":171,"context_line":"            path \u003d os.path.join(self.data_path, path)"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            msg \u003d (\"No path given for report file\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B5U%3D","line":170,"in_reply_to":"AAAAMX%2F%2F%2B7E%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ad61c439757c060294dba4fadacbe6903ff57d49","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                \u0027stop\u0027: self._stopCoverage,"},{"line_number":211,"context_line":"                \u0027report\u0027: self._reportCoverage,"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        if not req.environ[\u0027nova.context\u0027].is_admin:"},{"line_number":214,"context_line":"            msg \u003d _(\"Coverage actions are admin only functionality\")"},{"line_number":215,"context_line":"            raise exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":216,"context_line":"        for action, data in body.iteritems():"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B7g%3D","line":213,"updated":"2012-12-03 21:31:31.000000000","message":"you should use authorize for this instead of looking for is_admin","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5c85fdca6ad4e7a9669c7021b5b932307bb80510","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                \u0027stop\u0027: self._stopCoverage,"},{"line_number":211,"context_line":"                \u0027report\u0027: self._reportCoverage,"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        if not req.environ[\u0027nova.context\u0027].is_admin:"},{"line_number":214,"context_line":"            msg \u003d _(\"Coverage actions are admin only functionality\")"},{"line_number":215,"context_line":"            raise exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":216,"context_line":"        for action, data in body.iteritems():"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAMX%2F%2F%2B4Y%3D","line":213,"in_reply_to":"AAAAMX%2F%2F%2B7g%3D","updated":"2012-12-03 23:06:30.000000000","message":"Done","commit_id":"3a6d8949570fc56226c7e89aa636248282be36ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"06424952058f85a42c5a9a0bc568efba947ff7c9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                else:"},{"line_number":80,"context_line":"                    _host \u003d host"},{"line_number":81,"context_line":"                    _host[\u0027port\u0027] \u003d get_port_fn(context)"},{"line_number":82,"context_line":"                    ports.append(_host)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                LOG.debug(_(\"No backdoor API command for service: %s\\n\"), host)"},{"line_number":85,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAMX%2F%2F%2BE0%3D","line":82,"updated":"2012-12-04 15:06:38.000000000","message":"You need to pass a host parameter to the network_api call too, otherwise this will only work for systems with a single network host, and will behave unpredictably on systems with more than one.","commit_id":"757698d6a1d45cc5d8f8664260b46317243be932"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"662d09606b9ab87667ef6967d2c6760c276cc95f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                else:"},{"line_number":80,"context_line":"                    _host \u003d host"},{"line_number":81,"context_line":"                    _host[\u0027port\u0027] \u003d get_port_fn(context)"},{"line_number":82,"context_line":"                    ports.append(_host)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                LOG.debug(_(\"No backdoor API command for service: %s\\n\"), host)"},{"line_number":85,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAMX%2F%2F91s%3D","line":82,"in_reply_to":"AAAAMX%2F%2F%2BE0%3D","updated":"2012-12-04 18:58:38.000000000","message":"Done","commit_id":"757698d6a1d45cc5d8f8664260b46317243be932"}],"nova/tests/api/openstack/compute/contrib/test_coverage_ext.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"163754e96aad9614ee7ffc1216991f749ad03928","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":62,"context_line":"        req.headers[\"content-type\"] \u003d \"application/json\""},{"line_number":63,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":64,"context_line":"        self.assertEqual(res.status_int, 200)        "},{"line_number":65,"context_line":"        self.assertTrue(os.path.isfile(\u0027/tmp/coverage-unit-test.report\u0027))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_report_coverage_action_nofile(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALn%2F%2F9l4%3D","line":64,"updated":"2012-10-24 17:48:26.000000000","message":"trailing whitespace","commit_id":"aa1b222a42fe582b12a7089c19e4e5666bc08975"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"163754e96aad9614ee7ffc1216991f749ad03928","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        output \u003d jsonutils.loads(res.body)"},{"line_number":77,"context_line":"        print output"},{"line_number":78,"context_line":"        self.assertEqual(res.status_int, 202)"},{"line_number":79,"context_line":"        "},{"line_number":80,"context_line":"    def test_coverage_bad_body(self):"},{"line_number":81,"context_line":"        body \u003d {}"},{"line_number":82,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/os-coverage/action\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALn%2F%2F9l8%3D","line":79,"updated":"2012-10-24 17:48:26.000000000","message":"trailing whitespace","commit_id":"aa1b222a42fe582b12a7089c19e4e5666bc08975"}]}
