)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"dede0da57eea526739bfebc1d3ec2b3bf9ddc38e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When nova unshelve an instance, it ignores the original state"},{"line_number":10,"context_line":"of the instance before it\u0027s shelved. However, nova allow"},{"line_number":11,"context_line":"paused, suspended, active and stopped instance to be shelved."},{"line_number":12,"context_line":"So this patch handles the SHLEVED state instance return to its"},{"line_number":13,"context_line":"original state when unshelve."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I54ee30d1ae16c7766ebdcb2bde500feddd17f150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_84c1c230","line":12,"updated":"2015-02-20 16:13:31.000000000","message":"/s/SHLEVED/SHELVED","commit_id":"9dcc823effe1d1d846557a2899dbbb7a0d79348e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5b6f545413a42fcfb95908ee3037ee4255315ea8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When nova unshelve an instance, it ignores the original state"},{"line_number":10,"context_line":"of the instance before it\u0027s shelved. However, nova allow"},{"line_number":11,"context_line":"paused, suspended, active and stopped instance to be shelved."},{"line_number":12,"context_line":"So this patch handles the SHLEVED state instance return to its"},{"line_number":13,"context_line":"original state when unshelve."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I54ee30d1ae16c7766ebdcb2bde500feddd17f150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_0947851e","line":12,"in_reply_to":"ba7be1f8_84c1c230","updated":"2015-03-05 11:33:41.000000000","message":"Done","commit_id":"9dcc823effe1d1d846557a2899dbbb7a0d79348e"}],"nova/conductor/manager.py":[{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"f31027c66c239b11056af5a5594a8c816902488d","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                self._delete_image(context, snapshot_id)"},{"line_number":735,"context_line":"            orig_state \u003d sys_meta.get(\u0027shelved_orig_state\u0027)"},{"line_number":736,"context_line":"            if orig_state:"},{"line_number":737,"context_line":"                restore_orig_state(instance, orig_state)"},{"line_number":738,"context_line":"        elif instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":739,"context_line":"            image \u003d None"},{"line_number":740,"context_line":"            image_id \u003d sys_meta.get(\u0027shelved_image_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_a6c47f92","line":737,"updated":"2015-03-13 14:52:04.000000000","message":"You need to move this call to compute/manager.py because \u0027start_instance\u0027 is cast call, and if instance fails to start it will stll try to start/pause/suspend instance.\n\nPlease refer bug : https://bugs.launchpad.net/nova/+bug/1427056\n\nalso you need to do same in case of  \u0027SHELVED_OFFLOADED\u0027 state.","commit_id":"3126d547ec8f3a85af9d47fb83fe6b1a95cb3947"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c32abe42a858d78fac9a8d2dd7f3f21c0016e1ee","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                self._delete_image(context, snapshot_id)"},{"line_number":735,"context_line":"            orig_state \u003d sys_meta.get(\u0027shelved_orig_state\u0027)"},{"line_number":736,"context_line":"            if orig_state:"},{"line_number":737,"context_line":"                restore_orig_state(instance, orig_state)"},{"line_number":738,"context_line":"        elif instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":739,"context_line":"            image \u003d None"},{"line_number":740,"context_line":"            image_id \u003d sys_meta.get(\u0027shelved_image_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_22aa4bd5","line":737,"in_reply_to":"9a80dd14_a6c47f92","updated":"2015-04-30 11:41:24.000000000","message":"I think it can\u0027t be put because we don\u0027t have a chance to \ndo so in compute node \n\nshelve is different to shelve_offload , the instance is still there\nwe only set its state and power off it\n\nif it failed to start, the other operations will not affect \u0027ERROR\u0027 state, right?","commit_id":"3126d547ec8f3a85af9d47fb83fe6b1a95cb3947"}]}