)]}'
{"nova/virt/xenapi/volume_utils.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"042832f9be5516a604e80f719202bb3126b65997","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    volume_info[\u0027id\u0027] \u003d volume_id"},{"line_number":307,"context_line":"    volume_info[\u0027target\u0027] \u003d target_host"},{"line_number":308,"context_line":"    volume_info[\u0027port\u0027] \u003d target_port"},{"line_number":309,"context_line":"    volume_info[\u0027targetIQN\u0027] \u003d target_iqn"},{"line_number":310,"context_line":"    return volume_info"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2Fkk%3D","line":309,"updated":"2012-10-22 19:38:34.000000000","message":"I think removing this is incorrect. The auth_method is still returned in the data blob for iscsi connections. I think it just needs to be extracted from connection_data instead of connection_info","commit_id":"f5ceb1f108b1674c392d2e9783f160d892b69d3a"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"598d30fd4adc5f1cf89b9833732694ecc9061108","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    volume_info[\u0027id\u0027] \u003d volume_id"},{"line_number":307,"context_line":"    volume_info[\u0027target\u0027] \u003d target_host"},{"line_number":308,"context_line":"    volume_info[\u0027port\u0027] \u003d target_port"},{"line_number":309,"context_line":"    volume_info[\u0027targetIQN\u0027] \u003d target_iqn"},{"line_number":310,"context_line":"    return volume_info"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2FGQ%3D","line":309,"in_reply_to":"AAAALn%2F%2F%2Fkk%3D","updated":"2012-10-23 08:50:10.000000000","message":"Thanks, Vish. It was not covered with a test, so I will cover it with one, and put it back, as you suggested.","commit_id":"f5ceb1f108b1674c392d2e9783f160d892b69d3a"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"498cf1acb2b9208eeb71345a7c65e1a26c4c4624","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    volume_info[\u0027port\u0027] \u003d target_port"},{"line_number":309,"context_line":"    volume_info[\u0027targetIQN\u0027] \u003d target_iqn"},{"line_number":310,"context_line":"    if (\u0027auth_method\u0027 in connection_data and"},{"line_number":311,"context_line":"        connection_data[\u0027auth_method\u0027] \u003d\u003d \u0027CHAP\u0027):"},{"line_number":312,"context_line":"        volume_info[\u0027chapuser\u0027] \u003d connection_data[\u0027auth_username\u0027]"},{"line_number":313,"context_line":"        volume_info[\u0027chappassword\u0027] \u003d connection_data[\u0027auth_password\u0027]"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F%2FBA%3D","line":311,"updated":"2012-10-23 13:17:16.000000000","message":"could be\nif connection_data.get(\u0027auth_method\u0027)  \u003d\u003d \u0027CHAP\u0027\nbut the longer version is okay too","commit_id":"1dfdfcef3c3c222f6266132c51db5464dd6ddf8d"}]}