)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c53a1f8140be78ef40063f90c4ce453f1a1b210f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"affected by the bug, they will see the warnings while the RPC API"},{"line_number":24,"context_line":"version cap is in place (i.e. during the upgrade window) and then"},{"line_number":25,"context_line":"the warnings will stop once it is removed."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I5651fb7ba95f38e2e2f8a48a98ff04072c6bb885"},{"line_number":28,"context_line":"Closes-Bug: #1402813"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_9874a4ff","line":26,"updated":"2015-01-12 22:07:35.000000000","message":"I think this warrants a DocImpact or UpgradeImpact or something to bring this to the attention of operators.  As nice as the warning is by the time it is seen it may already be too late.","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f301d2ee1f7fa51f3fdf6583d03c25bb70b0ab78","unresolved":false,"context_lines":[{"line_number":23,"context_line":"affected by the bug, they will see the warnings while the RPC API"},{"line_number":24,"context_line":"version cap is in place (i.e. during the upgrade window) and then"},{"line_number":25,"context_line":"the warnings will stop once it is removed."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I5651fb7ba95f38e2e2f8a48a98ff04072c6bb885"},{"line_number":28,"context_line":"Closes-Bug: #1402813"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_18427468","line":26,"in_reply_to":"3a961159_9874a4ff","updated":"2015-01-12 22:09:55.000000000","message":"Agreed.","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c53a1f8140be78ef40063f90c4ce453f1a1b210f","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        # Since we need to support live migration with older clients, we need"},{"line_number":358,"context_line":"        # to warn the operator of this possibility. The logic below tries to"},{"line_number":359,"context_line":"        # decide if a warning should be emitted, assuming the positive if"},{"line_number":360,"context_line":"        # not clearly unneeded. This can be removed when we bump to RPC API"},{"line_number":361,"context_line":"        # version 4.0."},{"line_number":362,"context_line":"        if data:"},{"line_number":363,"context_line":"            if data.get(\u0027is_shared_block_storage\u0027) is not False:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_58a07c91","line":360,"updated":"2015-01-12 22:07:35.000000000","message":"took me a second to parse this.  s/clearly unneeded/sure/ perhaps?","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f301d2ee1f7fa51f3fdf6583d03c25bb70b0ab78","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        # Since we need to support live migration with older clients, we need"},{"line_number":358,"context_line":"        # to warn the operator of this possibility. The logic below tries to"},{"line_number":359,"context_line":"        # decide if a warning should be emitted, assuming the positive if"},{"line_number":360,"context_line":"        # not clearly unneeded. This can be removed when we bump to RPC API"},{"line_number":361,"context_line":"        # version 4.0."},{"line_number":362,"context_line":"        if data:"},{"line_number":363,"context_line":"            if data.get(\u0027is_shared_block_storage\u0027) is not False:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_98558420","line":360,"in_reply_to":"3a961159_58a07c91","updated":"2015-01-12 22:09:55.000000000","message":"Heh, yeah.","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c53a1f8140be78ef40063f90c4ce453f1a1b210f","unresolved":false,"context_lines":[{"line_number":5011,"context_line":"        dest_check_data[\u0027instance_relative_path\u0027] \u003d instance_path"},{"line_number":5012,"context_line":""},{"line_number":5013,"context_line":"        # NOTE(danms): Emulate this old flag in case we\u0027re talking to"},{"line_number":5014,"context_line":"        # an older client"},{"line_number":5015,"context_line":"        dest_check_data[\u0027is_shared_storage\u0027] \u003d ("},{"line_number":5016,"context_line":"            dest_check_data[\u0027is_shared_instance_path\u0027])"},{"line_number":5017,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_981d84c1","line":5014,"updated":"2015-01-12 22:07:35.000000000","message":"Should there be a note about when this can be removed?","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f301d2ee1f7fa51f3fdf6583d03c25bb70b0ab78","unresolved":false,"context_lines":[{"line_number":5011,"context_line":"        dest_check_data[\u0027instance_relative_path\u0027] \u003d instance_path"},{"line_number":5012,"context_line":""},{"line_number":5013,"context_line":"        # NOTE(danms): Emulate this old flag in case we\u0027re talking to"},{"line_number":5014,"context_line":"        # an older client"},{"line_number":5015,"context_line":"        dest_check_data[\u0027is_shared_storage\u0027] \u003d ("},{"line_number":5016,"context_line":"            dest_check_data[\u0027is_shared_instance_path\u0027])"},{"line_number":5017,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_383e50db","line":5014,"in_reply_to":"3a961159_981d84c1","updated":"2015-01-12 22:09:55.000000000","message":"Sure.","commit_id":"162f9bb470b15d579c080d765e6fb44fd6ff8320"}]}