)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c8d99ae6b75d167a222f07d2bd865edb774497f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compute: pass flavor object to migrate_disk_and_power_off"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the flavor passed to the method is an obejct and contains"},{"line_number":10,"context_line":"the extra_specs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie880a5fb92159b84169f39cf0b1c672fdc053f73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_df8c5631","line":9,"updated":"2015-01-12 20:22:09.000000000","message":"object*","commit_id":"071530cb5be1411fccd16b0c4804d1237cfab28b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d63ae52105361d5568831a2eef735e9f073eff85","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compute: pass flavor object to migrate_disk_and_power_off"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the flavor passed to the method is an obejct and contains"},{"line_number":10,"context_line":"the extra_specs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie880a5fb92159b84169f39cf0b1c672fdc053f73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_8ab6a087","line":9,"in_reply_to":"3a961159_df8c5631","updated":"2015-01-15 11:46:23.000000000","message":"Done","commit_id":"071530cb5be1411fccd16b0c4804d1237cfab28b"}],"nova/compute/manager.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c8d99ae6b75d167a222f07d2bd865edb774497f2","unresolved":false,"context_lines":[{"line_number":3788,"context_line":"            # Code downstream may expect extra_specs to be populated since it"},{"line_number":3789,"context_line":"            # is receiving an object, so lookup the flavor to ensure this."},{"line_number":3790,"context_line":"            if (not instance_type or"},{"line_number":3791,"context_line":"                not isinstance(instance_type, objects.Flavor)):"},{"line_number":3792,"context_line":"                instance_type \u003d objects.Flavor.get_by_id("},{"line_number":3793,"context_line":"                    context, migration[\u0027new_instance_type_id\u0027])"},{"line_number":3794,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_bf1a2ac4","line":3791,"updated":"2015-01-12 20:22:09.000000000","message":"so, I suppose instance_type can\u0027t be a dict? Because if it is, it can already be populated, doing one extra useless call.\n\nAlso, you say in the comment that it may expect extra_specs. Why not just check if the extra_specs exists instead?","commit_id":"071530cb5be1411fccd16b0c4804d1237cfab28b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d63ae52105361d5568831a2eef735e9f073eff85","unresolved":false,"context_lines":[{"line_number":3788,"context_line":"            # Code downstream may expect extra_specs to be populated since it"},{"line_number":3789,"context_line":"            # is receiving an object, so lookup the flavor to ensure this."},{"line_number":3790,"context_line":"            if (not instance_type or"},{"line_number":3791,"context_line":"                not isinstance(instance_type, objects.Flavor)):"},{"line_number":3792,"context_line":"                instance_type \u003d objects.Flavor.get_by_id("},{"line_number":3793,"context_line":"                    context, migration[\u0027new_instance_type_id\u0027])"},{"line_number":3794,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ca59885c","line":3791,"in_reply_to":"3a961159_bf1a2ac4","updated":"2015-01-15 11:46:23.000000000","message":"There are two issues here:\n1. the code in the driver expects an object type. we could rewrite\n2. the extra specs may not be passed as they original dict did not have these values populated. The extra specs will exist, but may not be populated with the flavor extraspec details\n\ni think that until we fix the code for actually passing the object (which I am investigating) this should suffice","commit_id":"071530cb5be1411fccd16b0c4804d1237cfab28b"}]}