)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements one workitem of blueprint apis-for-nova-manage"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This add an optional QUEY_STRING(zone\u003dxxx) in /v1.1/{tenant_id}/os-hosts."},{"line_number":12,"context_line":"So we can also send /v1.1/{tenant_id}/os-hosts?zone\u003d?zone\u003dxxx now."},{"line_number":13,"context_line":"It will only return the hosts that availability_zone\u003dxxx."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I89f2c0bf50f8ea1ef9f06da664f5c4b24098e5df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAALn%2F%2F9uc%3D","line":12,"updated":"2012-10-24 15:58:18.000000000","message":"femtonit: \"?zone\u003d?zone\u003d\" looks like an accidental repeat; you probably meant to have just a single \"?zone\u003d\" there…","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"6e1e62c5ca1930ad6bc8775c1abe08fcfbacc9b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements one workitem of blueprint apis-for-nova-manage"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This add an optional QUEY_STRING(zone\u003dxxx) in /v1.1/{tenant_id}/os-hosts."},{"line_number":12,"context_line":"So we can also send /v1.1/{tenant_id}/os-hosts?zone\u003d?zone\u003dxxx now."},{"line_number":13,"context_line":"It will only return the hosts that availability_zone\u003dxxx."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I89f2c0bf50f8ea1ef9f06da664f5c4b24098e5df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAALn%2F%2F87I%3D","line":12,"in_reply_to":"AAAALn%2F%2F9uc%3D","updated":"2012-10-25 03:28:51.000000000","message":"Yes, it\u0027s just an accidental repeat. Thank you for your review, I will update it","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"}],"nova/api/openstack/compute/contrib/hosts.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":99,"context_line":"    services \u003d db.service_get_all(context, False)"},{"line_number":100,"context_line":"    zone \u003d \u0027\u0027"},{"line_number":101,"context_line":"    if \u0027zone\u0027 in req.GET:"},{"line_number":102,"context_line":"        zone \u003d req.GET[\u0027zone\u0027]"},{"line_number":103,"context_line":"    if zone:"},{"line_number":104,"context_line":"        services \u003d [s for s in services if s[\u0027availability_zone\u0027] \u003d\u003d zone]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F9xY%3D","line":101,"updated":"2012-10-24 15:20:03.000000000","message":"This appears to be incorrect.","commit_id":"e6f97ae62efc3150d0c2a836a19c446f66730e72"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        services \u003d [s for s in services if s[\u0027availability_zone\u0027] \u003d\u003d zone]"},{"line_number":105,"context_line":"    hosts \u003d []"},{"line_number":106,"context_line":"    for host in services:"},{"line_number":107,"context_line":"        hosts.append({\"host_name\": host[\u0027host\u0027], \u0027service\u0027: host[\u0027topic\u0027], "},{"line_number":108,"context_line":"                      \u0027zone\u0027: host[\u0027availability_zone\u0027]})"},{"line_number":109,"context_line":"    if service:"},{"line_number":110,"context_line":"        hosts \u003d [host for host in hosts"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F9xg%3D","line":107,"updated":"2012-10-24 15:20:03.000000000","message":"Trailing whitespace","commit_id":"e6f97ae62efc3150d0c2a836a19c446f66730e72"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from nova import exception"},{"line_number":28,"context_line":"from nova import flags"},{"line_number":29,"context_line":"from nova.openstack.common import log as logging"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":33,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027compute\u0027, \u0027hosts\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F9uY%3D","line":30,"updated":"2012-10-24 15:58:18.000000000","message":"Just out of curiosity, is there a reason you deleted this line?  It\u0027s not a big deal either way…","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if \u0027zone\u0027 in req.GET:"},{"line_number":102,"context_line":"        zone \u003d req.GET[\u0027zone\u0027]"},{"line_number":103,"context_line":"    if zone:"},{"line_number":104,"context_line":"        services \u003d [s for s in services if s[\u0027availability_zone\u0027] \u003d\u003d zone]"},{"line_number":105,"context_line":"    hosts \u003d []"},{"line_number":106,"context_line":"    for host in services:"},{"line_number":107,"context_line":"        hosts.append({\"host_name\": host[\u0027host\u0027], \u0027service\u0027: host[\u0027topic\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F9uI%3D","line":104,"updated":"2012-10-24 15:58:18.000000000","message":"This makes me wonder if there\u0027s future work that needs to be done to the db.service_*() suite…","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"6e1e62c5ca1930ad6bc8775c1abe08fcfbacc9b1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if \u0027zone\u0027 in req.GET:"},{"line_number":102,"context_line":"        zone \u003d req.GET[\u0027zone\u0027]"},{"line_number":103,"context_line":"    if zone:"},{"line_number":104,"context_line":"        services \u003d [s for s in services if s[\u0027availability_zone\u0027] \u003d\u003d zone]"},{"line_number":105,"context_line":"    hosts \u003d []"},{"line_number":106,"context_line":"    for host in services:"},{"line_number":107,"context_line":"        hosts.append({\"host_name\": host[\u0027host\u0027], \u0027service\u0027: host[\u0027topic\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F860%3D","line":104,"in_reply_to":"AAAALn%2F%2F9uI%3D","updated":"2012-10-25 03:28:51.000000000","message":"I don\u0027t think so.","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"44315129793d60e53f53b3006da5578d6f3c4392","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if \u0027zone\u0027 in req.GET:"},{"line_number":103,"context_line":"        zone \u003d req.GET[\u0027zone\u0027]"},{"line_number":104,"context_line":"    if zone:"},{"line_number":105,"context_line":"        services \u003d [s for s in services if s[\u0027availability_zone\u0027] \u003d\u003d zone]"},{"line_number":106,"context_line":"    hosts \u003d []"},{"line_number":107,"context_line":"    for host in services:"},{"line_number":108,"context_line":"        hosts.append({\"host_name\": host[\u0027host\u0027], \u0027service\u0027: host[\u0027topic\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F8k4%3D","line":105,"updated":"2012-10-25 15:18:50.000000000","message":"It would be good to try to do this filtering in the database, which is why I commented that future work on the db.service_*() calls might be indicated.  For now, this is fine, though…","commit_id":"d9c95e4c8bb0a2d9d7f73600d82bfd32318c37a6"}],"nova/tests/api/openstack/compute/contrib/test_hosts.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"746f15e5f139f63f872c4fe04675fbe0ded1325b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertEqual(hosts, HOST_LIST)"},{"line_number":136,"context_line":"        req \u003d FakeRequestWithNovaZone()"},{"line_number":137,"context_line":"        hosts \u003d os_hosts._list_hosts(req)"},{"line_number":138,"context_line":"        self.assertEqual(hosts, HOST_LIST_NOVA_ZONE)"},{"line_number":139,"context_line":"        compute_hosts \u003d os_hosts._list_hosts(self.req, \"compute\")"},{"line_number":140,"context_line":"        expected \u003d [host for host in HOST_LIST"},{"line_number":141,"context_line":"                if host[\"service\"] \u003d\u003d \"compute\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F9t0%3D","line":138,"updated":"2012-10-24 15:58:18.000000000","message":"I\u0027d really rather you split this out into a separate test function; that is, leave test_list_hosts() alone but add a test_list_hosts_with_zone() that has this specific test.  In general, we want to try to have unit tests test exactly one piece of functionality, so that if a test fails, it\u0027s a little easier to determine exactly what it failed on.\n\nFor now, I\u0027ll consider this a style nit, but if you push another change up, please make sure to separate the tests as outlined above.","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"6e1e62c5ca1930ad6bc8775c1abe08fcfbacc9b1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertEqual(hosts, HOST_LIST)"},{"line_number":136,"context_line":"        req \u003d FakeRequestWithNovaZone()"},{"line_number":137,"context_line":"        hosts \u003d os_hosts._list_hosts(req)"},{"line_number":138,"context_line":"        self.assertEqual(hosts, HOST_LIST_NOVA_ZONE)"},{"line_number":139,"context_line":"        compute_hosts \u003d os_hosts._list_hosts(self.req, \"compute\")"},{"line_number":140,"context_line":"        expected \u003d [host for host in HOST_LIST"},{"line_number":141,"context_line":"                if host[\"service\"] \u003d\u003d \"compute\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F86o%3D","line":138,"in_reply_to":"AAAALn%2F%2F9t0%3D","updated":"2012-10-25 03:28:51.000000000","message":"It\u0027s a good suggestion. I will update it. Thank you for your comment.","commit_id":"bb346f14027fb504c7182f073dc86158531d6c9b"}]}