)]}'
{"nova/test.py":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"1e8fa40a034e8826635719a009ccddc87e6d8dc1","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        CONF.set_override(\u0027force_dhcp_release\u0027, False)"},{"line_number":325,"context_line":"        CONF.set_override(\u0027periodic_enable\u0027, False)"},{"line_number":326,"context_line":"        # We don\u0027t need to kill ourselves in deprecation floods. Give"},{"line_number":327,"context_line":"        # me a ping, Vasily. One ping only, please."},{"line_number":328,"context_line":"        warnings.simplefilter(\"once\", DeprecationWarning)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _restore_obj_registry(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cc6360db","line":327,"updated":"2015-01-15 13:52:27.000000000","message":"@sdague is that Vasily the sniper? :)\nLess poetic master comment, for reference:\n # NOTE(sdague): Make deprecation warnings only happen once. Otherwise\n # this gets kind of crazy given the way that upstream python libs use\n # this.","commit_id":"9ee1a0f5756eec1c4ba42bd823b61b09c58e23fa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"487250571f566ee507e736d4b97b7122f12fefba","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        CONF.set_override(\u0027periodic_enable\u0027, False)"},{"line_number":326,"context_line":"        # We don\u0027t need to kill ourselves in deprecation floods. Give"},{"line_number":327,"context_line":"        # me a ping, Vasily. One ping only, please."},{"line_number":328,"context_line":"        warnings.simplefilter(\"once\", DeprecationWarning)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _restore_obj_registry(self):"},{"line_number":331,"context_line":"        objects_base.NovaObject._obj_classes \u003d self._base_test_obj_backup"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_fba7f4a5","line":328,"updated":"2015-01-15 12:48:04.000000000","message":"Should we addCleanup as in master?","commit_id":"9ee1a0f5756eec1c4ba42bd823b61b09c58e23fa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3d9c26c51b746a6d6543dd89ae0974a2b3eb968f","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        CONF.set_override(\u0027periodic_enable\u0027, False)"},{"line_number":326,"context_line":"        # We don\u0027t need to kill ourselves in deprecation floods. Give"},{"line_number":327,"context_line":"        # me a ping, Vasily. One ping only, please."},{"line_number":328,"context_line":"        warnings.simplefilter(\"once\", DeprecationWarning)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _restore_obj_registry(self):"},{"line_number":331,"context_line":"        objects_base.NovaObject._obj_classes \u003d self._base_test_obj_backup"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_fb00d404","line":328,"in_reply_to":"3a961159_fba7f4a5","updated":"2015-01-15 13:02:42.000000000","message":"OK, talking to Sean in IRC... So cleanup is actually wrong in master since we blow up all previous settings instead of restoring them. Since it\u0027s a memory only setting that goes away after test execution, I\u0027m fine with leaving it off.","commit_id":"9ee1a0f5756eec1c4ba42bd823b61b09c58e23fa"}]}
