)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"c772b3bc4d44bf3cdaaceafb9604c561fac6da40","unresolved":false,"context_lines":[{"line_number":857,"context_line":"                context, instance, \"shutdown.start\")"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"            self.network_api.deallocate_for_instance(context.elevated(),"},{"line_number":860,"context_line":"                    instance)"},{"line_number":861,"context_line":"            self.db.instance_destroy(context, instance_uuid)"},{"line_number":862,"context_line":"            system_meta \u003d self.db.instance_system_metadata_get(context,"},{"line_number":863,"context_line":"                    instance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7zU%3D","line":860,"updated":"2012-10-26 06:13:52.000000000","message":"If in multi_host, if \u0027compute\u0027 service is dead, \u0027network\u0027 must be dead too. So can not deallocate the network for the instance.\nIn my option,we need to check if \u0027network\u0027 service is alive first. If \u0027network\u0027 is alive, send rpc request to it. if not, just deallocate fixed ip or floating ip from database.","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"da12af3bf1890494f3117db8cfad18280db7d4c5","unresolved":false,"context_lines":[{"line_number":857,"context_line":"                context, instance, \"shutdown.start\")"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"            self.network_api.deallocate_for_instance(context.elevated(),"},{"line_number":860,"context_line":"                    instance)"},{"line_number":861,"context_line":"            self.db.instance_destroy(context, instance_uuid)"},{"line_number":862,"context_line":"            system_meta \u003d self.db.instance_system_metadata_get(context,"},{"line_number":863,"context_line":"                    instance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F68o%3D","line":860,"in_reply_to":"AAAALn%2F%2F7zU%3D","updated":"2012-10-26 23:06:18.000000000","message":"when doing the network_api command, is the message sent to a specific host or just sent to the network topic for any nova-network to consume?  I only found code that sends the RPC to the network topic.","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"c772b3bc4d44bf3cdaaceafb9604c561fac6da40","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            self.network_api.deallocate_for_instance(context.elevated(),"},{"line_number":860,"context_line":"                    instance)"},{"line_number":861,"context_line":"            self.db.instance_destroy(context, instance_uuid)"},{"line_number":862,"context_line":"            system_meta \u003d self.db.instance_system_metadata_get(context,"},{"line_number":863,"context_line":"                    instance_uuid)"},{"line_number":864,"context_line":"            # cleanup volumes"},{"line_number":865,"context_line":"            for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7zc%3D","line":862,"updated":"2012-10-26 06:13:52.000000000","message":"I think you may want to call instance_metadata_delete?\nOr use system_meta for what?","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"da12af3bf1890494f3117db8cfad18280db7d4c5","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            self.network_api.deallocate_for_instance(context.elevated(),"},{"line_number":860,"context_line":"                    instance)"},{"line_number":861,"context_line":"            self.db.instance_destroy(context, instance_uuid)"},{"line_number":862,"context_line":"            system_meta \u003d self.db.instance_system_metadata_get(context,"},{"line_number":863,"context_line":"                    instance_uuid)"},{"line_number":864,"context_line":"            # cleanup volumes"},{"line_number":865,"context_line":"            for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7Dc%3D","line":862,"in_reply_to":"AAAALn%2F%2F7zc%3D","updated":"2012-10-26 23:06:18.000000000","message":"This should of been used in the notify_usage","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"}],"nova/network/manager.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"cbab82ec8c9096ebca076b2f206d12da426d7b8c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        else:"},{"line_number":233,"context_line":"            # i am the correct host, run here"},{"line_number":234,"context_line":"            super(RPCAllocateFixedIP, self).deallocate_fixed_ip(context,"},{"line_number":235,"context_line":"                                                                address)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def wrap_check_policy(func):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5io%3D","line":235,"updated":"2012-10-29 22:28:53.000000000","message":"i think we may need to try: except the deallocate_fixed_ip in the case that the host is down. I expect that the call might fail when we update dnsmasq etc.\n\nThis really needs to be manually tested.","commit_id":"7d988d541d08b44bc7de72eaaebe3e27fdb5f582"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"cbab82ec8c9096ebca076b2f206d12da426d7b8c","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                    context, instance[\u0027host\u0027], \u0027network\u0027)):"},{"line_number":588,"context_line":"                host \u003d instance[\u0027host\u0027]"},{"line_number":589,"context_line":"            else:"},{"line_number":590,"context_line":"                host \u003d network[\u0027host\u0027]"},{"line_number":591,"context_line":"        else:"},{"line_number":592,"context_line":"            host \u003d network[\u0027host\u0027]"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5ik%3D","line":590,"updated":"2012-10-29 22:28:53.000000000","message":"network_host is none in multi_host, so i think you either want:\n\n  host \u003d self.host\n  # some logic to skip the driver part of the _disassocate call\n\nor just create a new call _disassociate_floating_ip:\n\n   return _disassociate_floating_ip_local()\n\ndef _disassociate_floating_ip_local(...):\n\n   fixed_address \u003d self.db.floating_ip_disassociate(context, address)\n  payload \u003d dict(project_id\u003dcontext.project_id, floating_ip\u003daddress)\n  notifier.notify(context, ...)","commit_id":"7d988d541d08b44bc7de72eaaebe3e27fdb5f582"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"cbab82ec8c9096ebca076b2f206d12da426d7b8c","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        fixed_address \u003d self.db.floating_ip_disassociate(context, address)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        # go go driver time"},{"line_number":609,"context_line":"        self.l3driver.remove_floating_ip(address, fixed_address, interface)"},{"line_number":610,"context_line":"        payload \u003d dict(project_id\u003dcontext.project_id, floating_ip\u003daddress)"},{"line_number":611,"context_line":"        notifier.notify(context,"},{"line_number":612,"context_line":"                        notifier.publisher_id(\"network\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5ic%3D","line":609,"updated":"2012-10-29 22:28:53.000000000","message":"the driver call should be skipped in the case that we are deallocating locally.","commit_id":"7d988d541d08b44bc7de72eaaebe3e27fdb5f582"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2ae17dd1c6ae7b6763329472883987bc6890a279","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"        self.assertRaises(exception.InstanceNotFound, db.instance_destroy,"},{"line_number":3120,"context_line":"                self.context,"},{"line_number":3121,"context_line":"                instance[\u0027uuid\u0027])"},{"line_number":3122,"context_line":""},{"line_number":3123,"context_line":"    def test_delete_in_resized(self):"},{"line_number":3124,"context_line":"        instance, instance_uuid \u003d self._run_instance(params\u003d{"},{"line_number":3125,"context_line":"                \u0027host\u0027: FLAGS.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7%2Bk%3D","line":3122,"updated":"2012-10-26 00:17:51.000000000","message":"Can you assert that there were fixed ips attached and that after the delete, they are removed?","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"da12af3bf1890494f3117db8cfad18280db7d4c5","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"        self.assertRaises(exception.InstanceNotFound, db.instance_destroy,"},{"line_number":3120,"context_line":"                self.context,"},{"line_number":3121,"context_line":"                instance[\u0027uuid\u0027])"},{"line_number":3122,"context_line":""},{"line_number":3123,"context_line":"    def test_delete_in_resized(self):"},{"line_number":3124,"context_line":"        instance, instance_uuid \u003d self._run_instance(params\u003d{"},{"line_number":3125,"context_line":"                \u0027host\u0027: FLAGS.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7Bg%3D","line":3122,"in_reply_to":"AAAALn%2F%2F7%2Bk%3D","updated":"2012-10-26 23:06:18.000000000","message":"I asserted that the network_api is called.  Is that enough?","commit_id":"08439c0a8aeb99e9c4c54087c10d0a05a26c9e66"}]}