)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"543a764b1f31d3fa57c86f3be09af05904cfe6ef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make vmware driver decode special character in cluster name."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the cluster name has special character like \"/\", nova-compute will fail to"},{"line_number":10,"context_line":"retrieve cluster object from VCenter. This change decode the special character"},{"line_number":11,"context_line":"in URI path of the cluster name returned by VSphere API, so that it can make"},{"line_number":12,"context_line":"vmware driver support cluster name like \"cluster/01\" defined in nova.conf"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aca2d91_3141890c","line":10,"updated":"2015-05-06 13:44:57.000000000","message":"I do not think that this is the correct approach. I think that we should validate this at startup and if necessary normalize the cluster name - that is cluster/01 should be updated to cluster%2f01","commit_id":"68b667a5bb47c7fdb30d08ce9c839b34371849ef"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"e55bcb311f3a09062fd2b29db981ea56b0f6d21c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make vmware driver decode special character in cluster name."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the cluster name has special character like \"/\", nova-compute will fail to"},{"line_number":10,"context_line":"retrieve cluster object from VCenter. This change decode the special character"},{"line_number":11,"context_line":"in URI path of the cluster name returned by VSphere API, so that it can make"},{"line_number":12,"context_line":"vmware driver support cluster name like \"cluster/01\" defined in nova.conf"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_0fdebfdc","line":10,"in_reply_to":"1aca2d91_3141890c","updated":"2015-06-01 08:22:02.000000000","message":"Thanks, Gary.\nI tried your suggestion, by trying to translate cluster/01 into cluster%2f01 at driver startup.\nBut unfortunately, urlib.quote will translate cluster/01 into \"cluster%2F01\"(%2F is in upper case), but not \"cluster%2f01\"(%2f is in lower case). But the value returned by vSphere api is \"cluster%2f01\".\nGary, do you know how to solve this?","commit_id":"68b667a5bb47c7fdb30d08ce9c839b34371849ef"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ba5d44ee5e78be7ad052cfcc9db7f5f25f648cdf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make vmware driver decode special character in cluster name."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the cluster name has special character like \"/\", nova-compute will fail to"},{"line_number":10,"context_line":"retrieve cluster object from VCenter. This change decode the special character"},{"line_number":11,"context_line":"in URI path of the cluster name returned by VSphere API, so that it can make"},{"line_number":12,"context_line":"vmware driver support cluster name like \"cluster/01\" defined in nova.conf"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_81339e13","line":10,"in_reply_to":"7a016987_0fdebfdc","updated":"2015-06-01 11:51:24.000000000","message":"you could try: urllib.quote_plus(urllib.unquote_plus())","commit_id":"68b667a5bb47c7fdb30d08ce9c839b34371849ef"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"7a60bdbfe672024fc843c9c2f614cd217b408480","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make vmware driver decode special character in cluster name."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the cluster name has special character like \"/\", nova-compute will fail to"},{"line_number":10,"context_line":"retrieve cluster object from VCenter. This change decode the special character"},{"line_number":11,"context_line":"in URI path of the cluster name returned by VSphere API, so that it can make"},{"line_number":12,"context_line":"vmware driver support cluster name like \"cluster/01\" defined in nova.conf"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5afe65bd_2704c07c","line":10,"in_reply_to":"7a016987_81339e13","updated":"2015-06-02 01:29:57.000000000","message":"\u003e\u003e\u003e urllib.quote_plus(urllib.unquote_plus(\"cluster/01\"))\n\n\n\u0027cluster%2F01\u0027       \n\n\nSeems it does not make any difference.","commit_id":"68b667a5bb47c7fdb30d08ce9c839b34371849ef"}]}
