)]}'
{"id":"openstack%2Fnova~14907","triplet_id":"openstack%2Fnova~master~Iab666fcd04a9aaa3a490737a173ee3189b9b8329","project":"openstack/nova","branch":"master","topic":"bug/1071849","hashtags":[],"change_id":"Iab666fcd04a9aaa3a490737a173ee3189b9b8329","subject":"Fix hacking.py naivete regarding lines that look like imports","status":"MERGED","created":"2012-10-26 18:42:15.000000000","updated":"2012-10-26 20:45:05.000000000","submitted":"2012-10-26 19:52:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f69af4ac1fb7e65b717a0f836bfd38f182c3667e","_number":14907,"virtual_id_number":14907,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2012-10-26 19:13:18.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2012-10-26 19:52:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"recommended":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"all":[{"value":1,"date":"2012-10-26 18:46:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2012-10-26 19:14:58.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2012-10-26 19:32:24.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-10-26 19:30:58.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2012-10-26 19:14:58.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-10-26 19:30:58.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-10-26 18:42:43.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-26 18:42:43.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2012-10-26 18:46:23.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2012-10-26 19:13:18.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-10-26 19:14:58.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2012-10-26 19:30:58.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-10-26 19:52:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2549a1fd84a38e6646367b84d23c6dc73ee2f751","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-10-26 18:46:23.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nLgtm, working on a better fix for this problem.  But this is  a good first step","accounts_in_message":[],"_revision_number":1},{"id":"8a54664158d6ef7a9e6edd270d48cdc61973ce8d","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-10-26 19:13:18.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/42002\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/42000\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/42001\n","accounts_in_message":[],"_revision_number":1},{"id":"3910ce36e4154bf1ca61d4f306d1790f3298f7e5","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-10-26 19:14:58.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0378a40fadc72828a82e2ffdd9f130b4ce8141ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-26 19:16:50.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14907/1/check/gate-nova-merge/10576 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-nova-docs/6328 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-nova-pep8/11638 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-nova-python26/7781 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-nova-python27/7848 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-tempest-devstack-vm/15738 : SUCCESS\n- http://logs.openstack.org/14907/1/check/gate-nova-pylint/1963 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"55595b928a5be513f16c153278560d4d5165172f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-10-26 19:30:58.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nSo, what got you—a \u0027from\u0027 at the beginning of a docstring?","accounts_in_message":[],"_revision_number":1},{"id":"0aae5788a97b744473b21830126e49bfc21b9a19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-26 19:31:08.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"9fc5124a1e56008873a8e273a7ffdfb2cdb100b5","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-10-26 19:32:24.000000000","message":"Patch Set 1:\n\nYep, kudos to Clark for spotting it before I could even rectify my local pep8 install :)","accounts_in_message":[],"_revision_number":1},{"id":"09639a5b8cd691f4efb261231b3e7f64d5e5ddb9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-26 19:52:59.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14907/1/gate/gate-nova-merge/10579 : SUCCESS\n- http://logs.openstack.org/14907/1/gate/gate-nova-docs/6331 : SUCCESS\n- http://logs.openstack.org/14907/1/gate/gate-nova-pep8/11641 : SUCCESS\n- http://logs.openstack.org/14907/1/gate/gate-nova-python26/7784 : SUCCESS\n- http://logs.openstack.org/14907/1/gate/gate-nova-python27/7851 : SUCCESS\n- http://logs.openstack.org/14907/1/gate/gate-tempest-devstack-vm/15745 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"76acdf5351c7dd1fcfe2982f17b6c6d1615f6057","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-26 19:53:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"eaf6075e1ece6b810698ca89e83a04fcd858e1cc","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-10-26 20:45:05.000000000","message":"Patch Set 1:\n\nBetter solution (don\u0027t run the test on comments): https://review.openstack.org/14916","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88f252a3d4209c7912f6ff36a6f703ef38f2546b","revisions":{"88f252a3d4209c7912f6ff36a6f703ef38f2546b":{"kind":"REWORK","_number":1,"created":"2012-10-26 18:42:15.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/07/14907/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/14907/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/14907/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/14907/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/14907/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/14907/1"}}},"commit":{"parents":[{"commit":"50a0f3efb6cc4ae9c94439eea346828d35080d6c","subject":"Save exceptions earlier in finish_resize","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/50a0f3efb6cc4ae9c94439eea346828d35080d6c"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-10-26 18:39:46.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-10-26 18:39:46.000000000","tz":-420},"subject":"Fix hacking.py naivete regarding lines that look like imports","message":"Fix hacking.py naivete regarding lines that look like imports\n\nRight now, any line that starts with \"from\" (after whitespace\nremoval) is considered an import line. That assumption leads to\nsome unsavory parsing and crashing if the line doesn\u0027t match\nthe expected format.\n\nThis patch checks to make sure that the word \"import\" is in the line\nas well as starting with \"from\", which at least gets us a bit closer\nto a reasonable assumption.\n\nFixes bug 1071849\n\nChange-Id: Iab666fcd04a9aaa3a490737a173ee3189b9b8329\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88f252a3d4209c7912f6ff36a6f703ef38f2546b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88f252a3d4209c7912f6ff36a6f703ef38f2546b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"50a0f3efb6cc4ae9c94439eea346828d35080d6c","is_merged_in_target_branch":true,"change_id":"I50cb4879f7dcc13f99fa23a45030b4140dfc326a","change_number":14870,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}