)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib1aafce6ddc04cb7774e6b4921c9dbfcc25acc91"},{"line_number":20,"context_line":"Partially Implements: blueprint vmware-console-log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a50d1a3_c5a462a7","line":20,"updated":"2015-07-28 15:56:54.000000000","message":"This blueprint was marked as NeedsCodeReview, but this is the only patch up for review.\n\nIs there a plan on when the rest will get up to review, or do you want this bit merged first? It doesn\u0027t seem to deliver something to the nova end user.","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"627d8686db8588df606d681ebce57562930fdcdd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"def create_serial_port_spec(client_factory):"},{"line_number":231,"context_line":"    \"\"\"Creates config spec for serial port.\"\"\""},{"line_number":232,"context_line":"    if not CONF.vmware.serial_port_service_uri:"},{"line_number":233,"context_line":"        return None"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    backing \u003d client_factory.create(\u0027ns0:VirtualSerialPortURIBackingInfo\u0027)"},{"line_number":236,"context_line":"    backing.direction \u003d \"server\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3c3bbbec","line":233,"updated":"2015-02-09 13:37:42.000000000","message":"you can just do return. None is returned by default","commit_id":"c1747e3e158763bb6dd9e0bc88b5eed537388830"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def get_vm_boot_spec(client_factory, device):"},{"line_number":275,"context_line":"    \"\"\"Returns updated boot settings for the instance."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    The boot order for the instance will be changed to have the"},{"line_number":278,"context_line":"    input device as the boot disk."},{"line_number":279,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_a5b83612","side":"PARENT","line":276,"updated":"2015-07-28 15:56:54.000000000","message":"micro nit: this change shouldn\u0027t be part of this patch, but I will not block it on that.","commit_id":"a625ef75c2ababde25decb6ca11ed59184c1b110"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def get_vm_boot_spec(client_factory, device):"},{"line_number":275,"context_line":"    \"\"\"Returns updated boot settings for the instance."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    The boot order for the instance will be changed to have the"},{"line_number":278,"context_line":"    input device as the boot disk."},{"line_number":279,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_2769aabe","side":"PARENT","line":276,"in_reply_to":"3a50d1a3_a5b83612","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"a625ef75c2ababde25decb6ca11ed59184c1b110"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027console_delay_seconds\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Set this value if affected by an increased network \u0027"},{"line_number":47,"context_line":"                    \u0027latency causing repeated characters when typing in \u0027"},{"line_number":48,"context_line":"                    \u0027a remote console.\u0027)"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_8248905d","line":48,"updated":"2015-07-28 15:56:54.000000000","message":"Why did the config options not go here?","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027console_delay_seconds\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Set this value if affected by an increased network \u0027"},{"line_number":47,"context_line":"                    \u0027latency causing repeated characters when typing in \u0027"},{"line_number":48,"context_line":"                    \u0027a remote console.\u0027)"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_e75e6212","line":48,"in_reply_to":"3a50d1a3_8248905d","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bacc19c58db6ccd2757757b100c3024f85891de1","unresolved":false,"context_lines":[{"line_number":276,"context_line":"def create_serial_port_spec(client_factory):"},{"line_number":277,"context_line":"    \"\"\"Creates config spec for serial port.\"\"\""},{"line_number":278,"context_line":"    if not CONF.vmware.serial_port_service_uri:"},{"line_number":279,"context_line":"        return None"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    backing \u003d client_factory.create(\u0027ns0:VirtualSerialPortURIBackingInfo\u0027)"},{"line_number":282,"context_line":"    backing.direction \u003d \"server\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_9cc17a83","line":279,"updated":"2015-07-19 16:35:28.000000000","message":"you do not need to explicitly return None. By default None is returned","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"def create_serial_port_spec(client_factory):"},{"line_number":277,"context_line":"    \"\"\"Creates config spec for serial port.\"\"\""},{"line_number":278,"context_line":"    if not CONF.vmware.serial_port_service_uri:"},{"line_number":279,"context_line":"        return None"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    backing \u003d client_factory.create(\u0027ns0:VirtualSerialPortURIBackingInfo\u0027)"},{"line_number":282,"context_line":"    backing.direction \u003d \"server\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_273bead2","line":279,"in_reply_to":"3a50d1a3_9cc17a83","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    \u0027be shared between compute nodes. Note: this should only \u0027"},{"line_number":67,"context_line":"                    \u0027be used when the compute nodes have a shared file \u0027"},{"line_number":68,"context_line":"                    \u0027system.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027Identifies the remote system that serial port traffic \u0027"},{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_85009aac","line":69,"updated":"2015-07-28 15:56:54.000000000","message":"to be consistent feels like these should live in vm_utils.py\n\nAlthough I know we are looking at changing that longer term, it feels better to be locally consistent.","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    \u0027be shared between compute nodes. Note: this should only \u0027"},{"line_number":67,"context_line":"                    \u0027be used when the compute nodes have a shared file \u0027"},{"line_number":68,"context_line":"                    \u0027system.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027Identifies the remote system that serial port traffic \u0027"},{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_075cae17","line":69,"in_reply_to":"3a50d1a3_85009aac","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    \u0027system.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027Identifies the remote system that serial port traffic \u0027"},{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":73,"context_line":"               help\u003d\u0027Identifies a proxy service that provides network access \u0027"},{"line_number":74,"context_line":"                    \u0027to the serial_port_service_uri.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_e5f71ed1","line":71,"updated":"2015-07-28 15:56:54.000000000","message":"if this is not set, you do not add any serial ports to the VMs.\n\nI think its worth adding that detail in here.","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    \u0027system.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027Identifies the remote system that serial port traffic \u0027"},{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":73,"context_line":"               help\u003d\u0027Identifies a proxy service that provides network access \u0027"},{"line_number":74,"context_line":"                    \u0027to the serial_port_service_uri.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_c7a006f7","line":71,"in_reply_to":"3a50d1a3_e5f71ed1","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5803c82feb5f7f07eecf66d0ba024f041570f00","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":73,"context_line":"               help\u003d\u0027Identifies a proxy service that provides network access \u0027"},{"line_number":74,"context_line":"                    \u0027to the serial_port_service_uri.\u0027),"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_e294f48b","line":74,"updated":"2015-07-28 15:56:54.000000000","message":"I think this should also note, that this is ignored if serial_port_service_uri is not set.","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4f1fc55518f49a15546642cf0b9fec1166575b9e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027will be sent to.\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":73,"context_line":"               help\u003d\u0027Identifies a proxy service that provides network access \u0027"},{"line_number":74,"context_line":"                    \u0027to the serial_port_service_uri.\u0027),"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_87a67e0d","line":74,"in_reply_to":"3a50d1a3_e294f48b","updated":"2015-08-03 08:29:07.000000000","message":"Done","commit_id":"63112f106f8a02d0d452c7f1312b103a35e4e4f3"}]}