)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e35f8caf107c3fc7d0506bf017d272c89ef03742","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Using Instance object instead of db call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It would be better to use the Instance object for all"},{"line_number":10,"context_line":"the instance related db calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I673727513b66e8a6bdbbe0c037c32b92710e2cc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_7e77d59f","line":10,"updated":"2015-03-11 17:46:34.000000000","message":"Please add:\n\n Blueprint: kilo-objects","commit_id":"5eecf904758a92c8b7de4afb723190189f2b72c5"}],"nova/tests/unit/console/test_console.py":[{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"02eac8546234c26ce1565fb41e545fd0b216c157","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027get_console_topic\u0027,"},{"line_number":171,"context_line":"                       return_value\u003d\u0027compute.fake_host\u0027)"},{"line_number":172,"context_line":"    @mock.patch.object(objects.Instance, \u0027get_by_uuid\u0027)"},{"line_number":173,"context_line":"    def test_create_console(self, mock_instance, mock_console_topic):"},{"line_number":174,"context_line":"        mock_instance.return_value \u003d objects.Instance(**self.fake_instance)"},{"line_number":175,"context_line":"        self.console_api.create_console(self.context, self.fake_uuid)"},{"line_number":176,"context_line":"        self.assertTrue(mock_console_topic.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_dc8c2d82","line":173,"updated":"2015-02-03 12:29:46.000000000","message":"I would suggest these parameters have more meaningful names, like mock_get_instance_by_uuid and mock_get_console_topic. Reading mock_instance I actually thought it was an instance object. What do you think?","commit_id":"e1c833872e155414a09db51b9684a258b60dd5cb"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"dac58e5cf6a8bfb834601c34fca037798fc3cccd","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027get_console_topic\u0027,"},{"line_number":171,"context_line":"                       return_value\u003d\u0027compute.fake_host\u0027)"},{"line_number":172,"context_line":"    @mock.patch.object(objects.Instance, \u0027get_by_uuid\u0027)"},{"line_number":173,"context_line":"    def test_create_console(self, mock_instance, mock_console_topic):"},{"line_number":174,"context_line":"        mock_instance.return_value \u003d objects.Instance(**self.fake_instance)"},{"line_number":175,"context_line":"        self.console_api.create_console(self.context, self.fake_uuid)"},{"line_number":176,"context_line":"        self.assertTrue(mock_console_topic.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b31cf178","line":173,"in_reply_to":"da86d52c_dc8c2d82","updated":"2015-02-03 20:04:41.000000000","message":"It make sense! Thanks!","commit_id":"e1c833872e155414a09db51b9684a258b60dd5cb"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e35f8caf107c3fc7d0506bf017d272c89ef03742","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        mock_get_instance_by_uuid.return_value \u003d objects.Instance("},{"line_number":176,"context_line":"            **self.fake_instance)"},{"line_number":177,"context_line":"        self.console_api.create_console(self.context, self.fake_uuid)"},{"line_number":178,"context_line":"        self.assertTrue(mock_get_console_topic.called)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_be294d39","line":178,"updated":"2015-03-11 17:46:34.000000000","message":"Please assert that mock_get_console_topic was called with specific arguments, not just called at all. :)\n\n mock_get_console_topic.assert_called_once_with(\u0027fake_host\u0027)","commit_id":"5eecf904758a92c8b7de4afb723190189f2b72c5"}]}