)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2e90ca05a8ac477a10fcd698e7dfb98a8a28e60","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          instance\u003dinstance,"},{"line_number":369,"context_line":"                          dest_check_data\u003ddest_check_data)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def check_instance_shared_storage(self, ctxt, instance, data, host\u003dNone):"},{"line_number":372,"context_line":"        if self.client.can_send_version(\u00273.29\u0027):"},{"line_number":373,"context_line":"            version \u003d \u00273.29\u0027"},{"line_number":374,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_3e5f2010","line":371,"updated":"2015-04-06 16:07:45.000000000","message":"This is probably not allowed in a backport.\n\n--\n\nHmm, maybe it\u0027s OK:\n\nhttps://review.openstack.org/#/c/154761/4/nova/compute/rpcapi.py","commit_id":"d53001f00fa6aa8e692d476e65b0a22cb8c0bc97"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"17387c54b2dd24edd14de02e608b68378277c154","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          instance\u003dinstance,"},{"line_number":369,"context_line":"                          dest_check_data\u003ddest_check_data)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def check_instance_shared_storage(self, ctxt, instance, data, host\u003dNone):"},{"line_number":372,"context_line":"        if self.client.can_send_version(\u00273.29\u0027):"},{"line_number":373,"context_line":"            version \u003d \u00273.29\u0027"},{"line_number":374,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_4c9b0473","line":371,"in_reply_to":"9aa53dc9_3e5f2010","updated":"2015-04-21 17:55:54.000000000","message":"This doesn\u0027t change the actual RPC signature, so it\u0027s okay (and doesn\u0027t need a version bump either)","commit_id":"d53001f00fa6aa8e692d476e65b0a22cb8c0bc97"}],"nova/tests/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e632eb833baa41faf392572c56573a6267ddc0f5","unresolved":false,"context_lines":[{"line_number":3084,"context_line":"            self.assertEqual(\"error\", self.migration.status)"},{"line_number":3085,"context_line":"            migration_save.assert_has_calls([mock.call(elevated_context)])"},{"line_number":3086,"context_line":""},{"line_number":3087,"context_line":"    @mock.patch.object(objects.InstanceActionEvent,"},{"line_number":3088,"context_line":"                       \u0027event_start\u0027)"},{"line_number":3089,"context_line":"    @mock.patch.object(objects.InstanceActionEvent,"},{"line_number":3090,"context_line":"                       \u0027event_finish_with_failure\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_a4bc306d","line":3087,"updated":"2015-04-20 16:01:35.000000000","message":"These appear to be only in this proposed backport, why?  I don\u0027t see them in either of these:\n\nhttps://review.openstack.org/#/c/139693/9/nova/tests/unit/compute/test_compute_mgr.py\n\nhttps://review.openstack.org/#/c/154761/4/nova/tests/unit/compute/test_compute_mgr.py","commit_id":"d53001f00fa6aa8e692d476e65b0a22cb8c0bc97"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7478678fb72759b190afb4e8772b8cd929d3ba0","unresolved":false,"context_lines":[{"line_number":3084,"context_line":"            self.assertEqual(\"error\", self.migration.status)"},{"line_number":3085,"context_line":"            migration_save.assert_has_calls([mock.call(elevated_context)])"},{"line_number":3086,"context_line":""},{"line_number":3087,"context_line":"    @mock.patch.object(objects.InstanceActionEvent,"},{"line_number":3088,"context_line":"                       \u0027event_start\u0027)"},{"line_number":3089,"context_line":"    @mock.patch.object(objects.InstanceActionEvent,"},{"line_number":3090,"context_line":"                       \u0027event_finish_with_failure\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_eff1e1ce","line":3087,"in_reply_to":"dac4157f_a4bc306d","updated":"2015-04-20 16:15:52.000000000","message":"OK, these are needed on stable/juno because we didn\u0027t backport this https://review.openstack.org/#/c/146213/ to stable/juno - but that\u0027s why they aren\u0027t needed on kilo+.","commit_id":"d53001f00fa6aa8e692d476e65b0a22cb8c0bc97"}]}