)]}'
{"nova/api/openstack/common.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"99b123a9d5bc947fdd486edca5e90eaf5c33d4a6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    sort_keys \u003d []"},{"line_number":194,"context_line":"    sort_dirs \u003d []"},{"line_number":195,"context_line":"    if \u0027sort\u0027 in params:"},{"line_number":196,"context_line":"        for sort in params[\u0027sort\u0027].strip().split(\u0027,\u0027):"},{"line_number":197,"context_line":"            sort_key, _sep, sort_dir \u003d sort.partition(\u0027:\u0027)"},{"line_number":198,"context_line":"            if not sort_dir:"},{"line_number":199,"context_line":"                sort_dir \u003d default_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b29404e3","line":196,"updated":"2015-02-23 20:03:02.000000000","message":":( Why are we going with comma-delimited parameters here? I thought we were sticking with:\n\n sort\u003dkey1:desc\u0026sort\u003dkey2:asc\n\nSeems adding in comma-delimiting for a single parameter here is backwards and inconsistent with the way we\u0027ve used (correctly) multiple named param support in querystring so far.","commit_id":"f1f7f4752b51857b6611daa6047edeaaeae0c012"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"25f84ae93f9378f271ff4c9d0c8ed0ddc145b5b2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    sort_keys \u003d []"},{"line_number":194,"context_line":"    sort_dirs \u003d []"},{"line_number":195,"context_line":"    if \u0027sort\u0027 in params:"},{"line_number":196,"context_line":"        for sort in params[\u0027sort\u0027].strip().split(\u0027,\u0027):"},{"line_number":197,"context_line":"            sort_key, _sep, sort_dir \u003d sort.partition(\u0027:\u0027)"},{"line_number":198,"context_line":"            if not sort_dir:"},{"line_number":199,"context_line":"                sort_dir \u003d default_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_f5890627","line":196,"in_reply_to":"ba7be1f8_b29404e3","updated":"2015-02-23 20:21:20.000000000","message":"Jay, so the API WG guideline was merged with the comma-separated implementation recommendation since it was deemed more compact and easier to understand; see Ian\u0027s comment at the very end of [1].\n\nAlso, this concept (for better or worse) is forging ahead in other reviews, specifically the tag guideline [2].\n\nAny thoughts on what you\u0027d like to see done with the implementation here?  Possibly support both a comma-separated \u0027sort\u0027 value and a repeated \u0027sort\u0027 parameter?\n\n[1] https://review.openstack.org/#/c/145579/5/guidelines/pagination_filter_sort.rst \n\n[2] https://review.openstack.org/#/c/155620/3/guidelines/tags.rst","commit_id":"f1f7f4752b51857b6611daa6047edeaaeae0c012"}]}