)]}'
{"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ea73ba15875d879bb0c721848ab9d6e930d7a32e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        disk_bus \u003d osinfo.HardwareProperties(image_meta).disk_model"},{"line_number":240,"context_line":"    else:"},{"line_number":241,"context_line":"        key \u003d \"hw_\" + device_type + \"_bus\""},{"line_number":242,"context_line":"        disk_bus \u003d image_meta.properties.get(key)"},{"line_number":243,"context_line":"    if disk_bus is not None:"},{"line_number":244,"context_line":"        if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":245,"context_line":"            raise exception.UnsupportedHardware(model\u003ddisk_bus,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa69d971_9bc9715d","line":242,"updated":"2016-01-07 16:23:59.000000000","message":"Don\u0027t we want to prefer disk bus specified from image properties is there any defined ?","commit_id":"d50e760504b3cb84df144c04113e087bffe4cc7d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"382cac724d1543fb82c974a352b3f18a0c1beaae","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        disk_bus \u003d osinfo.HardwareProperties(image_meta).disk_model"},{"line_number":240,"context_line":"    else:"},{"line_number":241,"context_line":"        key \u003d \"hw_\" + device_type + \"_bus\""},{"line_number":242,"context_line":"        disk_bus \u003d image_meta.properties.get(key)"},{"line_number":243,"context_line":"    if disk_bus is not None:"},{"line_number":244,"context_line":"        if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":245,"context_line":"            raise exception.UnsupportedHardware(model\u003ddisk_bus,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa69d971_a17682d6","line":242,"in_reply_to":"fa69d971_3ed4f345","updated":"2016-01-07 17:08:37.000000000","message":"Oh right... :s","commit_id":"d50e760504b3cb84df144c04113e087bffe4cc7d"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"1a5dd457c3a7d65b10047b883b61a0449008f913","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        disk_bus \u003d osinfo.HardwareProperties(image_meta).disk_model"},{"line_number":240,"context_line":"    else:"},{"line_number":241,"context_line":"        key \u003d \"hw_\" + device_type + \"_bus\""},{"line_number":242,"context_line":"        disk_bus \u003d image_meta.properties.get(key)"},{"line_number":243,"context_line":"    if disk_bus is not None:"},{"line_number":244,"context_line":"        if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":245,"context_line":"            raise exception.UnsupportedHardware(model\u003ddisk_bus,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa69d971_3ed4f345","line":242,"in_reply_to":"fa69d971_9bc9715d","updated":"2016-01-07 16:36:49.000000000","message":"So this is exactly what the HardwareProperties does.\nPrefers Image properties, otherwise goes to libosinfo, if not it will rely on libvirt defaults.. \nIt\u0027s just we have only hw_disk_bus defined in libosinfo, so this else is still needed.","commit_id":"d50e760504b3cb84df144c04113e087bffe4cc7d"}]}