)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b5071704f9679b1bc1fcbbd9a61bf2b1420afe29","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rather a collection of values gathered from issuing different db calls"},{"line_number":15,"context_line":"and converting returned values to ec2 format."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related to blueprint kilo-objects"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I068acf687c116e3c75a352616b9555486a165423"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9aa53dc9_cd8d75d4","line":17,"updated":"2015-04-10 14:43:08.000000000","message":"This needs to change now. I registered and approved liberty-objects just now, so you can respin on that.","commit_id":"757b91dd825d6fd89037792ebcb53d7736163278"}],"nova/objects/ec2.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"01314557768ec116b2b09c94d28f7dfe465942d8","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    }"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @staticmethod"},{"line_number":194,"context_line":"    def _from_dict(ec2ids, dict_ec2ids):"},{"line_number":195,"context_line":"        for field in ec2ids.fields:"},{"line_number":196,"context_line":"            setattr(ec2ids, field, dict_ec2ids[field])"},{"line_number":197,"context_line":"        return ec2ids"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_0155954f","line":194,"updated":"2015-02-23 10:50:29.000000000","message":"I see, you don\u0027t want to use a private method member of the class here because you call it from the cls object?","commit_id":"478a7e7215c77e667b8e50708d93ca7585abbd38"}],"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7cd820adfeae95eaade86f470f1f2744dfccbb9e","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                ec2_ids[\u0027%s-id\u0027 % image_type] \u003d ec2_id"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"        return ec2_ids"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":1073,"context_line":"    get_fault \u003d expected_attrs and \u0027fault\u0027 in expected_attrs"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_0994aa42","line":1070,"updated":"2015-02-17 18:29:11.000000000","message":"So, a couple of comments here. First, you\u0027re returning a slightly complex unversioned structure from a remotable method. That makes it hard to determine if it\u0027s ever changed, and/or codify the rules under which we can augment or change it in the future. Further, this seems like data that we would know ahead of time if we\u0027re going to need, and thus would want to just pre-request so that we don\u0027t need to make another round trip every time.\n\nWhat would you think of making this a field in the instance that we can request in expected_attrs when we want it?\n\nIn either case, I think it would probably be good to make this a nested object so that we define what things are in it, and can handle the case where it may need to change or expand in the future.\n\nThoughts?","commit_id":"9fe67c0be6a156b57e60b14b05b34e0abfa91925"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"64cd98e6c818f3b0677a246f650e154c5edc6b52","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                ec2_ids[\u0027%s-id\u0027 % image_type] \u003d ec2_id"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"        return ec2_ids"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":1073,"context_line":"    get_fault \u003d expected_attrs and \u0027fault\u0027 in expected_attrs"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_8917ba53","line":1070,"in_reply_to":"da86d52c_0994aa42","updated":"2015-02-17 18:48:37.000000000","message":"Makes absolute sense. I will go ahead and re-work this to be in line with those thoughts.","commit_id":"9fe67c0be6a156b57e60b14b05b34e0abfa91925"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"099d04ab6cc0ef467b30a5e35230a6dbc15cb55c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        primitive \u003d inst.obj_to_primitive()"},{"line_number":77,"context_line":"        expected \u003d {\u0027nova_object.name\u0027: \u0027Instance\u0027,"},{"line_number":78,"context_line":"                    \u0027nova_object.namespace\u0027: \u0027nova\u0027,"},{"line_number":79,"context_line":"                    \u0027nova_object.version\u0027: inst.VERSION,"},{"line_number":80,"context_line":"                    \u0027nova_object.data\u0027:"},{"line_number":81,"context_line":"                        {\u0027uuid\u0027: \u0027fake-uuid\u0027,"},{"line_number":82,"context_line":"                         \u0027launched_at\u0027: \u00271955-11-05T00:00:00Z\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_ef3e6c8b","line":79,"updated":"2015-03-06 14:49:25.000000000","message":"I\u0027ve been meaning to make this change for a while, so thanks.","commit_id":"87df141186e7e18833e5bb6c6d690c0f1b8f5011"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"099d04ab6cc0ef467b30a5e35230a6dbc15cb55c","unresolved":false,"context_lines":[{"line_number":758,"context_line":"    def test_create_with_values(self, mock_ec2):"},{"line_number":759,"context_line":"        mock_ec2.return_value \u003d objects.EC2Ids(instance_id\u003d\u0027fake-inst-id\u0027,"},{"line_number":760,"context_line":"                                               ami_id\u003d\u0027fake-ami-id\u0027,"},{"line_number":761,"context_line":"                                               kernel_id\u003dNone, ramdisk_id\u003dNone)"},{"line_number":762,"context_line":"        inst1 \u003d instance.Instance(context\u003dself.context,"},{"line_number":763,"context_line":"                                  user_id\u003dself.context.user_id,"},{"line_number":764,"context_line":"                                  project_id\u003dself.context.project_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_af9ab46b","line":761,"updated":"2015-03-06 14:49:25.000000000","message":"Hmm, why is this necessary? Nothing in this test requests or touches .ec2_ids, so we shouldn\u0027t need to provide a mock for it, right?\n\nSame for a bunch of the tests below...","commit_id":"87df141186e7e18833e5bb6c6d690c0f1b8f5011"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b4c955b2ad052d67db8cf7a6e86cb99607094423","unresolved":false,"context_lines":[{"line_number":758,"context_line":"    def test_create_with_values(self, mock_ec2):"},{"line_number":759,"context_line":"        mock_ec2.return_value \u003d objects.EC2Ids(instance_id\u003d\u0027fake-inst-id\u0027,"},{"line_number":760,"context_line":"                                               ami_id\u003d\u0027fake-ami-id\u0027,"},{"line_number":761,"context_line":"                                               kernel_id\u003dNone, ramdisk_id\u003dNone)"},{"line_number":762,"context_line":"        inst1 \u003d instance.Instance(context\u003dself.context,"},{"line_number":763,"context_line":"                                  user_id\u003dself.context.user_id,"},{"line_number":764,"context_line":"                                  project_id\u003dself.context.project_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_d5e4bb3d","line":761,"in_reply_to":"9a80dd14_af9ab46b","updated":"2015-03-07 09:17:43.000000000","message":"Agh, not sure why I put it here, its definitely not needed. Had it been, something in the code would indeed be wrong. Thanks.","commit_id":"87df141186e7e18833e5bb6c6d690c0f1b8f5011"}]}