)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dd2253cf332aa3907a1660858e2da244f0299a93","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hypervisor-stas show wrong disk usages with shared storage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_af4a9a23","line":9,"updated":"2015-01-26 03:23:03.000000000","message":"cph -\u003e ceph","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"398d91021b3f6d66ac0db71f629d2bf39de9bab8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hypervisor-stas show wrong disk usages with shared storage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_8673864c","line":9,"in_reply_to":"1a930d6b_af4a9a23","updated":"2015-01-28 10:23:24.000000000","message":"Done","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"42434c124583fe6b3cbd880e8540bede4f722ed7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hypervisor-stas show wrong disk usages with shared storage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_e9aed8e6","line":10,"updated":"2015-01-28 09:15:44.000000000","message":"s/caculate/calculate","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"398d91021b3f6d66ac0db71f629d2bf39de9bab8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hypervisor-stas show wrong disk usages with shared storage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_267c9a20","line":10,"in_reply_to":"fa81d914_e9aed8e6","updated":"2015-01-28 10:23:24.000000000","message":"Done","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"42434c124583fe6b3cbd880e8540bede4f722ed7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":14,"context_line":"That will show that disk usage \u003d {actual disk usage} * {number of"},{"line_number":15,"context_line":"compuet node}"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_29b9d02e","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":38},"updated":"2015-01-28 09:15:44.000000000","message":"s/geting/getting/","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"398d91021b3f6d66ac0db71f629d2bf39de9bab8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"While using shared storage like cph, each compute node reports its disk"},{"line_number":10,"context_line":"usage with total backend pool disk usage, this makes sense to caculate"},{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":14,"context_line":"That will show that disk usage \u003d {actual disk usage} * {number of"},{"line_number":15,"context_line":"compuet node}"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_46798e2e","line":12,"in_reply_to":"fa81d914_29b9d02e","updated":"2015-01-28 10:23:24.000000000","message":"Done","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dd2253cf332aa3907a1660858e2da244f0299a93","unresolved":false,"context_lines":[{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":14,"context_line":"That will show that disk usage \u003d {actual disk usage} * {number of"},{"line_number":15,"context_line":"compuet node}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: Add new config option shared_storage to indicate shared"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_2f66aac1","line":14,"updated":"2015-01-26 03:23:03.000000000","message":"That will show that disk usage -\u003e That will show the disk usage?","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"398d91021b3f6d66ac0db71f629d2bf39de9bab8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":12,"context_line":"to this compute node. But while geting hypervisor-stats, we sum all the"},{"line_number":13,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":14,"context_line":"That will show that disk usage \u003d {actual disk usage} * {number of"},{"line_number":15,"context_line":"compuet node}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: Add new config option shared_storage to indicate shared"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_66769240","line":14,"in_reply_to":"1a930d6b_2f66aac1","updated":"2015-01-28 10:23:24.000000000","message":"Done","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"}],"nova/compute/api.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dd2253cf332aa3907a1660858e2da244f0299a93","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                     \u0027in a local image being created on the hypervisor node. \u0027"},{"line_number":117,"context_line":"                     \u0027Setting this to 0 means nova will allow only \u0027"},{"line_number":118,"context_line":"                     \u0027boot from volume. A negative number means unlimited.\u0027),"},{"line_number":119,"context_line":"    cfg.BoolOpt(\u0027shared_storage\u0027,"},{"line_number":120,"context_line":"                default\u003dFalse,"},{"line_number":121,"context_line":"                help\u003d\u0027Shared storage for instances or not.\u0027),"},{"line_number":122,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_8ffb1ec0","line":119,"updated":"2015-01-26 03:23:03.000000000","message":"cannot we derive from other options if we are using shared storage or not?\nok on second thought, it is not easy to do this derivation.","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"398d91021b3f6d66ac0db71f629d2bf39de9bab8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                     \u0027in a local image being created on the hypervisor node. \u0027"},{"line_number":117,"context_line":"                     \u0027Setting this to 0 means nova will allow only \u0027"},{"line_number":118,"context_line":"                     \u0027boot from volume. A negative number means unlimited.\u0027),"},{"line_number":119,"context_line":"    cfg.BoolOpt(\u0027shared_storage\u0027,"},{"line_number":120,"context_line":"                default\u003dFalse,"},{"line_number":121,"context_line":"                help\u003d\u0027Shared storage for instances or not.\u0027),"},{"line_number":122,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_66adb288","line":119,"in_reply_to":"1a930d6b_8ffb1ec0","updated":"2015-01-28 10:23:24.000000000","message":"Yes, this is for all  the hypervisors, can\u0027t import from specific hypervsior.","commit_id":"98370fb1f32a1ac346275bfdfd1848da10047f5a"}],"nova/conf/compute.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b2b7e305781126eef59289f7d7b2f4ded79d9b56","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        default\u003dFalse,"},{"line_number":103,"context_line":"        help\u003d\"\"\""},{"line_number":104,"context_line":"Shared storage for instances or not."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While using shared storage like ceph, each compute node reports its disk"},{"line_number":107,"context_line":"usage with total backend pool disk usage, this makes sense to calculate"},{"line_number":108,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":109,"context_line":"to this compute node. But while getting hypervisor-stats, we sum all the"},{"line_number":110,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This option is used to distinguish different way to calculate disk usage."},{"line_number":113,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_7b7f2ebc","line":110,"range":{"start_line":105,"start_character":0,"end_line":110,"end_character":69},"updated":"2018-07-24 08:58:39.000000000","message":"I didn\u0027t review all the changes now, but regardless of the rest changes, this seems inappropriate here","commit_id":"86a52308c787d71e0f2ff67e1833234c1dabc314"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"188a18a0df4b987ae0f1ab33c59104f73290e790","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        default\u003dFalse,"},{"line_number":103,"context_line":"        help\u003d\"\"\""},{"line_number":104,"context_line":"Shared storage for instances or not."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While using shared storage like ceph, each compute node reports its disk"},{"line_number":107,"context_line":"usage with total backend pool disk usage, this makes sense to calculate"},{"line_number":108,"context_line":"incoming resource request like booting a new instance or migrating instance"},{"line_number":109,"context_line":"to this compute node. But while getting hypervisor-stats, we sum all the"},{"line_number":110,"context_line":"compute nodes\u0027s disk usage, that doesn\u0027t make sense for ceph backend."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This option is used to distinguish different way to calculate disk usage."},{"line_number":113,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_75b624de","line":110,"range":{"start_line":105,"start_character":0,"end_line":110,"end_character":69},"in_reply_to":"5f7c97a3_7b7f2ebc","updated":"2018-07-26 06:23:44.000000000","message":"Done","commit_id":"86a52308c787d71e0f2ff67e1833234c1dabc314"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6bdf6eee42e19bef88a0e44438da376f71c78ba4","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* True: Average all the compute node\u0027s disk usage"},{"line_number":112,"context_line":"* False: Sum all the compute node\u0027s disk usage"},{"line_number":113,"context_line":"\"\"\"),"},{"line_number":114,"context_line":"    cfg.ListOpt(\u0027compute_monitors\u0027,"},{"line_number":115,"context_line":"        default\u003d[],"},{"line_number":116,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_db649e4f","line":113,"updated":"2018-07-31 18:06:53.000000000","message":"Being that shared storage support using placement is in-progress and the lack of correct shared storage calculation in hypervisor-stats is very latent, I don\u0027t expect a patch like this will get support. This has been proposed and rejected several times in the past.\n\nAside from that, this is not a bug/regression in Nova and is an API change, which requires a spec and discussion around it, at the least.","commit_id":"d6745c7e7b27e86e66710c0882d948fcdf95e4a4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7c3aa6a96443a6a854e7a21d308501f451e3018","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* True: Average all the compute node\u0027s disk usage"},{"line_number":112,"context_line":"* False: Sum all the compute node\u0027s disk usage"},{"line_number":113,"context_line":"\"\"\"),"},{"line_number":114,"context_line":"    cfg.ListOpt(\u0027compute_monitors\u0027,"},{"line_number":115,"context_line":"        default\u003d[],"},{"line_number":116,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_1ad5dd1b","line":113,"updated":"2019-03-04 20:27:28.000000000","message":"i agree with melanie on both point. this would require a spec and it is not a bug or regression. it is know behavior that has been rejected several times.\naddtionally we tend to avoid any config options that would alter api behavior as that is impossible to detect form the api as a result it creates issues for interoperablity between different openstack clouds.\n\nwith this change consumers fo teh api cannot know if the disk usage repoert is an average or sum of total usage. finally if we were to have a config option instead of calualting an average we would instead want to calulate the actul disk usage for each instance that is on the current host or at least discuss the merits of actual vs average vs total all of which should be captured in a spec and documented in the admin guides and summarised in the release notes.","commit_id":"d6745c7e7b27e86e66710c0882d948fcdf95e4a4"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ae7ff34ddacbb1da5baecf448003f6529521c41d","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    inner_sel \u003d sa.alias(_compute_node_select(context), name\u003d\u0027inner_sel\u0027)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    storage_func \u003d sql.func.sum if not CONF.shared_storage else sql.func.avg"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    # TODO(sbauza): Remove the service_id filter in a later release"},{"line_number":737,"context_line":"    # once we are sure that all compute nodes report the host field"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_32a96277","line":734,"range":{"start_line":734,"start_character":4,"end_line":734,"end_character":76},"updated":"2018-07-30 05:55:36.000000000","message":"it\u0027s a good idea but for some edge case, such as part of the compute node in shared and part of not in shared, can this cover because it will after all access all db data..","commit_id":"d6745c7e7b27e86e66710c0882d948fcdf95e4a4"}],"releasenotes/notes/add_shared_storage_option-1c17c37d8649785c.yaml":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"88e2da20766e3973d2e68085e4d89addd09facb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``shared_storage`` config option is added so that nova can"},{"line_number":5,"context_line":"    calculate the disk usage accurately while getting hypervisor-stats."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_8a6dd668","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":71},"updated":"2018-07-26 09:30:49.000000000","message":"I suggest to be more clear about how is it more accurate with this option","commit_id":"8a28d74a11adc3d043c8717c3c9a66e2a077705e"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"77d27f37b4056aed2a5cceb0a3cecae36d8d6302","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``shared_storage`` config option is added so that nova can"},{"line_number":5,"context_line":"    calculate the disk usage accurately while getting hypervisor-stats."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_195b4b23","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":71},"in_reply_to":"5f7c97a3_8a6dd668","updated":"2018-07-27 09:20:12.000000000","message":"Done","commit_id":"8a28d74a11adc3d043c8717c3c9a66e2a077705e"}]}