)]}'
{"nova/servicegroup/drivers/zk.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"95b71dcdf24d80201508f286b8e0b3487ef53a32","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        super(ZooKeeperDriver, self).__init__()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        member \u003d self._memberships.get((group, member_id), None)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def join(self, member, group, service\u003dNone):"},{"line_number":80,"context_line":"        \"\"\"Add a new member to a service group."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b784180c","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":45},"updated":"2015-02-16 10:24:38.000000000","message":"F821 undefined name \u0027group\u0027","commit_id":"b85a6099c9b803528b56f07780414a48b6185666"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"95b71dcdf24d80201508f286b8e0b3487ef53a32","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        super(ZooKeeperDriver, self).__init__()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        member \u003d self._memberships.get((group, member_id), None)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def join(self, member, group, service\u003dNone):"},{"line_number":80,"context_line":"        \"\"\"Add a new member to a service group."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_578e7c28","line":77,"range":{"start_line":77,"start_character":47,"end_line":77,"end_character":56},"updated":"2015-02-16 10:24:38.000000000","message":"F821 undefined name \u0027member_id\u0027","commit_id":"b85a6099c9b803528b56f07780414a48b6185666"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"95b71dcdf24d80201508f286b8e0b3487ef53a32","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        super(ZooKeeperDriver, self).__init__()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        member \u003d self._memberships.get((group, member_id), None)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def join(self, member, group, service\u003dNone):"},{"line_number":80,"context_line":"        \"\"\"Add a new member to a service group."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_3799087a","line":77,"updated":"2015-02-16 10:24:38.000000000","message":"F841 local variable \u0027member\u0027 is assigned to but never used","commit_id":"b85a6099c9b803528b56f07780414a48b6185666"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"95b71dcdf24d80201508f286b8e0b3487ef53a32","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        member \u003d self._memberships.get((group, member), None)"},{"line_number":92,"context_line":"        if member is None:"},{"line_number":93,"context_line":"            # the first time to join. Generate a new object"},{"line_number":94,"context_line":"            path \u003d \"%s/%s/%s\" % (CONF.zookeeper.sg_prefix, group, member_id)"},{"line_number":95,"context_line":"            try:"},{"line_number":96,"context_line":"                zk_member \u003d membership.Membership(self._session, path, process_id)"},{"line_number":97,"context_line":"            except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_37a748a9","line":94,"range":{"start_line":94,"start_character":66,"end_line":94,"end_character":75},"updated":"2015-02-16 10:24:38.000000000","message":"F821 undefined name \u0027member_id\u0027","commit_id":"b85a6099c9b803528b56f07780414a48b6185666"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"95b71dcdf24d80201508f286b8e0b3487ef53a32","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            # the first time to join. Generate a new object"},{"line_number":94,"context_line":"            path \u003d \"%s/%s/%s\" % (CONF.zookeeper.sg_prefix, group, member_id)"},{"line_number":95,"context_line":"            try:"},{"line_number":96,"context_line":"                zk_member \u003d membership.Membership(self._session, path, process_id)"},{"line_number":97,"context_line":"            except RuntimeError:"},{"line_number":98,"context_line":"                LOG.exception(_LE(\"Unable to join. It is possible that either\""},{"line_number":99,"context_line":"                                  \" another node exists with the same name, or\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b79b3865","line":96,"updated":"2015-02-16 10:24:38.000000000","message":"E501 line too long (82 \u003e 79 characters)","commit_id":"b85a6099c9b803528b56f07780414a48b6185666"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"c2b54de3b28a753aab45c00712c5e38f0d1e8e6c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                        \u0027of it in production right now may be risky.\u0027))"},{"line_number":108,"context_line":"        return session"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        member \u003d self._memberships.get((group, member_id), None)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def join(self, member, group, service\u003dNone):"},{"line_number":113,"context_line":"        \"\"\"Add a new member to a service group."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_3460b0ce","line":110,"updated":"2015-03-08 15:59:15.000000000","message":"What purpose of this `member` after return statement?","commit_id":"a2eac0d7c164a83068290da3964e47d3ed9ec459"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"c2b54de3b28a753aab45c00712c5e38f0d1e8e6c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :param service: a `nova.service.Service` object"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        process_id \u003d str(os.getpid())"},{"line_number":120,"context_line":"        LOG.debug(\u0027ZooKeeperDriver: join new member %(id)s(%(pid)s) to the \u0027"},{"line_number":121,"context_line":"                  \u0027%(gr)s group, service\u003d%(sr)s\u0027,"},{"line_number":122,"context_line":"                  {\u0027id\u0027: member, \u0027pid\u0027: process_id,"},{"line_number":123,"context_line":"                   \u0027gr\u0027: group, \u0027sr\u0027: service})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_b4a3c0fe","line":120,"updated":"2015-03-08 15:59:15.000000000","message":"If we going to change name of the function to `add` I believe that log message should be changed too(join new member -\u003e add a new member).\nIt is nice to have _LD ()","commit_id":"a2eac0d7c164a83068290da3964e47d3ed9ec459"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"c2b54de3b28a753aab45c00712c5e38f0d1e8e6c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        member \u003d self._memberships.get((group, member), None)"},{"line_number":125,"context_line":"        if member is None:"},{"line_number":126,"context_line":"            # the first time to join. Generate a new object"},{"line_number":127,"context_line":"            path \u003d \"%s/%s/%s\" % (CONF.zookeeper.sg_prefix, group, member_id)"},{"line_number":128,"context_line":"            try:"},{"line_number":129,"context_line":"                zk_member \u003d membership.Membership(self._session, path, process_id)"},{"line_number":130,"context_line":"            except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_943ebc8a","line":127,"updated":"2015-03-08 15:59:15.000000000","message":"Since `member_id` argument is changed to `member` we cannot use member_id here.","commit_id":"a2eac0d7c164a83068290da3964e47d3ed9ec459"}]}